public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libfortran/61310] New: Regression, CTIME intrinsic incorrect result string
@ 2014-05-25 20:06 jb at gcc dot gnu.org
  2014-05-25 21:22 ` [Bug libfortran/61310] " jb at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: jb at gcc dot gnu.org @ 2014-05-25 20:06 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61310

            Bug ID: 61310
           Summary: Regression, CTIME intrinsic incorrect result string
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jb at gcc dot gnu.org

As a result of PR 47432, the CTIME intrinsic was changed to use the ctime_r()
function if available instead of the C stdlib ctime(). However, due to some
problems that was changed to use strftime with the "%c" specifier, see PR
47802. 

Now it seems that on the mingw target, strftime(...,"%c",...) doesn't produce
the same output as ctime{_r}() *sigh*, see
https://stackoverflow.com/questions/23787340/format-of-ctime-output-in-fortran
. 

Probably we could use something like the implementation suggested in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47802#c14


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libfortran/61310] Regression, CTIME intrinsic incorrect result string
  2014-05-25 20:06 [Bug libfortran/61310] New: Regression, CTIME intrinsic incorrect result string jb at gcc dot gnu.org
@ 2014-05-25 21:22 ` jb at gcc dot gnu.org
  2014-05-26 18:29 ` jb at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: jb at gcc dot gnu.org @ 2014-05-25 21:22 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61310

Janne Blomqvist <jb at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/ml/gcc-
                   |                            |patches/2014-05/msg02124.ht
                   |                            |ml
           Assignee|unassigned at gcc dot gnu.org      |jb at gcc dot gnu.org

--- Comment #1 from Janne Blomqvist <jb at gcc dot gnu.org> ---
Patch at https://gcc.gnu.org/ml/gcc-patches/2014-05/msg02124.html


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libfortran/61310] Regression, CTIME intrinsic incorrect result string
  2014-05-25 20:06 [Bug libfortran/61310] New: Regression, CTIME intrinsic incorrect result string jb at gcc dot gnu.org
  2014-05-25 21:22 ` [Bug libfortran/61310] " jb at gcc dot gnu.org
@ 2014-05-26 18:29 ` jb at gcc dot gnu.org
  2014-05-26 18:36 ` jb at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: jb at gcc dot gnu.org @ 2014-05-26 18:29 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61310

--- Comment #3 from Janne Blomqvist <jb at gcc dot gnu.org> ---
Author: jb
Date: Mon May 26 18:28:49 2014
New Revision: 210941

URL: http://gcc.gnu.org/viewcvs?rev=210941&root=gcc&view=rev
Log:
PR 61310 Rewrite implementation of CTIME and FDATE intrinsics.

2014-05-26  Janne Blomqvist  <jb@gcc.gnu.org>

    Backport from mainline
    PR libfortran/61310
    * intrinsics.texi (CTIME): Remove mention of locale-dependent
    behavior.

2014-05-26  Janne Blomqvist  <jb@gcc.gnu.org>

    Backport from mainline
    PR libfortran/61310
    * intrinsics/ctime.c (strctime): Rename to gf_ctime, use snprintf
    instead of strftime.
    (fdate): Use gf_ctime.
    (fdate_sub): Likewise.
    (ctime): Likewise.
    (ctime_sub): Likewise.

Modified:
    branches/gcc-4_9-branch/gcc/fortran/ChangeLog
    branches/gcc-4_9-branch/gcc/fortran/intrinsic.texi
    branches/gcc-4_9-branch/libgfortran/ChangeLog
    branches/gcc-4_9-branch/libgfortran/intrinsics/ctime.c


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libfortran/61310] Regression, CTIME intrinsic incorrect result string
  2014-05-25 20:06 [Bug libfortran/61310] New: Regression, CTIME intrinsic incorrect result string jb at gcc dot gnu.org
  2014-05-25 21:22 ` [Bug libfortran/61310] " jb at gcc dot gnu.org
  2014-05-26 18:29 ` jb at gcc dot gnu.org
@ 2014-05-26 18:36 ` jb at gcc dot gnu.org
  2014-05-26 19:45 ` jb at gcc dot gnu.org
  2014-05-26 19:46 ` jb at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: jb at gcc dot gnu.org @ 2014-05-26 18:36 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61310

--- Comment #4 from Janne Blomqvist <jb at gcc dot gnu.org> ---
Author: jb
Date: Mon May 26 18:36:01 2014
New Revision: 210943

URL: http://gcc.gnu.org/viewcvs?rev=210943&root=gcc&view=rev
Log:
PR 61310 Rewrite implementation of CTIME and FDATE intrinsics.

2014-05-26  Janne Blomqvist  <jb@gcc.gnu.org>

    Backport from mainline
    PR libfortran/61310
    * intrinsics.texi (CTIME): Remove mention of locale-dependent
    behavior.

2014-05-26  Janne Blomqvist  <jb@gcc.gnu.org>

    Backport from mainline
    PR libfortran/61310
    * intrinsics/ctime.c (strctime): Rename to gf_ctime, use snprintf
    instead of strftime.
    (fdate): Use gf_ctime.
    (fdate_sub): Likewise.
    (ctime): Likewise.
    (ctime_sub): Likewise.

Modified:
    branches/gcc-4_8-branch/gcc/fortran/ChangeLog
    branches/gcc-4_8-branch/gcc/fortran/intrinsic.texi
    branches/gcc-4_8-branch/libgfortran/ChangeLog
    branches/gcc-4_8-branch/libgfortran/intrinsics/ctime.c


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libfortran/61310] Regression, CTIME intrinsic incorrect result string
  2014-05-25 20:06 [Bug libfortran/61310] New: Regression, CTIME intrinsic incorrect result string jb at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2014-05-26 18:36 ` jb at gcc dot gnu.org
@ 2014-05-26 19:45 ` jb at gcc dot gnu.org
  2014-05-26 19:46 ` jb at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: jb at gcc dot gnu.org @ 2014-05-26 19:45 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61310

--- Comment #5 from Janne Blomqvist <jb at gcc dot gnu.org> ---
Author: jb
Date: Mon May 26 19:44:24 2014
New Revision: 210947

URL: http://gcc.gnu.org/viewcvs?rev=210947&root=gcc&view=rev
Log:
PR 61310 Rewrite implementation of CTIME and FDATE intrinsics.

2014-05-26  Janne Blomqvist  <jb@gcc.gnu.org>

    Backport from mainline
    PR libfortran/61310
    * intrinsics.texi (CTIME): Remove mention of locale-dependent
    behavior.

2014-05-26  Janne Blomqvist  <jb@gcc.gnu.org>

    Backport from mainline
    PR libfortran/61310
    * intrinsics/ctime.c (strctime): Rename to gf_ctime, use snprintf
    instead of strftime.
    (fdate): Use gf_ctime.
    (fdate_sub): Likewise.
    (ctime): Likewise.
    (ctime_sub): Likewise.

Modified:
    branches/gcc-4_7-branch/gcc/fortran/ChangeLog
    branches/gcc-4_7-branch/gcc/fortran/intrinsic.texi
    branches/gcc-4_7-branch/libgfortran/ChangeLog
    branches/gcc-4_7-branch/libgfortran/intrinsics/ctime.c


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug libfortran/61310] Regression, CTIME intrinsic incorrect result string
  2014-05-25 20:06 [Bug libfortran/61310] New: Regression, CTIME intrinsic incorrect result string jb at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2014-05-26 19:45 ` jb at gcc dot gnu.org
@ 2014-05-26 19:46 ` jb at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: jb at gcc dot gnu.org @ 2014-05-26 19:46 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61310

Janne Blomqvist <jb at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Janne Blomqvist <jb at gcc dot gnu.org> ---
Fixed on trunk/4.9/4.8/4.7, closing.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-05-26 19:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-25 20:06 [Bug libfortran/61310] New: Regression, CTIME intrinsic incorrect result string jb at gcc dot gnu.org
2014-05-25 21:22 ` [Bug libfortran/61310] " jb at gcc dot gnu.org
2014-05-26 18:29 ` jb at gcc dot gnu.org
2014-05-26 18:36 ` jb at gcc dot gnu.org
2014-05-26 19:45 ` jb at gcc dot gnu.org
2014-05-26 19:46 ` jb at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).