public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ro at CeBiTec dot Uni-Bielefeld.DE" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/61320] [4.10 regression] ICE in jcf-parse.c:1622 (parse_class_file
Date: Wed, 04 Jun 2014 08:10:00 -0000	[thread overview]
Message-ID: <bug-61320-4-5AHAAagwFF@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-61320-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61320

--- Comment #19 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
> (In reply to Eric Botcazou from comment #11)
>> > So I am testing the patch right now and should be able to send it tomorrow.
>> > However, the code already shall already mark the load with the actual
>> > alignment the access is being done with. Therefore it seems to me that
>> > something in the backend fails to split the unaligned load into several
>> > aligned load.
>> 
>> But what would be the point of this round trip exactly?
>
> I'd say
>
> Index: tree-ssa-math-opts.c
> ===================================================================
> --- tree-ssa-math-opts.c        (revision 211170)
> +++ tree-ssa-math-opts.c        (working copy)
> @@ -2149,7 +2149,8 @@ bswap_replace (gimple stmt, gimple_stmt_
>        unsigned align;
>
>        align = get_object_alignment (src);
> -      if (bswap && SLOW_UNALIGNED_ACCESS (TYPE_MODE (load_type), align))
> +      if (align < GET_MODE_ALIGNMENT (TYPE_MODE (load_type))
> +         && SLOW_UNALIGNED_ACCESS (TYPE_MODE (load_type), align))
>         return false;
>
>        /*  Compute address to load from and cast according to the size
>
> is obvious (and pre-approved).

I've now regtested that patch on sparc-sun-solaris2.11 (compared to a
bootstrap without java before) and i386-pc-solaris2.11.  No regressions,
but gcc.c-torture/execute/bswap-2.c is still failing on sparc.

Since it seems a non-workaround patch is now forthcoming, I'll hold off
on installing it, but instead keep it local for the moment.

Thanks.
        Rainer


  parent reply	other threads:[~2014-06-04  8:10 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-61320-4@http.gcc.gnu.org/bugzilla/>
2014-05-26 13:31 ` ro at gcc dot gnu.org
2014-05-26 13:47 ` rguenth at gcc dot gnu.org
2014-05-26 13:48 ` rguenth at gcc dot gnu.org
2014-05-26 14:06 ` ebotcazou at gcc dot gnu.org
2014-05-27  8:15 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-05-27  8:18 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-05-27  8:36 ` thomas.preudhomme at arm dot com
2014-05-30 20:27 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-05-31 14:13 ` ebotcazou at gcc dot gnu.org
2014-06-03  2:26 ` thomas.preudhomme at arm dot com
2014-06-03 10:17 ` thomas.preudhomme at arm dot com
2014-06-03 10:26 ` ebotcazou at gcc dot gnu.org
2014-06-03 11:20 ` rguenth at gcc dot gnu.org
2014-06-03 11:21 ` rguenth at gcc dot gnu.org
2014-06-03 11:23 ` rguenth at gcc dot gnu.org
2014-06-03 11:48 ` rguenth at gcc dot gnu.org
2014-06-03 19:27 ` ebotcazou at gcc dot gnu.org
2014-06-04  1:27 ` thomas.preudhomme at arm dot com
2014-06-04  1:48 ` thomas.preudhomme at arm dot com
2014-06-04  8:10 ` ro at CeBiTec dot Uni-Bielefeld.DE [this message]
2014-06-04  8:14 ` ebotcazou at gcc dot gnu.org
2014-06-04  8:16 ` thomas.preudhomme at arm dot com
2014-06-04  8:52 ` thomas.preudhomme at arm dot com
2014-06-04  8:56 ` thomas.preudhomme at arm dot com
2014-06-04  8:59 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-06-04  9:01 ` thomas.preudhomme at arm dot com
2014-06-04  9:43 ` rguenth at gcc dot gnu.org
2014-06-05 10:50 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-06-05 10:55 ` thomas.preudhomme at arm dot com
2014-06-06  9:03 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-06-06  9:25 ` thomas.preudhomme at arm dot com
2014-06-06 10:51 ` thomas.preudhomme at arm dot com
2014-06-12  2:49 ` thopre01 at gcc dot gnu.org
2014-06-12 10:32 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-06-12 13:11 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-06-13  5:40 ` thopre01 at gcc dot gnu.org
2014-06-13  5:45 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-06-18 10:50 ` thopre01 at gcc dot gnu.org
2014-06-18 10:55 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-06-24 17:04 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-06-25  3:37 ` thopre01 at gcc dot gnu.org
2014-06-25 13:20 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-06-30  3:20 ` thopre01 at gcc dot gnu.org
2014-06-30  7:17 ` thopre01 at gcc dot gnu.org
2014-07-17 11:49 ` ro at gcc dot gnu.org
2014-07-17 12:02 ` rguenth at gcc dot gnu.org
2014-07-17 12:30 ` thopre01 at gcc dot gnu.org
2014-07-17 12:35 ` rguenth at gcc dot gnu.org
2014-07-17 15:50 ` ebotcazou at gcc dot gnu.org
2014-07-17 16:13 ` thopre01 at gcc dot gnu.org
2014-07-17 19:20 ` rguenther at suse dot de
2014-07-23  9:59 ` rguenth at gcc dot gnu.org
2014-07-24 12:58 ` rguenth at gcc dot gnu.org
2014-07-24 14:39 ` ro at gcc dot gnu.org
2014-07-24 14:41 ` ro at gcc dot gnu.org
2014-07-25 10:11 ` rguenth at gcc dot gnu.org
2014-07-25 13:16 ` ebotcazou at gcc dot gnu.org
2014-07-29  8:11 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-08-06  6:15 ` tony.wang at arm dot com
2014-08-06 11:25 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-08-06 11:41 ` rguenth at gcc dot gnu.org
2014-08-06 11:42 ` rguenth at gcc dot gnu.org
2014-08-06 11:43 ` rguenth at gcc dot gnu.org
2014-09-03 12:27 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-61320-4-5AHAAagwFF@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).