[Bug c/61378] New: Obvious bug in vn_reference_lookup_3

[Bug c/61378] New: Obvious bug in vn_reference_lookup_3

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61378

            Bug ID: 61378
           Summary: Obvious bug in vn_reference_lookup_3
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com

Valgrind says

==15936== Conditional jump or move depends on uninitialised value(s)
==15936==    at 0xBE5839: vn_reference_lookup_3(ao_ref*, tree_node*, void*,
bool) (tree-ssa-sccvn.c:1627)

Source code is

      bool valueized_anything;
      for (unsigned i = 0; i < gimple_call_num_args (def_stmt); ++i)
    {
      oldargs[i] = gimple_call_arg (def_stmt, i);
      if (TREE_CODE (oldargs[i]) == SSA_NAME
          && VN_INFO (oldargs[i])->valnum != oldargs[i])
        {
          gimple_call_set_arg (def_stmt, i, VN_INFO (oldargs[i])->valnum);
          valueized_anything = true;
        }
    }
      if (valueized_anything)

Suggest init valueized_anything at its declaration.
Use of svn blame shows

210160    rguenth       if (valueized_anything)

[Bug middle-end/61378] Obvious bug in vn_reference_lookup_3

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61378

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-06-01
                 CC|                            |manu at gcc dot gnu.org
          Component|c                           |middle-end
     Ever confirmed|0                           |1

--- Comment #1 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
Sadly, Wuninitialized cannot catch this because of PR18501.
>From gcc-bugs-return-452933-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Jun 01 18:31:43 2014
Return-Path: <gcc-bugs-return-452933-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 19701 invoked by alias); 1 Jun 2014 18:31:43 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 19622 invoked by uid 48); 1 Jun 2014 18:31:40 -0000
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/61276] warn about possible coding errors with logical not (!)
Date: Sun, 01 Jun 2014 18:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-61276-4-Y3aowfTBKl@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61276-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61276-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg00015.txt.bz2
Content-length: 519

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida276

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I filed this bug a few years ago.

*** This bug has been marked as a duplicate of bug 49706 ***

[Bug middle-end/61378] Obvious bug in vn_reference_lookup_3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61378

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Oops, fixed.