[Bug libstdc++/61390] New: error in nested template parameter in ext/pb_ds header file

[Bug libstdc++/61390] New: error in nested template parameter in ext/pb_ds header file

[john.tromp at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61390

            Bug ID: 61390
           Summary: error in nested template parameter in ext/pb_ds header
                    file
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: john.tromp at gmail dot com

Include file ext/pb_ds/detail/bin_search_tree_/traits.hpp has two occurances
(lines 53 and 160 in 4.8.1) of
template<typename Key,
         ...
         class Cmp_Fn,
         template<typename Node_CItr,
                  class Node_Itr,
                  class Cmp_Fn,
                  typename _Alloc>
         class Node_Update,
         class Node,
         typename _Alloc>
...

on which some compilers in c++11 mode (e.g. clang++ -std=c++11) rightfully
raise an error since the second declaration of 'Cmp_Fn' shadows the first.

This is trivially avoided by renaming the second as _Cmp_Fn

[Bug libstdc++/61390] error in nested template parameter in ext/pb_ds header file

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61390

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-06-02
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Yes, I noticed this a few weeks ago.

[Bug libstdc++/61390] error in nested template parameter in ext/pb_ds header file

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61390

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Tue Jun 10 18:09:18 2014
New Revision: 211421

URL: http://gcc.gnu.org/viewcvs?rev=211421&root=gcc&view=rev
Log:
    PR libstdc++/61390
    * include/ext/pb_ds/detail/bin_search_tree_/traits.hpp
    (bin_search_tree_traits): Do not redeclare template-parameters.
    * testsuite/util/testsuite_iterators.h (test_container): Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/ext/pb_ds/detail/bin_search_tree_/traits.hpp
    trunk/libstdc++-v3/testsuite/util/testsuite_iterators.h

[Bug libstdc++/61390] error in nested template parameter in ext/pb_ds header file

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61390

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Aug  4 18:50:25 2014
New Revision: 213603

URL: https://gcc.gnu.org/viewcvs?rev=213603&root=gcc&view=rev
Log:
Backported from mainline
2014-06-10  Jonathan Wakely  <jwakely@redhat.com>

    PR libstdc++/61390
    * include/ext/pb_ds/detail/bin_search_tree_/traits.hpp
    (bin_search_tree_traits): Do not redeclare template-parameters.
    * testsuite/util/testsuite_iterators.h (test_container): Likewise.

Modified:
    branches/gcc-4_9-branch/libstdc++-v3/ChangeLog
   
branches/gcc-4_9-branch/libstdc++-v3/include/ext/pb_ds/detail/bin_search_tree_/traits.hpp
    branches/gcc-4_9-branch/libstdc++-v3/testsuite/util/testsuite_iterators.h

[Bug libstdc++/61390] error in nested template parameter in ext/pb_ds header file

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61390

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.2

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
fixed for 4.9.2