public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mikestump at comcast dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61396] [4.10 regression] ICE in simplify_immed_subreg
Date: Wed, 23 Jul 2014 22:01:00 -0000	[thread overview]
Message-ID: <bug-61396-4-182HSp3QIz@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-61396-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61396

--- Comment #7 from Mike Stump <mikestump at comcast dot net> ---
So when you compose the svn comments, compose them from a cut and paste of sed
20q ChangeLog, exactly.  In this case, you did this:

rs6000: fix for PR61396 (wide-int fallout)

CONSTANT_P is true for more than just all kinds of constant number.
This patch undoes that part of the wide-int patches.

but the ChangeLog was like this:

    PR target/61396
    * config/rs6000/rs6000.c (paired_expand_vector_init): Only allow
    constant numbers, not general constants.
    (rs6000_expand_vector_init): Ditto.

You used to do this, but stopped.  The problem with how you are doing it is
that the svn bugzilla integration actually looks for the PR target/ line and
links the change in svn into bugzilla.  Without that, no link.   Thanks.


      parent reply	other threads:[~2014-07-23 22:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02 21:35 [Bug middle-end/61396] New: " schwab@linux-m68k.org
2014-06-02 21:35 ` [Bug middle-end/61396] " schwab@linux-m68k.org
2014-06-23 20:39 ` iains at gcc dot gnu.org
2014-06-24 12:23 ` iains at gcc dot gnu.org
2014-07-22  4:38 ` [Bug target/61396] " segher at gcc dot gnu.org
2014-07-23 13:46 ` segher at gcc dot gnu.org
2014-07-23 22:01 ` mikestump at comcast dot net [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-61396-4-182HSp3QIz@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).