public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "meissner at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61397] [4.9/5 regression] FAIL: gcc.target/powerpc/p8vector-ldst.c scan-assembler lxsdx
Date: Tue, 24 Feb 2015 20:45:00 -0000	[thread overview]
Message-ID: <bug-61397-4-smGELj7qAp@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-61397-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61397

--- Comment #8 from Michael Meissner <meissner at gcc dot gnu.org> ---
I added the lp64 test when I added the -mupper-regs support and rewrote the
test.

The rationale is I was using a long bit vector to make sure that each floating
point variable got used (in_mask and out_mask each have a bit set for the 40
floating point values, to make sure that each value gets set in ways that the
optimizer can't rearrange things and use less live variables).

If we use long long in doing the masking in 32-bit, we run the risk that you
have to call a function to do long long shifting, and/or, and testing.  So, I
added the && lp64 conditional to the test.

The original version of p8vector-ldst.c no longer works with the -mupper-regs
support, as the compiler will happily move variables into the appropriate
register class without keeping the register there normally.  So, I wrote the
test to have 40 live FP values.

If people feel strongly enough that it needs to work on big endian 32-bit
(little endian powerpc64 no longer supports 32-bit mode), we can rewrite the
test to have 2 separate in_masks and out_masks.

Note as of this writing, the 4.9 branch has the original version of the
p8vector-ldst.c (and no restriction on 32-bit), since the -mupper-regs patches
are not back ported to GCC 4.9.  If the back port of the patches for upper regs
for 4.9 that I have in a branch are applied to the official FSF 4.9 branch,
then the new version of p8vector-ldst.c will be installed.


  parent reply	other threads:[~2015-02-24 19:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02 22:02 [Bug target/61397] New: [4.10 " schwab@linux-m68k.org
2014-09-26 21:37 ` [Bug target/61397] [5 " macro@linux-mips.org
2014-11-19 13:45 ` [Bug target/61397] [4.9/5 " rguenth at gcc dot gnu.org
2015-02-13 17:16 ` schwab@linux-m68k.org
2015-02-13 17:30 ` meissner at gcc dot gnu.org
2015-02-24 10:45 ` jakub at gcc dot gnu.org
2015-02-24 19:27 ` schwab@linux-m68k.org
2015-02-24 19:58 ` msebor at gcc dot gnu.org
2015-02-24 20:45 ` meissner at gcc dot gnu.org [this message]
2015-02-24 22:02 ` law at redhat dot com
2015-02-24 22:09 ` meissner at gcc dot gnu.org
2015-02-24 22:26 ` law at redhat dot com
2015-02-25  6:48 ` meissner at gcc dot gnu.org
2015-04-22 11:58 ` [Bug target/61397] [4.9/5/6 " jakub at gcc dot gnu.org
2015-07-16  9:17 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-61397-4-smGELj7qAp@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).