[Bug c/61423] New: Incorrect conversion from unsigned int to floating point

[Bug c/61423] New: Incorrect conversion from unsigned int to floating point

[lvqcl.mail at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

            Bug ID: 61423
           Summary: Incorrect conversion from unsigned int to floating
                    point
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: lvqcl.mail at gmail dot com

The attached program works incorrectly when compiled for i686 with '-O3 -msse2'
or '-O1 -ftree-vectorize -msse2'.

GCC compiles the function

#define N 1024
static unsigned int A[N];
double func (void)
{
    unsigned int sum = 0;
    unsigned i;
    double t;

    for (i = 0; i < N; i++) sum += A[i];

    t = sum; /* uint32 -> double */
    return t;
}

into the following:

01:    pxor    %xmm0, %xmm0
02:    movl    $_A, %eax
03: L2:
04:    paddd    (%eax), %xmm0
05:    addl    $16, %eax
06:    cmpl    $_A+4096, %eax
07:    jne    L2
08:    movdqa    %xmm0, %xmm1
09:    subl    $28, %esp
10:    psrldq    $8, %xmm1
11:    paddd    %xmm1, %xmm0
12:    movdqa    %xmm0, %xmm1
13:    psrldq    $4, %xmm1
14:    paddd    %xmm1, %xmm0
15:    movq    %xmm0, 8(%esp)
16:    fildq    8(%esp)
17:    addl    $28, %esp
18:    ret

After the line 07: xmm0 contains four partial sums.
After the line 14: lower 4 bytes of xmm0 contain the total sum, the rest 12
bytes contain garbage.
Lines 15 and 16: *eight* bytes from xmm0 are stored in memory and then loaded
into an FPU register.

According to the message from Robert Kausch (
http://lists.xiph.org/pipermail/flac-dev/2014-June/004723.html ) this bug
exists since GCC 4.4.

[Bug c/61423] Incorrect conversion from unsigned int to floating point

[lvqcl.mail at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

--- Comment #1 from lvqcl.mail at gmail dot com ---
Created attachment 32897
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=32897&action=edit
test program

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
             Target|                            |i?86-*-*
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-06-06
          Component|c                           |target
     Ever confirmed|0                           |1

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.  Works with -mfpmath=sse.  Initial RTL looks ok to me:

(insn 21 20 22 (set (reg:SI 99 [ stmp_sum_5.8 ])
        (vec_select:SI (reg:V4SI 98 [ vect_sum_5.9 ])
            (parallel [
                    (const_int 0 [0])
                ]))) -1
     (nil))

(insn 22 21 23 (parallel [
            (set (reg:DF 97 [ t ])
                (unsigned_float:DF (reg:SI 99 [ stmp_sum_5.8 ])))
            (clobber (mem/c:DI (plus:SI (reg/f:SI 78 virtual-stack-vars)
                        (const_int -8 [0xfffffffffffffff8])) [0  S8 A64]))
            (clobber (scratch:SI))
        ]) t.c:18 -1
     (nil))

(insn 23 22 24 (set (reg:DF 94 [ <retval> ])
        (reg:DF 97 [ t ])) t.c:19 -1
     (nil))

So it must be a bogus *floatunssidf2_1 pattern

(insn 22 21 28 4 (parallel [
            (set (reg:DF 8 st [orig:97 t ] [97])
                (unsigned_float:DF (reg:SI 21 xmm0 [orig:99 stmp_sum_5.8 ]
[99])))
            (clobber (mem/c:DI (plus:SI (reg/f:SI 7 sp)
                        (const_int 8 [0x8])) [0  S8 A64]))
            (clobber (scratch:SI))
        ]) t.c:18 211 {*floatunssidf2_1}
     (nil))

split to

(insn 39 38 40 4 (set (mem/c:DI (plus:SI (reg/f:SI 7 sp)
                (const_int 8 [0x8])) [0  S8 A64])
        (reg:DI 21 xmm0 [orig:99 stmp_sum_5.8 ] [99])) t.c:18 89
{*movdi_internal}   
     (nil))
(insn 40 39 28 4 (set (reg:DF 8 st [orig:97 t ] [97])
        (float:DF (mem/c:DI (plus:SI (reg/f:SI 7 sp)
                    (const_int 8 [0x8])) [0  S8 A64]))) t.c:18 206
{*floatdidf2_i387}
     (nil))

note the use of a DImode memory but the missing zero-extend of xmm0:DI.

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |ubizjak at gmail dot com

--- Comment #3 from Uroš Bizjak <ubizjak at gmail dot com> ---
Looking into it.
>From gcc-bugs-return-453380-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jun 06 10:31:30 2014
Return-Path: <gcc-bugs-return-453380-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16297 invoked by alias); 6 Jun 2014 10:31:30 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 16248 invoked by uid 55); 6 Jun 2014 10:31:25 -0000
From: "ro at CeBiTec dot Uni-Bielefeld.DE" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/61320] [4.10 regression] ICE in jcf-parse.c:1622 (parse_class_file
Date: Fri, 06 Jun 2014 10:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ro at CeBiTec dot Uni-Bielefeld.DE
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61320-4-bePaDHGIcE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61320-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61320-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg00462.txt.bz2
Content-length: 893

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida320

--- Comment #33 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #32 from Thomas Preud'homme <thomas.preudhomme at arm dot com> ---
[...]
> Are you sure the patch was applied to this test? Line 78 I have "bfin.inval > (struct ok) { 0x83, 0x85, 0x87, 0x89 };"
>
> The next abort about this line is under a "if (out == 0x89878583)" so would not
> abort either. By the way, no need to do a bootstrap again or run the whole
> testsuite to try this patch, only this test was changed.

Sorry, I've been dreaming: I'd only applied

    https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00294.html
and
        https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00295.html

With the correct patch for bswap-2.c, the test passes for
sparc-sun-solaris2.11 (both 32 and 64-bit).

Sorry for the noise.

    Rainer

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

--- Comment #4 from Uroš Bizjak <ubizjak at gmail dot com> ---
Created attachment 32901
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=32901&action=edit
Proposed patch

This patch fies invalid code gen, but unfortunately uncovers a problem in REE
pass and fails bootstrap when configured "--with-arch=core-avx-i
--with-cpu=core-avx-i".
>From gcc-bugs-return-453395-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jun 06 15:32:26 2014
Return-Path: <gcc-bugs-return-453395-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6193 invoked by alias); 6 Jun 2014 15:32:26 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6159 invoked by uid 55); 6 Jun 2014 15:32:21 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/59299] We do not sink loads
Date: Fri, 06 Jun 2014 15:32:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-59299-4-v0mB0rathR@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-59299-4@http.gcc.gnu.org/bugzilla/>
References: <bug-59299-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg00477.txt.bz2
Content-length: 743

https://gcc.gnu.org/bugzilla/show_bug.cgi?idY299

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Fri Jun  6 15:31:47 2014
New Revision: 211317

URL: http://gcc.gnu.org/viewcvs?rev!1317&root=gcc&view=rev
Log:
2014-06-06  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/59299
    * tree-ssa-sink.c (all_immediate_uses_same_place): Work on
    a def operand.
    (nearest_common_dominator_of_uses): Likewise.
    (statement_sink_location): Adjust.  Support sinking loads.

    * gcc.dg/tree-ssa/ssa-sink-10.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-sink-10.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-sink.c

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

--- Comment #5 from Uroš Bizjak <ubizjak at gmail dot com> ---
Created attachment 32903
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=32903&action=edit
Testcase that fails in REE pass

This testcase fails with patched gcc in REE pass:

cc1 -O2 -m32 -march=corei7 libgcc2.i

/home/uros/gcc-svn/trunk/libgcc/libgcc2.c: In function ‘__fixunssfdi’:
/home/uros/gcc-svn/trunk/libgcc/libgcc2.c:1492:1: error: insn does not satisfy
its constraints:
 }
 ^
(insn 54 11 47 2 (set (reg:DI 0 ax)
        (reg:DI 21 xmm0)) /home/uros/gcc-svn/trunk/libgcc/libgcc2.c:1444 89
{*movdi_internal}
     (expr_list:REG_UNUSED (reg:DI 0 ax)
        (nil)))
/home/uros/gcc-svn/trunk/libgcc/libgcc2.c:1492:1: internal compiler error: in
copyprop_hardreg_forward_1, at regcprop.c:776
...

_split2 pass produces correct sequence:

(insn 46 11 47 2 (set (reg:DI 21 xmm0 [118])
        (zero_extend:DI (reg/v:SI 0 ax [orig:85 hi ] [85])))
/home/uros/gcc-svn/trunk/libgcc/libgcc2.c:1452 133 {*zero_extendsidi2}
     (nil))
(insn 47 46 48 2 (set (mem/c:DI (reg/f:SI 7 sp) [0  S8 A64])
        (reg:DI 21 xmm0 [118])) /home/uros/gcc-svn/trunk/libgcc/libgcc2.c:1452
89 {*movdi_internal}
     (nil))
(insn 48 47 13 2 (set (reg:DF 9 st(1) [orig:101 D.6895 ] [101])
        (float:DF (mem/c:DI (reg/f:SI 7 sp) [0  S8 A64])))
/home/uros/gcc-svn/trunk/libgcc/libgcc2.c:1452 206 {*floatdidf2_i387}
     (nil))

and _ree pass converts this to:

(insn 11 45 54 2 (set (reg:DI 21 xmm0)
        (zero_extend:DI (reg:SI 2 cx [99])))
/home/uros/gcc-svn/trunk/libgcc/libgcc2.c:1444 133 {*zero_extendsidi2}
     (nil))
(insn 54 11 47 2 (set (reg:DI 0 ax)
        (reg:DI 21 xmm0)) /home/uros/gcc-svn/trunk/libgcc/libgcc2.c:1444 -1
     (nil))
(insn 47 54 48 2 (set (mem/c:DI (reg/f:SI 7 sp) [0  S8 A64])
        (reg:DI 21 xmm0 [118])) /home/uros/gcc-svn/trunk/libgcc/libgcc2.c:1452
89 {*movdi_internal}
     (nil))
(insn 48 47 13 2 (set (reg:DF 9 st(1) [orig:101 D.6895 ] [101])
        (float:DF (mem/c:DI (reg/f:SI 7 sp) [0  S8 A64])))
/home/uros/gcc-svn/trunk/libgcc/libgcc2.c:1452 206 {*floatdidf2_i387}
     (nil))


Please note ivalid (insn 54).
>From gcc-bugs-return-453401-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jun 06 15:39:36 2014
Return-Path: <gcc-bugs-return-453401-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 15784 invoked by alias); 6 Jun 2014 15:39:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 15744 invoked by uid 48); 6 Jun 2014 15:39:32 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/61428] "maybe-uninitialized" is broken in all current versions (4.7-4.10)
Date: Fri, 06 Jun 2014 15:39:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: keywords bug_status cf_reconfirmed_on component everconfirmed
Message-ID: <bug-61428-4-OqggWLzaJx@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61428-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61428-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg00483.txt.bz2
Content-length: 603

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida428

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-06-06
          Component|c                           |middle-end
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at gcc dot gnu.org

--- Comment #6 from Uroš Bizjak <ubizjak at gmail dot com> ---
Jeff, can you please look at what goes wrong in REE pass?
>From gcc-bugs-return-453404-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jun 06 15:51:55 2014
Return-Path: <gcc-bugs-return-453404-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 2096 invoked by alias); 6 Jun 2014 15:51:55 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 2024 invoked by uid 48); 6 Jun 2014 15:51:51 -0000
From: "meissner at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61431] Powerpc tests pack01.c and p8vector-int128-2.c fail on little endian power8 systems
Date: Fri, 06 Jun 2014 15:51:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: meissner at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: meissner at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on everconfirmed
Message-ID: <bug-61431-4-0Ua2zVW8fX@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61431-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61431-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg00486.txt.bz2
Content-length: 411

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida431

Michael Meissner <meissner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-06-06
     Ever confirmed|0                           |1

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

--- Comment #7 from uros at gcc dot gnu.org ---
Author: uros
Date: Fri Jun  6 17:45:10 2014
New Revision: 211321

URL: http://gcc.gnu.org/viewcvs?rev=211321&root=gcc&view=rev
Log:
    PR target/61423
    * config/i386/i386.md (*floatunssi<mode>2_i387_with_xmm): New
    define_insn_and_split pattern, merged from *floatunssi<mode>2_1
    and corresponding splitters.  Zero extend general register
    or memory input operand to XMM temporary.  Enable for
    TARGET_SSE2 and TARGET_INTER_UNIT_MOVES_TO_VEC only.
    (floatunssi<mode>2): Update expander predicate.

testsuite/ChangeLog:

    PR target/61423
    * gcc.target/i386/pr61423.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/i386/pr61423.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.md
    trunk/gcc/testsuite/ChangeLog

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Shouldn't this patch be reverted until REE is fixed?

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |law at redhat dot com

--- Comment #10 from Jeffrey A. Law <law at redhat dot com> ---
Either way will cause a failure.  This is #1 on my hit list after the regex
problem that's affecting mysql.

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

--- Comment #11 from Jeffrey A. Law <law at redhat dot com> ---
I expect the REE bug to be fixed tomorrow AM (my time).  It's a trivial issue.

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[law at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423
Bug 61423 depends on bug 61446, which changed state.

Bug 61446 Summary: [4.10 Regression]: ICE in copyprop_hardreg_forward_1, at regcprop.c with -O2 -m32 -march=corei7
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61446

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

--- Comment #12 from uros at gcc dot gnu.org ---
Author: uros
Date: Tue Jun 17 05:00:52 2014
New Revision: 211723

URL: https://gcc.gnu.org/viewcvs?rev=211723&root=gcc&view=rev
Log:
    Backport from mainline
    2014-06-06  Uros Bizjak  <ubizjak@gmail.com>

    PR target/61423
    * config/i386/i386.md (*floatunssi<mode>2_i387_with_xmm): New
    define_insn_and_split pattern, merged from *floatunssi<mode>2_1
    and corresponding splitters.  Zero extend general register
    or memory input operand to XMM temporary.  Enable for
    TARGET_SSE2 and TARGET_INTER_UNIT_MOVES_TO_VEC only.
    (floatunssi<mode>2): Update expander predicate.

testsuite/ChangeLog:

    Backport from mainline
    2014-06-06  Uros Bizjak  <ubizjak@gmail.com>

    PR target/61423
    * gcc.target/i386/pr61423.c: New test.


Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.target/i386/pr61423.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/config/i386/i386.md
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[uros at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

--- Comment #13 from uros at gcc dot gnu.org ---
Author: uros
Date: Wed Jun 18 20:01:37 2014
New Revision: 211803

URL: https://gcc.gnu.org/viewcvs?rev=211803&root=gcc&view=rev
Log:
    Backport from mainline
    2014-06-06  Uros Bizjak  <ubizjak@gmail.com>

    PR target/61423
    * config/i386/i386.md (*floatunssi<mode>2_i387_with_xmm): New
    define_insn_and_split pattern, merged from *floatunssi<mode>2_1
    and corresponding splitters.  Zero extend general register
    or memory input operand to XMM temporary.  Enable for
    TARGET_SSE2 and TARGET_INTER_UNIT_MOVES_TO_VEC only.
    (floatunssi<mode>2): Update expander predicate.

testsuite/ChangeLog:

    Backport from mainline
    2014-06-13  Ilya Enkovich  <ilya.enkovich@intel.com>

    PR rtl-optimization/61094
    PR rtl-optimization/61446
    * gcc.target/i386/pr61446.c : New.

    Backport from mainline
    2014-06-06  Uros Bizjak  <ubizjak@gmail.com>

    PR target/61423
    * gcc.target/i386/pr61423.c: New test.


Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.target/i386/pr61423.c
    branches/gcc-4_8-branch/gcc/testsuite/gcc.target/i386/pr61446.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/config/i386/i386.md
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog

[Bug target/61423] Incorrect conversion from unsigned int to floating point

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61423

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.8.4

--- Comment #14 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed in all release branches.
>From gcc-bugs-return-454513-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jun 18 20:15:06 2014
Return-Path: <gcc-bugs-return-454513-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3074 invoked by alias); 18 Jun 2014 20:15:05 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 2314 invoked by uid 48); 18 Jun 2014 20:14:58 -0000
From: "trippels at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/61555] New: [4.9/4.10 Regression] LLVM build failure
Date: Wed, 18 Jun 2014 20:15:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: trippels at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-61555-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg01595.txt.bz2
Content-length: 3889

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida555

            Bug ID: 61555
           Summary: [4.9/4.10 Regression] LLVM build failure
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: trippels at gcc dot gnu.org

LLVM trunk fails to build with 4.9 and 4.10:

[1299/1853] Linking CXX executable bin/bugpoint
FAILED: : && /usr/bin/g++   -fPIC -fvisibility-inlines-hidden -Wall -W
-Wno-unused-parameter -Wwrite-strings -Wno-missing-field-initializers -pedantic
-Wno-long-long -Wno-maybe-uninitialized -Wnon-virtual-dtor -Wno-comment
-std=c++11 -ffunction-sections -fdata-sections -O2  -DNDEBUG -pipe
-march=native
-Wl,-O1,--hash-style=gnu,--gc-sections,--icf=all,--icf-iterations=3
-Wl,--export-dynamic tools/bugpoint/CMakeFiles/bugpoint.dir/BugDriver.cpp.o
tools/bugpoint/CMakeFiles/bugpoint.dir/CrashDebugger.cpp.o
tools/bugpoint/CMakeFiles/bugpoint.dir/ExecutionDriver.cpp.o
tools/bugpoint/CMakeFiles/bugpoint.dir/ExtractFunction.cpp.o
tools/bugpoint/CMakeFiles/bugpoint.dir/FindBugs.cpp.o
tools/bugpoint/CMakeFiles/bugpoint.dir/Miscompilation.cpp.o
tools/bugpoint/CMakeFiles/bugpoint.dir/OptimizerDriver.cpp.o
tools/bugpoint/CMakeFiles/bugpoint.dir/ToolRunner.cpp.o
tools/bugpoint/CMakeFiles/bugpoint.dir/bugpoint.cpp.o  -o bin/bugpoint
lib/libLLVMAnalysis.so lib/libLLVMBitWriter.so lib/libLLVMCodeGen.so
lib/libLLVMCore.so lib/libLLVMipa.so lib/libLLVMipo.so lib/libLLVMIRReader.so
lib/libLLVMInstCombine.so lib/libLLVMInstrumentation.so lib/libLLVMLinker.so
lib/libLLVMObjCARCOpts.so lib/libLLVMScalarOpts.so lib/libLLVMSupport.so
lib/libLLVMTarget.so lib/libLLVMTransformUtils.so lib/libLLVMVectorize.so
lib/libLLVMInstCombine.so lib/libLLVMAsmParser.so lib/libLLVMTransformUtils.so
lib/libLLVMipa.so lib/libLLVMAnalysis.so lib/libLLVMTarget.so lib/libLLVMMC.so
lib/libLLVMObject.so lib/libLLVMBitReader.so lib/libLLVMCore.so
lib/libLLVMSupport.so -lrt -ldl -lcurses -lpthread -lz
-Wl,-rpath,"\$ORIGIN/../lib" && :
tools/bugpoint/CMakeFiles/bugpoint.dir/bugpoint.cpp.o:bugpoint.cpp:function
llvm::cl::list<llvm::PassInfo const*, bool,
llvm::PassNameParser>::getExtraOptionNames(llvm::SmallVectorImpl<char
const*>&): error: undefined reference to 'llvm::cl::parser<llvm::PassInfo
const*>::getOption(unsigned int) const'
collect2: error: ld returned 1 exit status
[1299/1853] Building CXX object
tools/clang/lib/Basic/CMakeFiles/clangBasic.dir/Targets.cpp.o
ninja: build stopped: subcommand failed.

Reduced:

markus@x4 llvm_build % cat bugpoint.ii
namespace llvm
{
namespace cl
{
enum NumOccurrencesFlag
{
  ZeroOrMore
};
enum OptionHidden
{
  NotHidden
};
class A
{
protected:
  A (NumOccurrencesFlag, OptionHidden);
  virtual void getExtraOptionNames (int &);
};
class B
{
public:
  virtual char *getOption (unsigned) const;
  void getExtraOptionNames (int) { getOption (0); }
};
template <class> class parser : public B
{
  char *getOption (unsigned) const;
};
template <class ParserClass = parser<int> > class C : A
{
  ParserClass Parser;
  void getExtraOptionNames (int &p1) { Parser.getExtraOptionNames (0); }
public:
  template <class M0t, class M1t> C (M0t, M1t) : A (ZeroOrMore, NotHidden) {}
};
}
class PassInfo;
class D : public cl::parser<const PassInfo *>
{
public:
  D ();
};
}

using namespace llvm;
cl::C<D> a (0, cl::ZeroOrMore);

markus@x4 llvm_build % g++ -c -O2 -std=c++11 bugpoint.ii
markus@x4 llvm_build % nm bugpoint.o | grep
_ZNK4llvm2cl6parserIPKNS_8PassInfoEE9getOptionEj
                 U _ZNK4llvm2cl6parserIPKNS_8PassInfoEE9getOptionEj

(4.8.3 is fine)
markus@x4 llvm_build % /usr/x86_64-pc-linux-gnu/gcc-bin/4.8.3/g++ -c -O2
-std=c++11 bugpoint.ii
markus@x4 llvm_build % nm bugpoint.o | grep
_ZNK4llvm2cl6parserIPKNS_8PassInfoEE9getOptionEj
markus@x4 llvm_build %