public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug regression/61436] [4.10 Regression]: g++.dg/tls/diag-1.C ICE (emutls)
Date: Mon, 09 Jun 2014 09:02:00 -0000	[thread overview]
Message-ID: <bug-61436-4-MI9iwx1dnz@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-61436-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61436

--- Comment #2 from Jan Hubicka <hubicka at ucw dot cz> ---
Hi,
it seems that get_emutls_init_templ_addr just create the comdat too early
and we trigger sanity check that symbols are static and not automatic
variables.

I have busy day tomorrow, so won't beat if anyone beats me in testing if
this fix works.

Honza

Index: tree-emutls.c
===================================================================
--- tree-emutls.c    (revision 211363)
+++ tree-emutls.c    (working copy)
@@ -250,10 +250,10 @@ get_emutls_init_templ_addr (tree decl)
   DECL_WEAK (to) = DECL_WEAK (decl);
   if (DECL_ONE_ONLY (decl))
     {
-      make_decl_one_only (to, DECL_ASSEMBLER_NAME (to));
       TREE_STATIC (to) = TREE_STATIC (decl);
       TREE_PUBLIC (to) = TREE_PUBLIC (decl);
       DECL_VISIBILITY (to) = DECL_VISIBILITY (decl);
+      make_decl_one_only (to, DECL_ASSEMBLER_NAME (to));
     }
   else
     TREE_STATIC (to) = 1;


  parent reply	other threads:[~2014-06-09  9:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-07  1:35 [Bug regression/61436] New: " hp at gcc dot gnu.org
2014-06-07  2:06 ` [Bug regression/61436] " hp at gcc dot gnu.org
2014-06-07  2:07 ` hp at gcc dot gnu.org
2014-06-09  9:02 ` hubicka at ucw dot cz [this message]
2014-06-09 12:09 ` dominiq at lps dot ens.fr
2014-06-10 10:13 ` rguenth at gcc dot gnu.org
2014-06-23 18:28 ` hp at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-61436-4-MI9iwx1dnz@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).