[Bug sanitizer/61475] New: Building Firefox with ASan is broken in the packaging step

[Bug sanitizer/61475] New: Building Firefox with ASan is broken in the packaging step

[gk at torproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61475

            Bug ID: 61475
           Summary: Building Firefox with ASan is broken in the packaging
                    step
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gk at torproject dot org
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

As mentioned in bug 61408 building Firefox 24 (and probably later Firefox
versions as well) with ASan is broken on GCC trunk. The build crashes in the
packaging step as follows:

Executing
/home/gk/asan/mozilla-esr24/obj-x86_64-unknown-linux-gnu/dist/bin/xpcshell -g
/home/gk/asan/mozilla-esr24/obj-x86_64-unknown-linux-gnu/dist/bin/ -a
/home/gk/asan/mozilla-esr24/obj-x86_64-unknown-linux-gnu/dist/bin/ -f
/home/gk/asan/mozilla-esr24/toolkit/mozapps/installer/precompile_cache.js -e
precompile_startupcache("resource://gre/");
=================================================================
==22303==ERROR: AddressSanitizer: unknown-crash on address 0x2ad2d31bd3c0 at pc
0x2ad2d1803362 bp 0x7fff8f6149c0 sp 0x7fff8f6149b8
READ of size 16 at 0x2ad2d31bd3c0 thread T0
    #0 0x2ad2d1803361 in nsIDHashKey ../../dist/include/nsHashKeys.h:375
    #1 0x2ad2d1803361 in nsBaseHashtableET
../../dist/include/nsBaseHashtable.h:408
    #2 0x2ad2d1803361 in nsTHashtable<nsBaseHashtableET<nsIDHashKey,
nsFactoryEntry*> >::s_InitEntry(PLDHashTable*, PLDHashEntryHdr*, void const*)
../../dist/include/nsTHashtable.h:472
    #3 0x2ad2d179ad39 in PL_DHashTableOperate
/home/gk/asan/mozilla-esr24/obj-x86_64-unknown-linux-gnu/xpcom/build/pldhash.cpp:630
    #4 0x2ad2d1805d75 in nsTHashtable<nsBaseHashtableET<nsIDHashKey,
nsFactoryEntry*> >::PutEntry(nsID const&, mozilla::fallible_t const&)
../../dist/include/nsTHashtable.h:184
    #5 0x2ad2d1805d75 in nsTHashtable<nsBaseHashtableET<nsIDHashKey,
nsFactoryEntry*> >::PutEntry(nsID const&) ../../dist/include/nsTHashtable.h:170
    #6 0x2ad2d1805d75 in nsBaseHashtable<nsIDHashKey, nsFactoryEntry*,
nsFactoryEntry*>::Put(nsID const&, nsFactoryEntry* const&, mozilla::fallible_t
const&) ../../dist/include/nsBaseHashtable.h:147
    #7 0x2ad2d1805d75 in nsBaseHashtable<nsIDHashKey, nsFactoryEntry*,
nsFactoryEntry*>::Put(nsID const&, nsFactoryEntry* const&)
../../dist/include/nsBaseHashtable.h:141
    #8 0x2ad2d1806065 in
nsComponentManagerImpl::RegisterCIDEntryLocked(mozilla::Module::CIDEntry
const*, nsComponentManagerImpl::KnownModule*)
/home/gk/asan/mozilla-esr24/xpcom/components/nsComponentManager.cpp:502
    #9 0x2ad2d1809d35 in nsComponentManagerImpl::RegisterModule(mozilla::Module
const*, mozilla::FileLocation*)
/home/gk/asan/mozilla-esr24/xpcom/components/nsComponentManager.cpp:453
    #10 0x2ad2d180aba2 in nsComponentManagerImpl::Init()
/home/gk/asan/mozilla-esr24/xpcom/components/nsComponentManager.cpp:389
    #11 0x2ad2d17a1fb0 in NS_InitXPCOM2
/home/gk/asan/mozilla-esr24/xpcom/build/nsXPComInit.cpp:467
    #12 0x406d4b in main
/home/gk/asan/mozilla-esr24/js/xpconnect/shell/xpcshell.cpp:1566
    #13 0x2ad2d59b6c8c in __libc_start_main (/lib/libc.so.6+0x1ec8c)
    #14 0x407ea0
(/home/gk/asan/mozilla-esr24/obj-x86_64-unknown-linux-gnu/dist/bin/xpcshell+0x407ea0)

0x2ad2d31bd3c0 is located 0 bytes inside of global variable
'kComponentManagerCID' from
'/home/gk/asan/mozilla-esr24/xpcom/build/nsXPComInit.cpp' (0x2ad2d31bd3c0) of
size 16
SUMMARY: AddressSanitizer: unknown-crash ../../dist/include/nsHashKeys.h:375
nsIDHashKey
Shadow bytes around the buggy address:
  0x055ada62fa20: 00 00 f9 f9 f9 f9 f9 f9 00 00 f9 f9 f9 f9 f9 f9
  0x055ada62fa30: 00 00 f9 f9 f9 f9 f9 f9 00 00 f9 f9 f9 f9 f9 f9
  0x055ada62fa40: 00 00 f9 f9 f9 f9 f9 f9 00 00 f9 f9 f9 f9 f9 f9
  0x055ada62fa50: 00 00 f9 f9 f9 f9 f9 f9 00 00 f9 f9 f9 f9 f9 f9
  0x055ada62fa60: 00 00 f9 f9 f9 f9 f9 f9 00 00 f9 f9 f9 f9 f9 f9
=>0x055ada62fa70: 00 00 f9 f9 f9 f9 f9 f9[00]00 f9 f9 f9 f9 f9 f9
  0x055ada62fa80: 07 f9 f9 f9 f9 f9 f9 f9 00 00 00 00 04 f9 f9 f9
  0x055ada62fa90: f9 f9 f9 f9 00 02 f9 f9 f9 f9 f9 f9 00 00 00 00
  0x055ada62faa0: 05 f9 f9 f9 f9 f9 f9 f9 06 f9 f9 f9 f9 f9 f9 f9
  0x055ada62fab0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x055ada62fac0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  ASan internal:           fe
==22303==ABORTING

This happened on a machine running Ubuntu Precise.

After a lot of fiddling I got Firefox (+ASan) compiled and packaged with
LLVM/Clang trunk on the same Ubuntu Precise machine without problems.

[Bug sanitizer/61475] Building Firefox with ASan is broken in the packaging step

[kcc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61475

--- Comment #1 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
Please
  1. try building with -static-libasan 
  2. provide full reproduction steps

[Bug sanitizer/61475] Building Firefox with ASan is broken in the packaging step

[y.gribov at samsung dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61475

Yury Gribov <y.gribov at samsung dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |y.gribov at samsung dot com

--- Comment #2 from Yury Gribov <y.gribov at samsung dot com> ---
Perhaps dup of bug 61422?

[Bug sanitizer/61475] Building Firefox with ASan is broken in the packaging step

[gk at torproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61475

--- Comment #3 from Georg Koppen <gk at torproject dot org> ---
(In reply to Kostya Serebryany from comment #1)
> Please
>   1. try building with -static-libasan

I'll do that once I am done with investigating bug 61408.

>   2. provide full reproduction steps

1) Take an Ubuntu Precise.
2) Compile GCC (I used the trunk from June 4 as the current has an ICE when
compiling Firefox which I need to report as well). I compiled it with
--prefix=/path/to/my/dir --disable-multilib --enable-languages=c,c++.
3) Grab the latest Firefox ESR 24 source code
(https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/latest-esr/source/firefox-24.6.0esr.source.tar.bz2).
4) Extract it and change into mozilla-esr24.
5) Save the attached mozconfig as .mozconfig in mozille-esr24.
6) Adjust your path to point to your freshly compiled GCC and point
LD_LIBRARY_PATH to your GCC-dir/lib64 (assuming you are compiling on a 64bit
system).
7) Run |make -j4 -f client.mk build|.
8) After successful compilation package Firefox with |make -C obj* package
INNER_MAKE_PACKAGE=true|.
9) It crashes as mentioned in the description.

[Bug sanitizer/61475] Building Firefox with ASan is broken in the packaging step

[gk at torproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61475

--- Comment #4 from Georg Koppen <gk at torproject dot org> ---
Created attachment 32924
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=32924&action=edit
.mozconfig for building Firefox ESR 24 with ASan

[Bug sanitizer/61475] Building Firefox with ASan is broken in the packaging step

[gk at torproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61475

--- Comment #5 from Georg Koppen <gk at torproject dot org> ---
(In reply to Georg Koppen from comment #3)
> (In reply to Kostya Serebryany from comment #1)
> > Please
> >   1. try building with -static-libasan
> 
> I'll do that once I am done with investigating bug 61408.

That didn't help either. I am getting the same crash.

[Bug sanitizer/61475] Building Firefox with ASan is broken in the packaging step

[kcc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61475

--- Comment #6 from Kostya Serebryany <kcc at gcc dot gnu.org> ---
So, clang trunk works and gcc trunk fails, right? 
Could be a miscompile by GCC.
I'd suggest to find the guilty module somehow (e.g. build all modules w/ and
w/o asan and then mix them in different proportions until you have just 
one asan-ified module and FF still fails).

(I may not get to reproducing this myself any time soon, sorry)

[Bug sanitizer/61475] Building Firefox with ASan is broken in the packaging step

[y.gribov at samsung dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61475

--- Comment #7 from Yury Gribov <y.gribov at samsung dot com> ---
Have you tried patch proposed in bug 61422?

[Bug sanitizer/61475] Building Firefox with ASan is broken in the packaging step

[gk at torproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61475

--- Comment #8 from Georg Koppen <gk at torproject dot org> ---
(In reply to Yury Gribov from comment #7)
> Have you tried patch proposed in bug 61422?

No, as it is not applying cleanly anymore.