[Bug sanitizer/61530] New: [4.10 Regression] segfault with asan

[Bug sanitizer/61530] New: [4.10 Regression] segfault with asan

[Joost.VandeVondele at mat dot ethz.ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

            Bug ID: 61530
           Summary: [4.10 Regression] segfault with asan
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: Joost.VandeVondele at mat dot ethz.ch
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org

Current trunk started failing in the day between good: r211692 bad: r211720


> gfortran -c -fsanitize=address bug.f90 
bug.f90: In function ‘mainlb’:
bug.f90:3:0: internal compiler error: Segmentation fault
   SUBROUTINE mainlb(n, m, x, l, u, nbd, f, g, factr, pgtol, ws, wy, &
 ^
0xa5ba8f crash_signal
    ../../gcc/gcc/toplev.c:337
0xa6f206 contains_struct_check
    ../../gcc/gcc/tree.h:2835
0xa6f206 build_check_stmt
    ../../gcc/gcc/asan.c:1824
0xa74dbb instrument_mem_region_access
    ../../gcc/gcc/asan.c:1984
0xa759a1 instrument_builtin_call
    ../../gcc/gcc/asan.c:2105
0xa759a1 maybe_instrument_call
    ../../gcc/gcc/asan.c:2178
0xa759a1 transform_statements
    ../../gcc/gcc/asan.c:2245
0xa7663c asan_instrument
    ../../gcc/gcc/asan.c:2625
0xa7663c execute
    ../../gcc/gcc/asan.c:2700
Please submit a full bug report,

> cat bug.f90 
MODULE cp_lbfgs
CONTAINS
  SUBROUTINE mainlb(n, m, x, l, u, nbd, f, g, factr, pgtol, ws, wy, &
       csave, lsave, isave, dsave)
    CHARACTER(len=60)                        :: task
    IF (task == 'START') THEN
       IF (task(1:5) == 'NEW_X') GOTO 777
       IF (task(1:4) == 'STOP') THEN
          IF (task(7:9) == 'CPU') THEN
             CALL dcopy(n,t,1,x,1)
          ENDIF
       ENDIF
    ENDIF
222 CONTINUE
    IF (info /= 0 .OR. iback >= 20) THEN
       IF (col == 0) THEN
          IF (info == 0) THEN
          ENDIF
          task = 'ABNORMAL_TERMINATION_IN_LNSRCH'
          GOTO 222
       ENDIF
    ENDIF
777 CONTINUE
  END SUBROUTINE mainlb
END MODULE cp_lbfgs
>From gcc-bugs-return-454329-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Jun 17 06:40:25 2014
Return-Path: <gcc-bugs-return-454329-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 18052 invoked by alias); 17 Jun 2014 06:40:24 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 18002 invoked by uid 48); 17 Jun 2014 06:40:19 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/61330] [4.10 Regression] Thumb ICE for case 920507-1.c
Date: Tue, 17 Jun 2014 06:40:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cf_gcctarget cc
Message-ID: <bug-61330-4-1vCzLYpWyJ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61330-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61330-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg01411.txt.bz2
Content-length: 1738

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61330

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|aarch64*-*-*, arm*-*-*,     |aarch64*-*-*, arm*-*-*,
                   |powerpc*-*-*                |powerpc*-*-*, alpha*-*-*
                 CC|                            |ubizjak at gmail dot com

--- Comment #4 from Uroš Bizjak <ubizjak at gmail dot com> ---
Also happens on alpha-linux-gnu. The backtrace with -O2 -ffat-lto-objects,
obtained from x86_64-pc-linux-gnu crosscompiler is:

920507-1.c: In function ‘x’:
920507-1.c:5:16: error: invalid register name for ‘a’
  register int *a asm("unknown_register");  /* { dg-error "invalid register" }
*/
                ^
920507-1.c:3:1: internal compiler error: in symtab_get_node, at cgraph.h:1073
 x(void)
 ^
0xc6d5ab decl_section_name(tree_node const*)
        ../../gcc-svn/trunk/gcc/cgraph.h:1070
0xcd690b alpha_in_small_data_p
        ../../gcc-svn/trunk/gcc/config/alpha/alpha.c:683
0xcb8271 default_encode_section_info(tree_node*, rtx_def*, int)
        ../../gcc-svn/trunk/gcc/varasm.c:6573
0x90c349 rest_of_decl_compilation(tree_node*, int, int)
        ../../gcc-svn/trunk/gcc/passes.c:215
0x6139fa expand_one_hard_reg_var
        ../../gcc-svn/trunk/gcc/cfgexpand.c:1109
0x6139fa expand_one_var
        ../../gcc-svn/trunk/gcc/cfgexpand.c:1296
0x613cd9 expand_used_vars_for_block
        ../../gcc-svn/trunk/gcc/cfgexpand.c:1339
0x61f0ee expand_used_vars
        ../../gcc-svn/trunk/gcc/cfgexpand.c:1806
0x6200d3 execute
        ../../gcc-svn/trunk/gcc/cfgexpand.c:5671
>From gcc-bugs-return-454330-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Jun 17 06:44:13 2014
Return-Path: <gcc-bugs-return-454330-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23654 invoked by alias); 17 Jun 2014 06:44:13 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23594 invoked by uid 48); 17 Jun 2014 06:44:10 -0000
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/58945] Improve atomic_compare_and_swap*_doubleword pattern
Date: Tue, 17 Jun 2014 06:44:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: ubizjak at gmail dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: steven at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58945-4-AySK3nbvrR@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58945-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58945-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg01412.txt.bz2
Content-length: 164

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58945

--- Comment #2 from Uroš Bizjak <ubizjak at gmail dot com> ---
Steven, do you have any ETA for this fix?
>From gcc-bugs-return-454331-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Jun 17 06:45:47 2014
Return-Path: <gcc-bugs-return-454331-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 24768 invoked by alias); 17 Jun 2014 06:45:47 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 24732 invoked by uid 48); 17 Jun 2014 06:45:44 -0000
From: "tschwinge at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/61508] [4.10 regression] fold-const.c:14863:55: error: cannot convert 'const char*' to 'const_tree
Date: Tue, 17 Jun 2014 06:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tschwinge at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: tschwinge at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on cc assigned_to everconfirmed
Message-ID: <bug-61508-4-GccbLwNFRA@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61508-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61508-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg01413.txt.bz2
Content-length: 823

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida508

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-06-17
                 CC|                            |hubicka at gcc dot gnu.org,
                   |                            |tschwinge at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |tschwinge at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
<http://news.gmane.org/find-root.php?message_id=%3C87lhswhwdf.fsf%40kepler.schwinge.homeip.net%3E>.

[Bug sanitizer/61530] [4.10 Regression] segfault with asan

[y.gribov at samsung dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

Yury Gribov <y.gribov at samsung dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |y.gribov at samsung dot com

--- Comment #1 from Yury Gribov <y.gribov at samsung dot com> ---
Mine.

[Bug sanitizer/61530] [4.10 Regression] segfault with asan

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.10.0

[Bug sanitizer/61530] [4.10 Regression] segfault with asan

[y.gribov at samsung dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

--- Comment #3 from Yury Gribov <y.gribov at samsung dot com> ---
Bootstrapped and regtested successfully on x64. Let's wait for Jakub's
comments.

[Bug sanitizer/61530] [4.10 Regression] segfault with asan

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-06-17
     Ever confirmed|0                           |1

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
LGTM, just please use some other function name than error, error is a glibc
function and it is unnecessary to override it with something unrelated.
Also, patches should go to gcc-patches...

[Bug sanitizer/61530] [4.10 Regression] segfault with asan

[tetra2005 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

Yuri Gribov <tetra2005 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tetra2005 at gmail dot com

--- Comment #5 from Yuri Gribov <tetra2005 at gmail dot com> ---
Actually the fix may not handle unaligned addresses properly. I think we should
rather stick with start and end bytes for memory regions in builtins. What's
your opinion?

[Bug sanitizer/61530] [4.10 Regression] segfault with asan

[y.gribov at samsung dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

--- Comment #6 from Yury Gribov <y.gribov at samsung dot com> ---
Created attachment 32965
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=32965&action=edit
Alternative patch

Draft patch to illustrate the last proposal. Bootstrap pending.

[Bug sanitizer/61530] [4.10 Regression] segfault with asan

[chefmax at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

--- Comment #7 from Maxim Ostapenko <chefmax at gcc dot gnu.org> ---
Author: chefmax
Date: Fri Jun 20 10:26:55 2014
New Revision: 211846

URL: https://gcc.gnu.org/viewcvs?rev=211846&root=gcc&view=rev
Log:
2014-06-18  Yury Gribov  <y.gribov@samsung.com>

gcc/
    PR sanitizer/61530
    * asan.c (build_check_stmt): Add condition.

gcc/testsuite/
    * c-c++-common/asan/pr61530.c: New test.


Added:
    trunk/gcc/testsuite/c-c++-common/asan/pr61530.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/asan.c
    trunk/gcc/testsuite/ChangeLog

[Bug sanitizer/61530] [4.10 Regression] segfault with asan

[Joost.VandeVondele at mat dot ethz.ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Joost.VandeVondele at mat dot ethz
                   |                            |.ch

--- Comment #8 from Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> ---
This is fixed AFAICT, please reopen if not.

[Bug sanitizer/61530] [4.10 Regression] segfault with asan

[Joost.VandeVondele at mat dot ethz.ch]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Joost VandeVondele <Joost.VandeVondele at mat dot ethz.ch> ---
fixed, I meant.

[Bug sanitizer/61530] [4.10 Regression] segfault with asan

[ygribov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61530

--- Comment #10 from ygribov at gcc dot gnu.org ---
Author: ygribov
Date: Thu Oct 16 13:46:39 2014
New Revision: 216326

URL: https://gcc.gnu.org/viewcvs?rev=216326&root=gcc&view=rev
Log:
New asan-instrumentation-with-call-threshold
 parameter.

2014-10-16  Yury Gribov  <y.gribov@samsung.com>

    Backport from mainline
    2014-06-16  Yury Gribov  <y.gribov@samsung.com>

    * asan.c (check_func): New function.
    (maybe_create_ssa_name): Likewise.
    (build_check_stmt_with_calls): Likewise.
    (use_calls_p): Likewise.
    (report_error_func): Change interface.
    (build_check_stmt): Allow non-integer lengths; add support
    for new parameter.
    (asan_instrument): Likewise.
    (instrument_mem_region_access): Moved code to
    build_check_stmt.
    (instrument_derefs): Likewise.
    (instrument_strlen_call): Likewise.
    * cfgcleanup.c (old_insns_match_p): Add support for new
    functions.
    * doc/invoke.texi: Describe new parameter.
    * params.def: Define new parameter.
    * params.h: Likewise.
    * sanitizer.def: Describe new builtins.

    * c-c++-common/asan/instrument-with-calls-1.c: New test.
    * c-c++-common/asan/instrument-with-calls-2.c: Likewise.
    * c-c++-common/asan/no-redundant-instrumentation-1.c: Update
    test patterns.
    * c-c++-common/asan/no-redundant-instrumentation-2.c:
    Likewise.
    * c-c++-common/asan/no-redundant-instrumentation-4.c:
    Likewise.
    * c-c++-common/asan/no-redundant-instrumentation-5.c:
    Likewise.
    * c-c++-common/asan/no-redundant-instrumentation-6.c:
    Likewise.
    * c-c++-common/asan/no-redundant-instrumentation-7.c:
    Likewise.
    * c-c++-common/asan/no-redundant-instrumentation-8.c:
    Likewise.

    Backport from mainline
    2014-06-16  Yury Gribov  <y.gribov@samsung.com>

    * asan.c (build_check_stmt): Fix maybe-uninitialized warning.

    Backport from mainline
    2014-06-18  Yury Gribov  <y.gribov@samsung.com>

    PR sanitizer/61530

    * asan.c (build_check_stmt): Add condition.

    * c-c++-common/asan/pr61530.c: New test.

    Backport from mainline
    2014-06-18  Yury Gribov  <y.gribov@samsung.com>

    PR sanitizer/61547

    * asan.c (instrument_strlen_call): Fixed instrumentation of
    trailing byte.

    * c-c++-common/asan/strlen-overflow-1.c: New test.

Added:
   
branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/instrument-with-calls-1.c
   
branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/instrument-with-calls-2.c
    branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/pr61530.c
    branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/strlen-overflow-1.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/asan.c
    branches/gcc-4_9-branch/gcc/cfgcleanup.c
    branches/gcc-4_9-branch/gcc/doc/invoke.texi
    branches/gcc-4_9-branch/gcc/params.def
    branches/gcc-4_9-branch/gcc/params.h
    branches/gcc-4_9-branch/gcc/sanitizer.def
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
   
branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/no-redundant-instrumentation-1.c
   
branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/no-redundant-instrumentation-2.c
   
branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/no-redundant-instrumentation-4.c
   
branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/no-redundant-instrumentation-5.c
   
branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/no-redundant-instrumentation-6.c
   
branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/no-redundant-instrumentation-7.c
   
branches/gcc-4_9-branch/gcc/testsuite/c-c++-common/asan/no-redundant-instrumentation-8.c