[Bug regression/61548] New: FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[Bug regression/61548] New: FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

            Bug ID: 61548
           Summary: FAIL: gcc.dg/tls/alias-1.c (internal compiler error)
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: regression
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ktkachov at gcc dot gnu.org

On arm and aarch64 I see ICEs in the aforementioned test:

$TOP/gcc/testsuite/gcc.dg/tls/alias-1.c:24:3: internal compiler error:
Segmentation fault
0x9f71d5 crash_signal
        $TOP/gcc/toplev.c:337
0x6b1f7e symtab_alias_target
        $TOP/gcc/cgraph.h:1534
0x6b1f7e verify_symtab_base(symtab_node*)
        $TOP/gcc/symtab.c:830
0x6b21e9 verify_symtab_node(symtab_node*)
        $TOP/gcc/symtab.c:863
0x6b3684 verify_symtab()
        $TOP/gcc/symtab.c:881
0x8917d5 symtab_remove_unreachable_nodes(bool, _IO_FILE*)
        $TOP/gcc/ipa.c:592
0x6c0c74 ipa_passes
        $TOP/gcc/cgraphunit.c:2065
0x6c0c74 compile()
        $TOP/gcc/cgraphunit.c:2187
0x6c1909 finalize_compilation_unit()
        $TOP/gcc/cgraphunit.c:2342
0x56a5ac c_write_global_declarations()
        $TOP/gcc/c/c-decl.c:10452


I'm using an arm-none-eabi cross configured with --with-fpu=neon-fp-armv8
--with-arch=armv8-a at r211767.

Trying to go back to find a good revision is not easy because arm builds have
been broken by other things recently.

[Bug regression/61548] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[jgreenhalgh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

jgreenhalgh at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-06-23
     Ever confirmed|0                           |1

[Bug regression/61548] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[jgreenhalgh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

jgreenhalgh at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jgreenhalgh at gcc dot gnu.org

--- Comment #1 from jgreenhalgh at gcc dot gnu.org ---
Created attachment 32986
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=32986&action=edit
Reduced Testcase

Confirmed on aarch64, where this one-liner is enough to trigger the ICE.

[Bug regression/61548] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[jgreenhalgh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #2 from jgreenhalgh at gcc dot gnu.org ---
Actually, that test case gets you a different ICE:

reduced.c:1:17: internal compiler error: Segmentation fault
 __thread struct __res_state foo;
                 ^
0x9805ee crash_signal
    /work/gcc-clean/src/gcc/gcc/toplev.c:337
0x750483 contains_struct_check
    /work/gcc-clean/src/gcc/gcc/tree.h:2840
0x750483 fold_convert_loc(unsigned int, tree_node*, tree_node*)
    /work/gcc-clean/src/gcc/gcc/fold-const.c:1913
0x9dccd2 default_emutls_var_init(tree_node*, tree_node*, tree_node*)
    /work/gcc-clean/src/gcc/gcc/tree-emutls.c:170
0x9db1e0 new_emutls_decl
    /work/gcc-clean/src/gcc/gcc/tree-emutls.c:336
0x9db1e0 create_emultls_var
    /work/gcc-clean/src/gcc/gcc/tree-emutls.c:713
0xc427e8 varpool_for_node_and_aliases(varpool_node*, bool (*)(varpool_node*,
void*), void*, bool)
    /work/gcc-clean/src/gcc/gcc/varpool.c:697
0x9dc1cf ipa_lower_emutls
    /work/gcc-clean/src/gcc/gcc/tree-emutls.c:784
0x9dc1cf execute
    /work/gcc-clean/src/gcc/tree-emutls.c:845
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug regression/61548] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|arm-none-eabi,              |arm-none-eabi,
                   |aarch64-none-elf            |aarch64-none-elf, cris-elf
                 CC|                            |hp at gcc dot gnu.org

--- Comment #3 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Also on cris-elf, seen since r211694 (after a period of being broken; last
known to work at r211677).  Looks like we traded some emutls failures for
others.  Looking at the actual revisions, that does seem to be what happened;
not much else happened.  I see Honza is already CC:ed, good.

[Bug regression/61548] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |hubicka at gcc dot gnu.org

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Mine.

[Bug regression/61548] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[jgreenhalgh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

jgreenhalgh at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32986|0                           |1
        is obsolete|                            |

--- Comment #5 from jgreenhalgh at gcc dot gnu.org ---
Comment on attachment 32986
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=32986
Reduced Testcase

I'm marking the testcase I added as obsolete. I can reproduce an ICE with the
reduced testcase as far back as GCC 4.9, so I think it is a separate issue.
I'll raise a different bug.

[Bug regression/61548] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tony.wang at arm dot com

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 61883 has been marked as a duplicate of this bug. ***

[Bug regression/61548] [4.10 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.10.0
            Summary|FAIL: gcc.dg/tls/alias-1.c  |[4.10 Regression] FAIL:
                   |(internal compiler error)   |gcc.dg/tls/alias-1.c
                   |                            |(internal compiler error)

[Bug regression/61548] [4.10 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[tony.wang at arm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #7 from wangzheyu <tony.wang at arm dot com> ---
I have a simpler test case to reproduce this bug, it should be an old bug for
the tree-emutls pass. The way this pass mapping the control vars and tls vars
hasn't consider that there may more than one alias for a tls var. For target
supports tls, the code can compile successfully, but the target doesn't support
tls will fail.

struct __res_state {
 char x[123];
};

__thread struct __res_state foo;
extern __thread struct __res_state bar
  __attribute__ ((alias ("foo")));
extern __thread struct __res_state baz
  __attribute__ ((alias ("foo")));

int main()
{
  bar.x[0] = 0;
  baz.x[1] = 1;
  return 0;
}

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING
          Component|regression                  |ipa
      Known to fail|4.10.0                      |5.0

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Is this still broken?

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

--- Comment #9 from ktkachov at gcc dot gnu.org ---
Yes. I still get the ICE on aarch64-none-elf and arm-none-eabi as of r217750

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |ramana at gcc dot gnu.org

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING

--- Comment #10 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
I believe this is also fixed by the ipa-inline alias handling fix.

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |ASSIGNED

--- Comment #11 from ktkachov at gcc dot gnu.org ---
(In reply to Jan Hubicka from comment #10)
> I believe this is also fixed by the ipa-inline alias handling fix.

I still see the ICE on ARM at least as of r219714:

$TOP/gcc/gcc/testsuite/gcc.dg/tls/alias-1.c:24:3: internal compiler error:
Segmentation fault
0xa61df5 crash_signal
        $TOP/gcc/gcc/toplev.c:381
0x6a05d8 symtab_node::get_alias_target()
        $TOP/gcc/gcc/cgraph.h:2271
0x6a05d8 symtab_node::verify_base()
        $TOP/gcc/gcc/symtab.c:1130
0x6a0983 symtab_node::verify()
        $TOP/gcc/gcc/symtab.c:1163
0x6a19af symtab_node::verify_symtab_nodes()
        $TOP/gcc/gcc/symtab.c:1181
0x8dabd6 symbol_table::remove_unreachable_nodes(_IO_FILE*)
        $TOP/gcc/gcc/ipa.c:662
0x6b1fa4 ipa_passes
        $TOP/gcc/gcc/cgraphunit.c:2087
0x6b1fa4 symbol_table::compile()
        $TOP/gcc/gcc/cgraphunit.c:2221
0x6b3c71 symbol_table::finalize_compilation_unit()
        $TOP/gcc/gcc/cgraphunit.c:2370
0x54d083 c_write_global_declarations()
        $TOP/gcc/gcc/c/c-decl.c:10787
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[tbsaunde at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

tbsaunde at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tbsaunde at gcc dot gnu.org

--- Comment #12 from tbsaunde at gcc dot gnu.org ---
So, what is here is:
emutls calls varpool_node::create_alias(decl("emutls_v.bar"),
decl("emutls_v.foo")) which sets alias = true and alias_target =
node("emutls_v.foo") on the node for "emutls_v.bar", however it does not set up
ref_list.references on node("emutls_v.bar") to point at node("emutls_v.foo").
Then during varification we call symtab_node::get_alias_target() which gets the
alias from node("emutls_v.bar").ref_list.references but that crashes becauses
references doesn't contain an element for the alias target.

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hubicka at ucw dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #13 from Jan Hubicka <hubicka at ucw dot cz> ---
> So, what is here is:
> emutls calls varpool_node::create_alias(decl("emutls_v.bar"),
> decl("emutls_v.foo")) which sets alias = true and alias_target =
> node("emutls_v.foo") on the node for "emutls_v.bar", however it does not set up
> ref_list.references on node("emutls_v.bar") to point at node("emutls_v.foo").
> Then during varification we call symtab_node::get_alias_target() which gets the
> alias from node("emutls_v.bar").ref_list.references but that crashes becauses
> references doesn't contain an element for the alias target.

The way to get the references for alias is to call alias->resolve_alias.
The resolution normally happens at the end of parsing but if someone introduces
new alias late, he needs to cal the resolve_alias manually.

Honza

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[tbsaunde+mozilla at tbsaunde dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #14 from tbsaunde+mozilla at tbsaunde dot org ---
On Mon, Jan 26, 2015 at 03:56:05AM +0000, hubicka at ucw dot cz wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548
> 
> --- Comment #13 from Jan Hubicka <hubicka at ucw dot cz> ---
> > So, what is here is:
> > emutls calls varpool_node::create_alias(decl("emutls_v.bar"),
> > decl("emutls_v.foo")) which sets alias = true and alias_target =
> > node("emutls_v.foo") on the node for "emutls_v.bar", however it does not set up
> > ref_list.references on node("emutls_v.bar") to point at node("emutls_v.foo").
> > Then during varification we call symtab_node::get_alias_target() which gets the
> > alias from node("emutls_v.bar").ref_list.references but that crashes becauses
> > references doesn't contain an element for the alias target.
> 
> The way to get the references for alias is to call alias->resolve_alias.
> The resolution normally happens at the end of parsing but if someone introduces
> new alias late, he needs to cal the resolve_alias manually.

With that fixed things get a little farther, but there's still a
problem.  symbol_table::remove_unreachable_node () decides to remove one
of the tls aliases.  When varpool_node::remove () is called it first
clears ref_list with a call to symtab_node::unregister () and then calls
varpool_node::cdtor_usable_for_folding () which tries to get the alias
target, and so crashes because ref_list has been cleared.  I guess the
simplest thing is to call cdtor_usable_for_folding earlier, but I don't
know if there's something better.

Trev

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #15 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
I think it is best to modify the remove_unreachable_nodes loop to first remove
aliases before removing their target...

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[tbsaunde at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #16 from tbsaunde at gcc dot gnu.org ---
(In reply to Jan Hubicka from comment #15)
> I think it is best to modify the remove_unreachable_nodes loop to first
> remove aliases before removing their target...

how is this related? the target isn't removed at all in this case only the
alias.

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #17 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Created attachment 34673
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34673&action=edit
Proposed fix

Ok, there seems to be 3 issues ;)  First is that emutls does not resolve alias
after introducing it.  Second is that we may end up removing alias target
before alias in ipa.c and third is that vaprool_node::remove actually removes
the reference before attempting to use it.

I would welcome if someone tests this on one of the targets reproducing the
problem

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #18 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Thu Feb  5 03:57:32 2015
New Revision: 220432

URL: https://gcc.gnu.org/viewcvs?rev=220432&root=gcc&view=rev
Log:

    PR ipa/61548
    * varpool.c (varpool_node::remove): Fix order of variables.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/varpool.c

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #19 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Thu Feb  5 04:01:25 2015
New Revision: 220433

URL: https://gcc.gnu.org/viewcvs?rev=220433&root=gcc&view=rev
Log:

    PR ipa/61548
    * ipa.c (symbol_table::remove_unreachable_nodes): Fix ordering issue
    when removing varpool nodes.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa.c

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[tbsaunde at tbsaunde dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #20 from tbsaunde at tbsaunde dot org ---
> Created attachment 34673
>   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34673&action=edit
> Proposed fix
> 
> Ok, there seems to be 3 issues ;)  First is that emutls does not resolve alias
> after introducing it.  Second is that we may end up removing alias target
> before alias in ipa.c and third is that vaprool_node::remove actually removes
> the reference before attempting to use it.
> 
> I would welcome if someone tests this on one of the targets reproducing the
> problem

Well, the patch I sent did 1 and 3, and that fixed the crash, so I
expect adding 2 won't really hurt, but I can test that theory tomorrow.

Trev

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #22 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Trevor, seems I missed your patch. Sorry for that :(
I committed the last part then and lets close the PR

Thanks!

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #21 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Thu Feb  5 04:45:41 2015
New Revision: 220434

URL: https://gcc.gnu.org/viewcvs?rev=220434&root=gcc&view=rev
Log:
    PR ipa/61548
    * tree-emultls.c (new_emutls_decl): Resolve alias after creating it.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-emutls.c

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #23 from ktkachov at gcc dot gnu.org ---
(In reply to Jan Hubicka from comment #22)
> Trevor, seems I missed your patch. Sorry for that :(
> I committed the last part then and lets close the PR
> 
> Thanks!

The testcase doesn't ICE anymore, but on arm-none-eabi I'm seeing it fail with:

 Error: symbol `__emutls_v.foo' is already defined

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #24 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Apparently the test still fails, so I'm re-opening it as wrongly closed, since
it still fails for arm-eabi and cris-elf (same as in comment #23) and according
to <https://gcc.gnu.org/ml/gcc-testresults/2015-02/msg00812.html> also for
hppa64-hp-hpux11.11.  The error changed from ICE to something else but that is
not a reason to close the PR.

Comment #23 isn't clear that the assembler complains and that the relevant part
of gcc.log is:

output is:
/tmp/ccDUW6dB.s: Assembler messages:
/tmp/ccDUW6dB.s:37: Error: symbol `___emutls_v.foo' is already defined

Assembler code will be attached.

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c (internal compiler error)

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #25 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Created attachment 34695
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34695&action=edit
Assembly file showing the duplicate label

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #26 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Hmm, emutls_foo is added to symtab twice and therefore it is also output twice.
__emutls_v.foo/6 (__emutls_v.foo) @0x7ffff6973300                               
  Type: variable definition analyzed                                            
  Visibility: externally_visible public artificial                              
  next sharing asm name: 4                                                      
  References:                                                                   
  Referring: __emutls_v.bar/7 (alias)                                           
  Availability: available                                                       
  Varpool flags: initialized tls-emulated                                       
__emutls_v.foo/4 (__emutls_v.foo) @0x7ffff6973200                               
  Type: variable definition analyzed                                            
  Visibility: externally_visible public artificial                              
  previous sharing asm name: 6                                                  
  References:                                                                   
  Referring:                                                                    
  Availability: available                                                       
  Varpool flags: initialized tls-emulated

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #27 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Does the following patch fix the problem?
Index: tree-emutls.c
===================================================================
--- tree-emutls.c       (revision 220509)
+++ tree-emutls.c       (working copy)
@@ -753,17 +753,19 @@ ipa_lower_emutls (void)
   cgraph_node *func;
   bool any_aliases = false;
   tree ctor_body = NULL;
-
+  hash_set <varpool_node *> visited;
   auto_vec <varpool_node *> tls_vars;

   /* Examine all global variables for TLS variables.  */
   FOR_EACH_VARIABLE (var)
-    if (DECL_THREAD_LOCAL_P (var->decl))
+    if (DECL_THREAD_LOCAL_P (var->decl)
+       && !visited.add (var))
       {
        gcc_checking_assert (TREE_STATIC (var->decl)
                             || DECL_EXTERNAL (var->decl));
        tls_vars.safe_push (var);
-       if (var->alias && var->definition)
+       if (var->alias && var->definition
+           && !visited.add (var->ultimate_alias_target ()))
          tls_vars.safe_push (var->ultimate_alias_target ());
       }

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #29 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to Hans-Peter Nilsson from comment #28)
> (In reply to Jan Hubicka from comment #27)
> > Does the following patch fix the problem?
> 
> Yes! Full regtest is underway but this particular FAIL is fixed.  Thanks.

Completed now, with no regressions for cris-elf.

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

--- Comment #30 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Mon Feb  9 21:06:35 2015
New Revision: 220549

URL: https://gcc.gnu.org/viewcvs?rev=220549&root=gcc&view=rev
Log:
    PR ipa/61548
    * tree-emutls.c (ipa_lower_emutls): Avoid duplicates in TLS_VARS.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-emutls.c

[Bug ipa/61548] [5 Regression] FAIL: gcc.dg/tls/alias-1.c

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61548

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #31 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed.