public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug java/61552] New: Unneeded check for libart
@ 2014-06-18 17:56 Arfrever.FTA at GMail dot Com
  2014-11-14 19:01 ` [Bug java/61552] " Arfrever.FTA at GMail dot Com
  0 siblings, 1 reply; 2+ messages in thread
From: Arfrever.FTA at GMail dot Com @ 2014-06-18 17:56 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61552

            Bug ID: 61552
           Summary: Unneeded check for libart
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: java
          Assignee: unassigned at gcc dot gnu.org
          Reporter: Arfrever.FTA at GMail dot Com

According to my grepping, libart was actually used only in GCC 3.4.* and 4.0.*
(e.g. libart headers were included in GCC's
libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkImagePainter.c).

libjava/configure.ac in GCC trunk still contains:

      PKG_CHECK_MODULES(LIBART, libart-2.0 >= 2.1)
      AC_SUBST(LIBART_CFLAGS)
      AC_SUBST(LIBART_LIBS)

No Makefile.am file uses LIBART_CFLAGS or LIBART_LIBS.
4 generated Makefile.in files contain useless assignments of LIBART_CFLAGS and
LIBART_LIBS.

$ grep -E "LIBART_(CFLAGS|LIBS)" **/Makefile.am
$ grep -E "LIBART_(CFLAGS|LIBS)" **/Makefile.in
libjava/gcj/Makefile.in:LIBART_CFLAGS = @LIBART_CFLAGS@
libjava/gcj/Makefile.in:LIBART_LIBS = @LIBART_LIBS@
libjava/include/Makefile.in:LIBART_CFLAGS = @LIBART_CFLAGS@
libjava/include/Makefile.in:LIBART_LIBS = @LIBART_LIBS@
libjava/Makefile.in:LIBART_CFLAGS = @LIBART_CFLAGS@
libjava/Makefile.in:LIBART_LIBS = @LIBART_LIBS@
libjava/testsuite/Makefile.in:LIBART_CFLAGS = @LIBART_CFLAGS@
libjava/testsuite/Makefile.in:LIBART_LIBS = @LIBART_LIBS@

I suggest to delete check for libart in 
libjava/configure.ac and regenerate appropriate Makefile.in files.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug java/61552] Unneeded check for libart
  2014-06-18 17:56 [Bug java/61552] New: Unneeded check for libart Arfrever.FTA at GMail dot Com
@ 2014-11-14 19:01 ` Arfrever.FTA at GMail dot Com
  0 siblings, 0 replies; 2+ messages in thread
From: Arfrever.FTA at GMail dot Com @ 2014-11-14 19:01 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61552

--- Comment #1 from Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA at GMail dot Com> ---
Created attachment 33974
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33974&action=edit
gcc_delete_libart_check.patch


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-14 19:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-18 17:56 [Bug java/61552] New: Unneeded check for libart Arfrever.FTA at GMail dot Com
2014-11-14 19:01 ` [Bug java/61552] " Arfrever.FTA at GMail dot Com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).