[Bug libitm/61594] New: ICE (assertion failure) in trans-mem.c

[Bug libitm/61594] New: ICE (assertion failure) in trans-mem.c

[hammacher at cs dot uni-saarland.de]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 6162 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61594

            Bug ID: 61594
           Summary: ICE (assertion failure) in trans-mem.c
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libitm
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hammacher at cs dot uni-saarland.de

Created attachment 32998
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=32998&action=edit
preprocessed code triggering the bug

I am triggering a bug in the transactional memory instrumentation.

In trans-mem.c:1518 (originally line 1515, I added three lines to hack around
this bug), the following check fails:
> gcc_assert (TREE_CODE (x) == VAR_DECL);

because TREE_CODE(x) is STRING_CST.

$ g++-git -v -save-temps -O3 -std=c++11 -fgnu-tm -c indexer.cpp
Using built-in specs.
COLLECT_GCC=g++-git
Target: x86_64-unknown-linux-gnu
Configured with: /usr/src/gcc/configure --prefix=/opt/gcc-git
--program-suffix=git --disable-multilib : (reconfigured) /usr/src/gcc/configure
--prefix=/opt/gcc-git --program-suffix=-git --disable-multilib
Thread model: posix
gcc version 4.10.0 20140622 (experimental) (GCC)
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-O3' '-std=c++11' '-fgnu-tm' '-c'
'-shared-libgcc' '-mtune=generic' '-march=x86-64' '-pthread'
 /opt/gcc-git/libexec/gcc/x86_64-unknown-linux-gnu/4.10.0/cc1plus -E -quiet -v
-D_GNU_SOURCE -D_REENTRANT indexer.cpp -mtune=generic -march=x86-64 -std=c++11
-fgnu-tm -O3 -fpch-preprocess -o indexer.ii
ignoring nonexistent directory "/usr/local/include"
ignoring nonexistent directory
"/opt/gcc-git/lib/gcc/x86_64-unknown-linux-gnu/4.10.0/../../../../x86_64-unknown-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:

/opt/gcc-git/lib/gcc/x86_64-unknown-linux-gnu/4.10.0/../../../../include/c++/4.10.0

/opt/gcc-git/lib/gcc/x86_64-unknown-linux-gnu/4.10.0/../../../../include/c++/4.10.0/x86_64-unknown-linux-gnu

/opt/gcc-git/lib/gcc/x86_64-unknown-linux-gnu/4.10.0/../../../../include/c++/4.10.0/backward
 /opt/gcc-git/lib/gcc/x86_64-unknown-linux-gnu/4.10.0/include
 /opt/gcc-git/include
 /opt/gcc-git/lib/gcc/x86_64-unknown-linux-gnu/4.10.0/include-fixed
 /usr/include
End of search list.
COLLECT_GCC_OPTIONS='-v' '-save-temps' '-O3' '-std=c++11' '-fgnu-tm' '-c'
'-shared-libgcc' '-mtune=generic' '-march=x86-64' '-pthread'
 /opt/gcc-git/libexec/gcc/x86_64-unknown-linux-gnu/4.10.0/cc1plus
-fpreprocessed indexer.ii -quiet -dumpbase indexer.cpp -mtune=generic
-march=x86-64 -auxbase indexer -O3 -std=c++11 -version -fgnu-tm -o indexer.s
GNU C++ (GCC) version 4.10.0 20140622 (experimental) (x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.10.0 20140622 (experimental), GMP version
5.1.2, MPFR version 3.1.2, MPC version 1.0.1
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
GNU C++ (GCC) version 4.10.0 20140622 (experimental) (x86_64-unknown-linux-gnu)
        compiled by GNU C version 4.10.0 20140622 (experimental), GMP version
5.1.2, MPFR version 3.1.2, MPC version 1.0.1
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
Compiler executable checksum: 3ed828d89bc21f38ee29be835239ca4b
indexer.cpp: In member function ‘bool {anonymous}::Parser::parseDeclaration()’:
indexer.cpp:231:10: internal compiler error: in requires_barrier, at
trans-mem.c:1518
     bool parseDeclaration() {
          ^
0xba851f requires_barrier
        /usr/src/gcc/gcc/trans-mem.c:1518
0xba87e0 expand_assign_tm
        /usr/src/gcc/gcc/trans-mem.c:2254
0xba9a3e expand_block_tm
        /usr/src/gcc/gcc/trans-mem.c:2485
0xba9a3e execute_tm_mark
        /usr/src/gcc/gcc/trans-mem.c:2983
0xba9a3e execute
        /usr/src/gcc/gcc/trans-mem.c:3029
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-454801-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Jun 24 16:14:55 2014
Return-Path: <gcc-bugs-return-454801-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30494 invoked by alias); 24 Jun 2014 16:14:55 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30470 invoked by uid 48); 24 Jun 2014 16:14:52 -0000
From: "gcc-bugzilla at mailhell dot seb7.de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/61595] Inconsistent DWARF information for arrays of vector types
Date: Tue, 24 Jun 2014 16:14:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: debug
X-Bugzilla-Version: 4.7.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gcc-bugzilla at mailhell dot seb7.de
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-61595-4-siYKz3rQF4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61595-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61595-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg01883.txt.bz2
Content-length: 287

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida595

--- Comment #1 from Sebastian Meyer <gcc-bugzilla at mailhell dot seb7.de> ---
Created attachment 32999
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id2999&actioníit
Example source, produced DWARF information and memory dump

[Bug libitm/61594] ICE (assertion failure) in trans-mem.c

[patrick.marlier at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61594

--- Comment #1 from Patrick Marlier <patrick.marlier at gmail dot com> ---
Created attachment 33058
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33058&action=edit
reduced testcase

$ xgcc -Wall -Wextra -Wfatal-errors -O2 -fgnu-tm -S pr61594.c
pr61594.c: In function ‘fn1’:
pr61594.c:12:40: internal compiler error: in requires_barrier, at
trans-mem.c:1517
 __attribute__((transaction_safe)) void fn1() { fn2(""); }
>From gcc-bugs-return-455556-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jul 03 09:19:52 2014
Return-Path: <gcc-bugs-return-455556-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3841 invoked by alias); 3 Jul 2014 09:19:50 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3772 invoked by uid 48); 3 Jul 2014 09:19:41 -0000
From: "A.Finch at lancaster dot ac.uk" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/61674] The destructor of a simple class is removed by optimization
Date: Thu, 03 Jul 2014 09:19:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: A.Finch at lancaster dot ac.uk
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61674-4-q43wo4gc8e@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61674-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61674-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-07/txt/msg00147.txt.bz2
Content-length: 539

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida674

--- Comment #6 from Alex Finch <A.Finch at lancaster dot ac.uk> ---

I guess I should have made that clear. The class has a static variable:
static int fLockCount;

which counts how many times an object of the class is created.
If it is >1, then IsLocked() returns true. The destructor has a line
 --fLockCount;
which is not executed if the destructor is not called. This breaks the program.
The destructor should not be optimised out precisely because it modifies the
static variable.

[Bug libitm/61594] ICE (assertion failure) in trans-mem.c

[patrick.marlier at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61594

Patrick Marlier <patrick.marlier at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldyh at gcc dot gnu.org,
                   |                            |rth at gcc dot gnu.org

--- Comment #2 from Patrick Marlier <patrick.marlier at gmail dot com> ---
In requires_barrier, the tree is a TARGET_MEM_REF and the operand is a
STRING_CST. Because STRING_CST is constant and cannot be modified, it does not
need a barrier. So this could be solved like this:

Index: gcc/trans-mem.c
===================================================================
--- gcc/trans-mem.c     (revision 212229)
+++ gcc/trans-mem.c     (working copy)
@@ -1512,7 +1512,7 @@ requires_barrier (basic_block entry_block, tree x,
       if (TREE_CODE (TMR_BASE (x)) != ADDR_EXPR)
        return true;
       x = TREE_OPERAND (TMR_BASE (x), 0);
-      if (TREE_CODE (x) == PARM_DECL)
+      if (TREE_CODE (x) == PARM_DECL || TREE_CODE (x) == STRING_CST)
        return false;
       gcc_assert (TREE_CODE (x) == VAR_DECL);
       /* FALLTHRU */

However I think that we should not instrument for all constants (INTEGER_CST,
...) and even for read-only. So I would prefer solving the issue like this:

Index: gcc/trans-mem.c
===================================================================
--- gcc/trans-mem.c     (revision 212229)
+++ gcc/trans-mem.c     (working copy)
@@ -1512,7 +1512,7 @@ requires_barrier (basic_block entry_block, tree x,
       if (TREE_CODE (TMR_BASE (x)) != ADDR_EXPR)
        return true;
       x = TREE_OPERAND (TMR_BASE (x), 0);
-      if (TREE_CODE (x) == PARM_DECL)
+      if (TREE_CODE (x) == PARM_DECL || TREE_CONSTANT (x) || TREE_READONLY
(x))
        return false;
       gcc_assert (TREE_CODE (x) == VAR_DECL);
       /* FALLTHRU */

Note that 4.8 is also affected.

[Bug libitm/61594] ICE (assertion failure) in trans-mem.c

[torvald at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61594

torvald at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |torvald at gcc dot gnu.org
         Resolution|---                         |WORKSFORME

--- Comment #3 from torvald at gcc dot gnu.org ---
I can't reproduce this on SVN trunk (r220039), so I'll close this for now.

I didn't spot anything bad when briefly looking at the generated code.

[Bug libitm/61594] ICE (assertion failure) in trans-mem.c

[patrick.marlier at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61594

--- Comment #4 from Patrick Marlier <patrick.marlier at gmail dot com> ---
GCC 4.8.3 and 4.9.1 still fail with an ICE. Please adjust the version in the PR
and change the status.
(I did not test 4.8.4 and 4.9.2 but I can test it).

[Bug libitm/61594] ICE (assertion failure) in trans-mem.c

[hammacher at cs dot uni-saarland.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61594

Clemens Hammacher <hammacher at cs dot uni-saarland.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|WORKSFORME                  |---

--- Comment #5 from Clemens Hammacher <hammacher at cs dot uni-saarland.de> ---
I confirm that it seems to be fixed in SVN trunk. 
Changed version to 4.9.1 without further testing - I don't have the
corresponsing versions on my machine.

[Bug libitm/61594] ICE (assertion failure) in trans-mem.c

[torvald at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61594

--- Comment #6 from torvald at gcc dot gnu.org ---
We can keep it open, but my guess is that it would need some volunteer to
actively drive the backporting process. I.e., with a patch and testing.  Given
that TM is experimental, I think backporting fixes for TM has low priority on
most people's todo list.

[Bug libitm/61594] ICE (assertion failure) in trans-mem.c

[torvald at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61594

torvald at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|5.0                         |4.9.1

--- Comment #7 from torvald at gcc dot gnu.org ---
Changed version to 4.9.1.

[Bug libitm/61594] ICE (assertion failure) in trans-mem.c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61594

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |4.9.4
   Last reconfirmed|                            |2022-01-07
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
      Known to work|                            |5.1.0
           Keywords|                            |ice-on-valid-code,
                   |                            |needs-bisection

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Seems to have been fixed in GCC 5+. Be interesting to see what revision fixed
this.

[Bug libitm/61594] ICE (assertion failure) in trans-mem.c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61594

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|needs-bisection             |
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
Changed with r8-835-gb7cb2251a32e7af5.