[Bug bootstrap/61598] New: [4.10 regression] fold-const.c:14755:37: error: no matching function for call to 'hash_table<pointer_hash<tree_node> >::find_slot

[Bug bootstrap/61598] New: [4.10 regression] fold-const.c:14755:37: error: no matching function for call to 'hash_table<pointer_hash<tree_node> >::find_slot

[dimhen at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61598

            Bug ID: 61598
           Summary: [4.10 regression] fold-const.c:14755:37: error: no
                    matching function for call to
                    'hash_table<pointer_hash<tree_node> >::find_slot
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dimhen at gmail dot com

gcc-trunk
r211865 PASS
r211954 FAIL

configure --enable-checking=fold

make[3]: Entering directory `/home/dimhen/build/gcc_current/gcc'
g++ -c   -g -DIN_GCC    -fno-exceptions -fno-rtti -fasynchronous-unwind-tables
-W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format
-Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -I. -I.
-I/home/dimhen/src/gcc_current/gcc -I/home/dimhen/src/gcc_current/gcc/.
-I/home/dimhen/src/gcc_current/gcc/../include
-I/home/dimhen/src/gcc_current/gcc/../libcpp/include
-I/home/dimhen/build/gcc_current/./gmp -I/home/dimhen/src/gcc_current/gmp
-I/home/dimhen/build/gcc_current/./mpfr -I/home/dimhen/src/gcc_current/mpfr
-I/home/dimhen/src/gcc_current/mpc/src 
-I/home/dimhen/src/gcc_current/gcc/../libdecnumber
-I/home/dimhen/src/gcc_current/gcc/../libdecnumber/bid -I../libdecnumber
-I/home/dimhen/src/gcc_current/gcc/../libbacktrace -DCLOOG_INT_GMP
-I/home/dimhen/build/gcc_current/./cloog/include
-I/home/dimhen/src/gcc_current/cloog/include
-I/home/dimhen/build/gcc_current/./isl/include
-I/home/dimhen/src/gcc_current/isl/include  -o fold-const.o -MT fold-const.o
-MMD -MP -MF ./.deps/fold-const.TPo
/home/dimhen/src/gcc_current/gcc/fold-const.c
/home/dimhen/src/gcc_current/gcc/fold-const.c: In function 'void
fold_checksum_tree(const_tree, md5_ctx*, hash_table<pointer_hash<tree_node>
>*)':
/home/dimhen/src/gcc_current/gcc/fold-const.c:14755:37: error: no matching
function for call to 'hash_table<pointer_hash<tree_node> >::find_slot(const
tree_node*&, insert_option)'
   slot = ht->find_slot (expr, INSERT);
                                     ^
/home/dimhen/src/gcc_current/gcc/fold-const.c:14755:37: note: candidate is:
In file included from /home/dimhen/src/gcc_current/gcc/fold-const.c:70:0:
/home/dimhen/src/gcc_current/gcc/hash-table.h:1030:15: note:
hash_table<Descriptor, Allocator, true>::value_type* hash_table<Descriptor,
Allocator, true>::find_slot(const value_type&, insert_option) [with Descriptor
= pointer_hash<tree_node>; Allocator = xcallocator; hash_table<Descriptor,
Allocator, true>::value_type = tree_node*] <near match>
   value_type *find_slot (const value_type &value, insert_option insert)
               ^
/home/dimhen/src/gcc_current/gcc/hash-table.h:1030:15: note:   no known
conversion for argument 1 from 'const_tree {aka const tree_node*}' to
'tree_node* const&'
make[3]: *** [fold-const.o] Error 1
make[3]: Leaving directory `/home/dimhen/build/gcc_current/gcc'
make[2]: *** [all-stage1-gcc] Error 2
make[2]: Leaving directory `/home/dimhen/build/gcc_current'
make[1]: *** [stage1-bubble] Error 2
make[1]: Leaving directory `/home/dimhen/build/gcc_current'
make: *** [all] Error 2

[Bug bootstrap/61598] [4.10 regression] fold-const.c:14755:37: error: no matching function for call to 'hash_table<pointer_hash<tree_node> >::find_slot

[tsaunders at mozilla dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61598

Trevor Saunders <tsaunders at mozilla dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tsaunders at mozilla dot com

--- Comment #2 from Trevor Saunders <tsaunders at mozilla dot com> ---
So we went from find_slot taking a const uninon tree_node *& to taking a union
tree_node * const& I tend to think that the later is more "correct" since the
type of thing in the hash table and hence the thing that is const is a union
tree_node *.  Further the result of find_slot is a tree_node ** which is not
const.

So I think the appropriate solution is to just const_cast to tree, but a sanity
check of that would be nice.

[Bug bootstrap/61598] [4.10 regression] fold-const.c:14755:37: error: no matching function for call to 'hash_table<pointer_hash<tree_node> >::find_slot

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61598

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.10.0

[Bug bootstrap/61598] [4.10 regression] fold-const.c:14755:37: error: no matching function for call to 'hash_table<pointer_hash<tree_node> >::find_slot

[tbsaunde at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61598

--- Comment #3 from tbsaunde at gcc dot gnu.org ---
Author: tbsaunde
Date: Wed Jun 25 16:02:04 2014
New Revision: 211985

URL: https://gcc.gnu.org/viewcvs?rev=211985&root=gcc&view=rev
Log:
fix checking=fold

gcc/

        PR bootstrap/61598
        * fold-const.c (fold_checksum_tree): Use a hash_table of const
        tree_node * instead of tree_node *.
        (fold): Adjust.
        (print_fold_checksum): Likewise.
        (fold_check_failed): Likewise.
        (debug_fold_checksum): Likewise.
        (fold_build1_stat_loc): Likewise.
        (fold_build2_stat_loc): Likewise.
        (fold_build3_stat_loc): Likewise.
        (fold_build_call_array_loc): Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/fold-const.c

[Bug bootstrap/61598] [4.10 regression] fold-const.c:14755:37: error: no matching function for call to 'hash_table<pointer_hash<tree_node> >::find_slot

[tbsaunde at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61598

tbsaunde at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from tbsaunde at gcc dot gnu.org ---
fixed