[Bug c/61634] New: [4.8.3/4.9.1] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[Bug c/61634] New: [4.8.3/4.9.1] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[manuel.lauss at googlemail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

            Bug ID: 61634
           Summary: [4.8.3/4.9.1] ICE in in vect_get_vec_def_for_operand,
                    at tree-vect-stmts.c:1423
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: manuel.lauss at googlemail dot com

Created attachment 33018
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33018&action=edit
preprocessed source

Hello,

I get the following ICE on current 4_8-branch and 4_9-branch with the attached
preprocessed source (taken from opencore-amr-1.3.0):

x86_64-pc-linux-gnu-g++ -x c -O3 -fwrapv -c autocorr.x  -fPIC -DPIC -o
autocorr.o
autocorr.x: In function 'Autocorr':
autocorr.x:418:8: internal compiler error: in vect_get_vec_def_for_operand, at
tree-vect-stmts.c:1423
 Word16 Autocorr(
        ^
Please submit a full bug report,
with preprocessed source if appropriate.

"-O3 -fwrapv" throws ICE,
"-O2 -fwrapv" or plain "-O3" pass.

[Bug tree-optimization/61634] [4.8/4.9/4.10 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-06-28
                 CC|                            |trippels at gcc dot gnu.org
   Target Milestone|---                         |4.8.4
            Summary|[4.8.3/4.9.1] ICE in in     |[4.8/4.9/4.10 Regression]
                   |vect_get_vec_def_for_operan |ICE in in
                   |d, at                       |vect_get_vec_def_for_operan
                   |tree-vect-stmts.c:1423      |d, at
                   |                            |tree-vect-stmts.c:1423
     Ever confirmed|0                           |1

--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Confirmed.

markus@x4 tmp % cat autocorr.i
int a, b, c, d;
short *e;
void fn1 (int p1[], int p2, int p3[], int p4[], int p5[], int *p6)
{
  int f;
  c = *p1;
  d = *p5;
  (void)p6;
  for (; a; a--)
    {
      f = *e >> 2;
      *e++ = f;
      b += f * f;
      f = *e >> 2;
      *e++ = f;
    }
  p4[0] = p3[0];
  for (;; p2--)
    ;
}

markus@x4 tmp % gcc -O3 -fwrapv -c autocorr.i
autocorr.i: In function ‘fn1’:
autocorr.i:3:6: internal compiler error: in vect_get_vec_def_for_operand, at
tree-vect-stmts.c:1449
 void fn1 (int p1[], int p2, int p3[], int p4[], int p5[], int *p6)
      ^
>From gcc-bugs-return-455189-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Jun 28 07:46:31 2014
Return-Path: <gcc-bugs-return-455189-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 29632 invoked by alias); 28 Jun 2014 07:46:30 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 28097 invoked by uid 55); 28 Jun 2014 07:46:12 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/58051] [DR1579] No named return value optimization when returned object is implicitly converted
Date: Sat, 28 Jun 2014 07:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.1
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-58051-4-4uunO9iUjE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58051-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58051-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg02271.txt.bz2
Content-length: 599

https://gcc.gnu.org/bugzilla/show_bug.cgi?idX051

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Sat Jun 28 07:45:27 2014
New Revision: 212099

URL: https://gcc.gnu.org/viewcvs?rev!2099&root=gcc&view=rev
Log:
gcc/cp:
    DR 1579
    PR c++/58051
    * typeck.c (check_return_expr): Lookup as an rvalue even when the
    types aren't the same.

gcc/testsuite:
    * g++.dg/cpp0x/elision_conv.C: New.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/elision_conv.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/typeck.c
    trunk/gcc/testsuite/ChangeLog

[Bug tree-optimization/61634] [4.8/4.9/4.10 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r175074.

[Bug tree-optimization/61634] [4.8/4.9/4.10 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
I'll have a look.

[Bug tree-optimization/61634] [4.8/4.9/4.10 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
We have

patt_24 = DOT_PROD_EXPR <_12, _12, prephitmp_48>;

and

_12 = _11 >> 2;

is not STMT_VINFO_IN_PATTERN_P but it doesn't have a vec_stmt yet even
though it is there:

  vect__12.29_90 = vect__11.27_87 >> 2;
  vect__12.29_91 = vect__11.28_89 >> 2;
  _12 = _11 >> 2;

that's because vectorizable_shift doesn't assign to *vec_stmt!?

      if (slp_node)
        continue;

      if (j == 0)
        STMT_VINFO_VEC_STMT (stmt_info) = *vec_stmt = new_stmt;
      else
        STMT_VINFO_RELATED_STMT (prev_stmt_info) = new_stmt;

if it's part of an SLP node... (pure_slp).

I'm not sure we can vectorize this case.

[Bug tree-optimization/61634] [4.8/4.9/5 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
The issue seems that we fail to detect hybrid SLP here because
vect_detect_hybrid_slp_stmts walks immediate uses of SLP defs but those
do not reach pattern stmts but only original ones.  In this case we have

  _11 = *prephitmp_46;
  _12 = _11 >> 2;
  f_13 = (int) _12;
  *prephitmp_46 = _12;
  _17 = f_13 * f_13;

where the SLP def _12 is used in f_13 = (int) _12; but that stmt is marked
as vect_unused_in_scope because it feeds a stmt that was pattern detected
as widening multiplication.  But we never visit that stmt, as its
immediate uses are not accounted for (pattern stmts never get updated).

That makes the vect_detect_hybrid_slp_stmts functions non-functional
for non-trivial patterns.  We can "fix" this by marking the stmts
in some way and make sure to account for them in the loop.  For the
testcase forcing hybrid SLP by making !STMT_VINFO_RELEVANT stmts
force it fixes it.

I think that the best thing to do is to re-write hybrid SLP detection
in terms of walking all stmts in the loop, similar to
vect_mark_stmts_to_be_vectorized and mark pure SLP stmts as hybrid.
The flag then still has to be propagated to the SLP tree children of
such node.

I have a prototype but that still needs quite some TLC.

[Bug tree-optimization/61634] [4.8/4.9/5 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Thu Nov 27 09:33:32 2014
New Revision: 218113

URL: https://gcc.gnu.org/viewcvs?rev=218113&root=gcc&view=rev
Log:
2014-11-27  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/61634
    * tree-vect-slp.c: Include gimple-walk.h.
    (vect_detect_hybrid_slp_stmts): Rewrite to propagate hybrid
    down the SLP tree for one scalar statement.
    (vect_detect_hybrid_slp_1): New walker function.
    (vect_detect_hybrid_slp_2): Likewise.
    (vect_detect_hybrid_slp): Properly handle pattern statements
    in a pre-scan over all loop stmts.

    * gcc.dg/vect/pr61634.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.dg/vect/pr61634.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-vect-slp.c

[Bug tree-optimization/61634] [4.8/4.9 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |5.0
            Summary|[4.8/4.9/5 Regression] ICE  |[4.8/4.9 Regression] ICE in
                   |in in                       |in
                   |vect_get_vec_def_for_operan |vect_get_vec_def_for_operan
                   |d, at                       |d, at
                   |tree-vect-stmts.c:1423      |tree-vect-stmts.c:1423

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.  I'll give it some time before backporting - the patch is
quite non-trivial.

[Bug tree-optimization/61634] [4.8/4.9 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug tree-optimization/61634] [4.8/4.9 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.4                       |4.8.5

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.

[Bug tree-optimization/61634] [4.8/4.9 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Mon Feb 23 11:14:25 2015
New Revision: 220912

URL: https://gcc.gnu.org/viewcvs?rev=220912&root=gcc&view=rev
Log:
2015-02-23  Richard Biener  <rguenther@suse.de>

    Backport from mainline
    2014-11-19  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/63844
    * omp-low.c (fixup_child_record_type): Use a restrict qualified
    referece type for the receiver parameter.

    2014-11-27  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/61634
    * tree-vect-slp.c: Include gimple-walk.h.
    (vect_detect_hybrid_slp_stmts): Rewrite to propagate hybrid
    down the SLP tree for one scalar statement.
    (vect_detect_hybrid_slp_1): New walker function.
    (vect_detect_hybrid_slp_2): Likewise.
    (vect_detect_hybrid_slp): Properly handle pattern statements
    in a pre-scan over all loop stmts.

    * gcc.dg/vect/pr61634.c: New testcase.

    2015-01-14  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/59354
    * tree-vect-slp.c (vect_build_slp_tree_1): Treat loads from
    groups larger than the slp group size as having gaps.

    * gcc.dg/vect/pr59354.c: New testcase.

    2015-02-10  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/64909
    * tree-vect-loop.c (vect_estimate_min_profitable_iters): Properly
    pass a scalar-stmt count estimate to the cost model.
    * tree-vect-data-refs.c (vect_peeling_hash_get_lowest_cost): Likewise.

    * gcc.dg/vect/costmodel/x86_64/costmodel-pr64909.c: New testcase.

Added:
   
branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/vect/costmodel/x86_64/costmodel-pr64909.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/vect/pr59354.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/vect/pr61634.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/omp-low.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_9-branch/gcc/tree-vect-data-refs.c
    branches/gcc-4_9-branch/gcc/tree-vect-loop.c
    branches/gcc-4_9-branch/gcc/tree-vect-slp.c

[Bug tree-optimization/61634] [4.8 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Thu Feb 26 13:28:48 2015
New Revision: 221006

URL: https://gcc.gnu.org/viewcvs?rev=221006&root=gcc&view=rev
Log:
2015-02-26  Richard Biener  <rguenther@suse.de>

    Backport from mainline
    2014-11-27  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/61634
    * tree-vect-slp.c: (vect_detect_hybrid_slp_stmts): Rewrite to
    propagate hybrid down the SLP tree for one scalar statement.
    (vect_detect_hybrid_slp_1): New walker function.
    (vect_detect_hybrid_slp_2): Likewise.
    (vect_detect_hybrid_slp): Properly handle pattern statements
    in a pre-scan over all loop stmts.

    * gcc.dg/vect/pr61634.c: New testcase.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/vect/pr61634.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_8-branch/gcc/tree-vect-slp.c

[Bug tree-optimization/61634] [4.8 Regression] ICE in in vect_get_vec_def_for_operand, at tree-vect-stmts.c:1423

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61634

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to work|                            |4.8.5
         Resolution|---                         |FIXED
      Known to fail|                            |4.8.4

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.