public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "andi at firstfloor dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/61635] LTO partitioner does not handle &&label in statics
Date: Sat, 28 Jun 2014 01:16:00 -0000	[thread overview]
Message-ID: <bug-61635-4-B6mkbjCtll@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-61635-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61635

--- Comment #2 from andi at firstfloor dot org ---
Test case

git clone https://github.com/andikleen/linux-misc -b lto-linus-3.15
Build with the attached kernel config (copy to .config in the build dir) and
4.9

-Andi

On Fri, Jun 27, 2014 at 11:04:00PM +0000, hubicka at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61635
> 
> Jan Hubicka <hubicka at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|UNCONFIRMED                 |ASSIGNED
>    Last reconfirmed|                            |2014-06-27
>                  CC|                            |hubicka at gcc dot gnu.org
>            Assignee|unassigned at gcc dot gnu.org      |hubicka at gcc dot gnu.org
>      Ever confirmed|0                           |1
> 
> --- Comment #1 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
> Yep, this is a known problem. We do not represent labels in symbol table and
> thus LTO partitioner has no clue about them. I would be interested to see the
> example that fails - theoretically the problematic static variable should
> always end up in the same partition as the function using it, because that
> function is no inline and no clone and should not get duplicated. So kernel &
> friends should fail only with -flto-partition=1to1 not with ballanced/none/one
> algorithms.
> 
> I plan correct solution - I already implemented labels for symtab some time ago
> but I would like to re-do it on the new API.
> The poor-man's class hiearchy in C was not very pretty and a lot of code is
> still not updated to nots assume two basic types of symbols (variables and
> functions). With Martin Liska we are updating the APIs and once it is done I
> will add symbols for non-local labels and const_decls.
> 
> -- 
> You are receiving this mail because:
> You reported the bug.
>


  parent reply	other threads:[~2014-06-28  1:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 21:26 [Bug lto/61635] New: " andi-gcc at firstfloor dot org
2014-06-27 23:04 ` [Bug lto/61635] " hubicka at gcc dot gnu.org
2014-06-28  1:16 ` andi at firstfloor dot org [this message]
2014-06-28  6:33 ` hubicka at ucw dot cz
2014-06-28 15:51 ` andi-gcc at firstfloor dot org
2014-06-28 15:57 ` andi-gcc at firstfloor dot org
2014-06-28 21:55 ` hubicka at ucw dot cz
2015-03-29 19:57 ` andi-gcc at firstfloor dot org
2015-03-30  7:09 ` hubicka at gcc dot gnu.org
2015-03-30  7:24 ` hubicka at ucw dot cz
2015-03-30  8:23 ` hubicka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-61635-4-B6mkbjCtll@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).