[Bug rtl-optimization/61641] New: [4.9 Regression] undefined label in jump_table_data

[Bug rtl-optimization/61641] New: [4.9 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

            Bug ID: 61641
           Summary: [4.9 Regression] undefined label in jump_table_data
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: danglin at gcc dot gnu.org
              Host: hppa-unknown-linux-gnu
            Target: hppa-unknown-linux-gnu
             Build: hppa-unknown-linux-gnu

Created attachment 33027
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33027&action=edit
Preprocessed source

dave@mx3210:~/mesa-gcc$ g++ -fpreprocessed -fvisibility=hidden -g -O2 -Wformat
-Werror=format-security -Wall -Wall -fno-strict-aliasing -fno-builtin-memcmp
-MT opt_vectorize.lo -MD -MP -MF .deps/opt_vectorize.Tpo -c opt_vectorize.ii 
-fPIC -DPIC -o opt_vectorize.o
/tmp/ccGEh3f3.s: Assembler messages:
/tmp/ccGEh3f3.s:717: Error: can't resolve `.L71' {.text section} - `.L78'
{*UND* section}
/tmp/ccGEh3f3.s:718: Error: can't resolve `.L79' {.text section} - `.L78'
{*UND* section}
/tmp/ccGEh3f3.s:719: Error: can't resolve `.L72' {.text section} - `.L78'
{*UND* section}
/tmp/ccGEh3f3.s:720: Error: can't resolve `.L82' {.text section} - `.L78'
{*UND* section}
/tmp/ccGEh3f3.s:721: Error: can't resolve `.L72' {.text section} - `.L78'
{*UND* section}
/tmp/ccGEh3f3.s:722: Error: can't resolve `.L72' {.text section} - `.L78'
{*UND* section}
/tmp/ccGEh3f3.s:723: Error: can't resolve `.L72' {.text section} - `.L78'
{*UND* section}
/tmp/ccGEh3f3.s:724: Error: can't resolve `.L70' {.text section} - `.L78'
{*UND* section}

We have following RTL after barriers pass:

(jump_insn:TI 135 164 136 (parallel [
            (set (pc)
                (mem:SI (plus:SI (mult:SI (reg:SI 20 %r20 [orig:141 D.35077 ]
[141])
                            (const_int 4 [0x4]))
                        (label_ref 136)) [0  S4 A32]))
            (clobber (reg:SI 21 %r21))
            (clobber (reg:SI 22 %r22))
        ]) ../../../../src/glsl/opt_vectorize.cpp:224 193 {casesi32p}
     (expr_list:REG_DEAD (reg:SI 20 %r20 [orig:141 D.35077 ] [141])
        (expr_list:REG_UNUSED (reg:SI 22 %r22)
            (expr_list:REG_UNUSED (reg:SI 21 %r21)
                (nil))))
 -> 136)
(code_label 136 135 295 78 "" [1 uses])
(insn 295 136 137 (const_int 1 [0x1]) -1
     (nil))
(jump_table_data 137 295 296 (addr_diff_vec:SI (label_ref:SI 136)
         [
            (label_ref:SI 62)
            (label_ref:SI 139)
            (label_ref:SI 57)
            (label_ref:SI 163)
            (label_ref:SI 57)
            (label_ref:SI 57)
            (label_ref:SI 57)
            (label_ref:SI 53)
        ]
        (const_int 0 [0])
        (const_int 0 [0])))
(insn 296 137 138 (const_int 2 [0x2]) -1
     (nil))
(barrier 138 296 53)

After dbr pass, we have:

(barrier 59 57 58)
(note 58 59 164 [bb 11] NOTE_INSN_BASIC_BLOCK)
(note 164 58 137 [bb 12] NOTE_INSN_BASIC_BLOCK)
(jump_table_data 137 164 296 (addr_diff_vec:SI (label_ref:SI 136)
         [
            (label_ref:SI 62)
            (label_ref:SI 139)
            (label_ref:SI 57)
            (label_ref:SI 163)
            (label_ref:SI 57)
            (label_ref:SI 57)
            (label_ref:SI 57)
            (label_ref:SI 53)
        ]
        (const_int 0 [0])
        (const_int 0 [0])))
(insn 296 137 138 (const_int 2 [0x2]) 211 {end_brtab}
     (nil))
(barrier 138 296 53)

The casesi jump and code_label 136 have been deleted, but not the
addr_diff_vec using code_label 136.

This results in the incorrect assembly code.

[Bug rtl-optimization/61641] [4.9 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> ---
Created attachment 33028
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33028&action=edit
opt_vectorize.ii.240r.barriers

[Bug rtl-optimization/61641] [4.9 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

--- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> ---
Created attachment 33029
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33029&action=edit
opt_vectorize.ii.241r.dbr

[Bug rtl-optimization/61641] [4.9 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steven at gcc dot gnu.org

--- Comment #3 from John David Anglin <danglin at gcc dot gnu.org> ---
Introduced in r197266:
https://gcc.gnu.org/ml/gcc-cvs/2013-03/msg00895.html

[Bug rtl-optimization/61641] [4.9/4.10 Regression] undefined label in jump_table_data

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
   Target Milestone|---                         |4.9.1
            Summary|[4.9 Regression] undefined  |[4.9/4.10 Regression]
                   |label in jump_table_data    |undefined label in
                   |                            |jump_table_data

[Bug rtl-optimization/61641] [4.9/4.10 Regression] undefined label in jump_table_data

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.1                       |4.9.2

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.1 has been released.

[Bug rtl-optimization/61641] [4.9/4.10 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

--- Comment #5 from John David Anglin <danglin at gcc dot gnu.org> ---
Created attachment 33271
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33271&action=edit
Patch

Maybe this will fix.

[Bug rtl-optimization/61641] [4.9/4.10 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

--- Comment #6 from John David Anglin <danglin at gcc dot gnu.org> ---
The patch does what it's supposed to but it's not right:

.LVL58:
        comib,<> 0,%r28,.L70
        nop
.L74:
.L80:
        .begin_brtab
        .word .L73-.L80
        .word .L81-.L80
        .word .L74-.L80
        .word .L84-.L80
        .word .L74-.L80
        .word .L74-.L80
        .word .L74-.L80
        .word .L72-.L80
        .end_brtab
.L72:
.LBE104:
.LBE103:
.LBB105:
.LBB106:
        .loc 2 228 0
        ldi 3,%r28

The branch table is in the text section.  It appears from the above
that the execution flow can drop into the branch table.  So, either
removal of the associated casesi insn was wrong or the branch table
needs to be removed when the table label is removed.

[Bug target/61641] [4.9/4.10 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|rtl-optimization            |target

--- Comment #7 from John David Anglin <danglin at gcc dot gnu.org> ---
The brtab markers break delete_related_insns().  On SOM, we need
to use ASM_OUTPUT_ADDR_DIFF_VEC to generate the markers, instead
of pa_reorg.

[Bug target/61641] [4.9/4.10 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33271|0                           |1
        is obsolete|                            |

--- Comment #8 from John David Anglin <danglin at gcc dot gnu.org> ---
Created attachment 33292
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33292&action=edit
Patch

The attached patch fixes the testcase.  However, delay-slot-2.c
now fails when compiling 32-bit non PIC code.

[Bug target/61641] [4.9/5 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

--- Comment #9 from John David Anglin <danglin at gcc dot gnu.org> ---
With the patch from comment #8, I find the failure of delay-slot-2.c
was introduced in r209897:

2014-03-21  James Greenhalgh  <james.greenhalgh@arm.com>

    * calls.c (initialize_argument_information): Always treat
    PUSH_ARGS_REVERSED as 1, simplify code accordingly.
    (expand_call): Likewise.
    (emit_library_call_calue_1): Likewise.
    * expr.c (PUSH_ARGS_REVERSED): Do not define.
    (emit_push_insn): Always treat PUSH_ARGS_REVERSED as 1, simplify
    code accordingly.

[Bug target/61641] [4.9/5 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

--- Comment #10 from John David Anglin <danglin at gcc dot gnu.org> ---
Author: danglin
Date: Sat Aug 16 16:36:33 2014
New Revision: 214064

URL: https://gcc.gnu.org/viewcvs?rev=214064&root=gcc&view=rev
Log:
    PR target/61641
    * config/pa/pa-protos.h (pa_output_addr_vec, pa_output_addr_diff_vec):
    Declare.
    * config/pa/pa.c (pa_reorg): Remove code to insert brtab marker insns.
    (pa_output_addr_vec, pa_output_addr_diff_vec): New.
    * config/pa/pa.h (ASM_OUTPUT_ADDR_VEC, ASM_OUTPUT_ADDR_DIFF_VEC):
    Define.
    * config/pa/pa.md (begin_brtab): Delete insn.
    (end_brtab): Likewise.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/pa/pa-protos.h
    trunk/gcc/config/pa/pa.c
    trunk/gcc/config/pa/pa.h
    trunk/gcc/config/pa/pa.md

[Bug target/61641] [4.9/5 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

--- Comment #11 from John David Anglin <danglin at gcc dot gnu.org> ---
Author: danglin
Date: Sat Aug 16 16:39:17 2014
New Revision: 214065

URL: https://gcc.gnu.org/viewcvs?rev=214065&root=gcc&view=rev
Log:
    PR target/61641
    * config/pa/pa-protos.h (pa_output_addr_vec, pa_output_addr_diff_vec):
    Declare.
    * config/pa/pa.c (pa_reorg): Remove code to insert brtab marker insns.
    (pa_output_addr_vec, pa_output_addr_diff_vec): New.
    * config/pa/pa.h (ASM_OUTPUT_ADDR_VEC, ASM_OUTPUT_ADDR_DIFF_VEC):
    Define.
    * config/pa/pa.md (begin_brtab): Delete insn.
    (end_brtab): Likewise.


Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/config/pa/pa-protos.h
    branches/gcc-4_9-branch/gcc/config/pa/pa.c
    branches/gcc-4_9-branch/gcc/config/pa/pa.h
    branches/gcc-4_9-branch/gcc/config/pa/pa.md

[Bug target/61641] [4.9/5 Regression] undefined label in jump_table_data

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So fixed?

[Bug target/61641] [4.9/5 Regression] undefined label in jump_table_data

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

--- Comment #13 from dave.anglin at bell dot net ---
On 1-Sep-14, at 5:23 AM, jakub at gcc dot gnu.org wrote:

> So fixed?

I left it open because of the following fail on hppa-unknown-linux-gnu:
FAIL: gcc.dg/delay-slot-2.c scan-assembler printf
The table jump and related insns are incorrectly removed.  Haven't had  
time
to determine why.

Dave
--
John David Anglin    dave.anglin@bell.net

[Bug target/61641] [4.9/5 Regression] undefined label in jump_table_data

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.2                       |4.9.3

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.2 has been released.

[Bug target/61641] [4.9/5 Regression] undefined label in jump_table_data

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61641

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from John David Anglin <danglin at gcc dot gnu.org> ---
The failure mentioned in comment #13 is gone.