[Bug libstdc++/61645] New: forward_list::splice_after shall not throw exceptions

[Bug libstdc++/61645] New: forward_list::splice_after shall not throw exceptions

[lh_mouse at 126 dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61645

            Bug ID: 61645
           Summary: forward_list::splice_after shall not throw exceptions
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: lh_mouse at 126 dot com

ISO/IEC 14882:2011

23.3.4.6 forward_list operations [forwardlist.ops]
void splice_after(const_iterator position, forward_list& x);
void splice_after(const_iterator position, forward_list&& x);
(... omitted ...)
3 Throws: Nothing. **
4 Complexity: O(distance(x.begin(), x.end()))



// test_case.cpp

#include <forward_list>

int main(){
    std::forward_list<int> l{1,2,3};
    static_assert(
        noexcept(l.splice_after(l.before_begin(), l)),
        "!!"
    ); // fails
    static_assert(
        noexcept(l.splice_after(l.before_begin(), l, l.before_begin())),
        "!!"
    ); // ditto
    static_assert(
        noexcept(l.splice_after(l.before_begin(), l, l.before_begin(),
l.end())),
        "!!"
    ); // ditto
}

[Bug libstdc++/61645] forward_list::splice_after shall not throw exceptions

[daniel.kruegler at googlemail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61645

Daniel Krügler <daniel.kruegler at googlemail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.kruegler@googlemail.
                   |                            |com

--- Comment #1 from Daniel Krügler <daniel.kruegler at googlemail dot com> ---
"Throws: Nothing" does not impose the requirement onto implementations that
such a function is required to be marked equivalent to noexcept(true), so this
looks more like an enhancement request to me - but let's wait what Jonathan or
Pablo have to say.
>From gcc-bugs-return-455261-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Jun 29 10:54:17 2014
Return-Path: <gcc-bugs-return-455261-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21964 invoked by alias); 29 Jun 2014 10:54:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21742 invoked by uid 48); 29 Jun 2014 10:54:11 -0000
From: "daniel.kruegler at googlemail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/61647] internal compiler error: in push_access_scope, at cp/pt.c:219 for a c++ header, clang++ 3.4 generate .pch without error
Date: Sun, 29 Jun 2014 10:54:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: daniel.kruegler at googlemail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-61647-4-J36DGbkkmi@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61647-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61647-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg02343.txt.bz2
Content-length: 532

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61647

Daniel Krügler <daniel.kruegler at googlemail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.kruegler@googlemail.
                   |                            |com

--- Comment #1 from Daniel Krügler <daniel.kruegler at googlemail dot com> ---
The ICE still exists on gcc 4.10.0 20140628 (experimental)
>From gcc-bugs-return-455262-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Jun 29 10:54:48 2014
Return-Path: <gcc-bugs-return-455262-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23433 invoked by alias); 29 Jun 2014 10:54:47 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23383 invoked by uid 48); 29 Jun 2014 10:54:43 -0000
From: "lh_mouse at 126 dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/61645] forward_list::splice_after shall not throw exceptions
Date: Sun, 29 Jun 2014 10:54:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: minor
X-Bugzilla-Who: lh_mouse at 126 dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61645-4-KRsEBsppr9@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61645-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61645-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg02344.txt.bz2
Content-length: 547

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61645

--- Comment #2 from lh_mouse <lh_mouse at 126 dot com> ---
(In reply to Daniel Krügler from comment #1)
> "Throws: Nothing" does not impose the requirement onto implementations that
> such a function is required to be marked equivalent to noexcept(true), so
> this looks more like an enhancement request to me - but let's wait what
> Jonathan or Pablo have to say.

Replace forward_list with list, splice_after with splice and before_begin with
begin, all three static_assert's hold.
>From gcc-bugs-return-455263-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Jun 29 10:56:09 2014
Return-Path: <gcc-bugs-return-455263-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 24860 invoked by alias); 29 Jun 2014 10:56:09 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 24803 invoked by uid 48); 29 Jun 2014 10:56:02 -0000
From: "daniel.kruegler at googlemail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/61645] forward_list::splice_after shall not throw exceptions
Date: Sun, 29 Jun 2014 10:56:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: minor
X-Bugzilla-Who: daniel.kruegler at googlemail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61645-4-bF4Rwfyko1@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61645-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61645-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg02345.txt.bz2
Content-length: 357

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61645

--- Comment #3 from Daniel Krügler <daniel.kruegler at googlemail dot com> ---
(In reply to lh_mouse from comment #2)
> Replace forward_list with list, splice_after with splice and before_begin
> with begin, all three static_assert's hold.

Presumably this provides an consistency argument, yes.
>From gcc-bugs-return-455264-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Jun 29 11:36:53 2014
Return-Path: <gcc-bugs-return-455264-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 20593 invoked by alias); 29 Jun 2014 11:36:53 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 20452 invoked by uid 48); 29 Jun 2014 11:36:46 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/61627] specification expression ICE with version 4.7.1 and 4.8.2, incorrect output with 4.4.7 and 4.9.0
Date: Sun, 29 Jun 2014 11:36:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on everconfirmed
Message-ID: <bug-61627-4-DDEmPMIrXk@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61627-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61627-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg02346.txt.bz2
Content-length: 662

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida627

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-06-29
     Ever confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Revision r206658 (2014-01-16) gives the ICE and r206880 (2014-01-21) gives the
wrong code. The revisions in this range are r206759 and r206786, but they seem
unrelated to this PR.

[Bug libstdc++/61645] forward_list::splice_after shall not throw exceptions

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61645

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Definitely not a bug, marking as enhancement.

[Bug libstdc++/61645] forward_list::splice_after shall not throw exceptions

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61645

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-04-08
   Target Milestone|---                         |6.0
     Ever confirmed|0                           |1

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Definitely not a bug, but we might as well add the noexcept.

[Bug libstdc++/61645] forward_list::splice_after shall not throw exceptions

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61645

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Tue Apr 28 13:05:33 2015
New Revision: 222525

URL: https://gcc.gnu.org/viewcvs?rev=222525&root=gcc&view=rev
Log:
        PR libstdc++/61645
        * include/bits/forward_list.h (forward_list::splice_after): Add
        noexcept.
        * include/bits/forward_list.tcc (forward_list::splice_after):
        Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/forward_list.h
    trunk/libstdc++-v3/include/bits/forward_list.tcc