[Bug c++/61649] New: fixincludes update for solaris___restrict in sys/feature_tests.h on Illumos

[Bug c++/61649] New: fixincludes update for solaris___restrict in sys/feature_tests.h on Illumos

[richard at netbsd dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61649

            Bug ID: 61649
           Summary: fixincludes update for solaris___restrict in
                    sys/feature_tests.h on Illumos
           Product: gcc
           Version: 4.7.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: richard at netbsd dot org

Created attachment 33031
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33031&action=edit
patch to existing fixincludes/inclhack.def from gcc-4.7.3

Due to an update to sys/feature_tests.h as indicated here
(https://illumos.org/issues/2941), Illumos has "broken" the fixincludes
solaris___restrict hack as is evident by the current result in
$PREFIX/gcc47/lib/.../include-fixed/sys/feature_tests.h

/*
 * The following macro defines a value for the ISO C99 restrict
 * keyword so that _RESTRICT_KYWD resolves to "restrict" if
 * an ISO C99 compiler is used and "" (null string) if any other
 * compiler is used. This allows for the use of single prototype
 * declarations regardless of compiler version.
 */
#if (defined(__STDC__) && defined(_STDC_C99)) && !defined(__cplusplus)
#ifdef __cplusplus
#define    _RESTRICT_KYWD    __restrict
#else
#define    _RESTRICT_KYWD    restrict
#endif
#else
#define    _RESTRICT_KYWD
#endif


The attached patch seem to work around this by allowing both the standard and
the Illumos forms to be updated.

The test/base/sys/feature_tests.h patch is as follows:
--- fixincludes/tests/base/sys/feature_tests.h.orig    2010-06-21
15:27:29.000000000 +0000
+++ fixincludes/tests/base/sys/feature_tests.h
@@ -10,6 +10,7 @@


 #if defined( SOLARIS___RESTRICT_CHECK )
+#if (defined(__STDC__) && defined(_STDC_C99))
 #ifdef __cplusplus
 #define    _RESTRICT_KYWD    __restrict
 #else

[Bug c++/61649] fixincludes update for solaris___restrict in sys/feature_tests.h on Illumos

[richard at netbsd dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61649

--- Comment #1 from Richard PALO <richard at netbsd dot org> ---
given https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52168,
it seems necessary to update the test_text line with a newline appended
as follows so that check.sh doesn't balk:
>+    test_text = "#if (defined(__STDC__) && defined(_STDC_C99))\n"
>+    	        "#define	_RESTRICT_KYWD	restrict";
>From gcc-bugs-return-468049-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Nov 22 11:01:35 2014
Return-Path: <gcc-bugs-return-468049-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22634 invoked by alias); 22 Nov 2014 11:01:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 22581 invoked by uid 48); 22 Nov 2014 11:01:31 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/63852] [5 regression] acats failures on x86_64-apple-darwin14
Date: Sat, 22 Nov 2014 11:01:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cf_gcctarget bug_status cf_reconfirmed_on cf_gcchost short_desc everconfirmed cf_gccbuild
Message-ID: <bug-63852-4-dU3dIKfX92@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63852-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63852-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg02521.txt.bz2
Content-length: 962

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc852

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|x86_64-apple-darwin14       |x86_64-apple-darwin1*
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-11-22
               Host|x86_64-apple-darwin14       |x86_64-apple-darwin1*
            Summary|[5.0 regression] acats      |[5 regression] acats
                   |failures on                 |failures on
                   |x86_64-apple-darwin14       |x86_64-apple-darwin14
     Ever confirmed|0                           |1
              Build|x86_64-apple-darwin14       |x86_64-apple-darwin1*

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Still present at r217951 and also seen on x86_64-apple-darwin10.

[Bug c++/61649] fixincludes update for solaris___restrict in sys/feature_tests.h on Illumos

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61649

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |korbb at gcc dot gnu.org

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Richard PALO from comment #0)
> 
> The test/base/sys/feature_tests.h patch is as follows:
> --- fixincludes/tests/base/sys/feature_tests.h.orig	2010-06-21
> 15:27:29.000000000 +0000
> +++ fixincludes/tests/base/sys/feature_tests.h
> @@ -10,6 +10,7 @@
>  
>  
>  #if defined( SOLARIS___RESTRICT_CHECK )
> +#if (defined(__STDC__) && defined(_STDC_C99))
>  #ifdef __cplusplus
>  #define	_RESTRICT_KYWD	__restrict
>  #else

Shouldn't there be a corresponding #endif added to that file?
>From gcc-bugs-return-468497-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Nov 25 12:05:50 2014
Return-Path: <gcc-bugs-return-468497-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 12292 invoked by alias); 25 Nov 2014 12:05:49 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 12255 invoked by uid 55); 25 Nov 2014 12:05:45 -0000
From: "ro at CeBiTec dot Uni-Bielefeld.DE" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/64054] 27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc FAILs
Date: Tue, 25 Nov 2014 12:05:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ro at CeBiTec dot Uni-Bielefeld.DE
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64054-4-Sm01J24m2K@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64054-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64054-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg02969.txt.bz2
Content-length: 518

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd054

--- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
> Doh, so it is, I misread the test code.
>
> Rainer, what does this print (when compiled with -std=c++11)?
>
> #include <string>
> #include <stdio.h>
>
> int main()
> {
>   auto d = std::stod("0x1.1000000000000p+8");
>   printf("%f %a\n", d, d);
> }

I get

0.000000 0x0.0000000000000p+0

    Rainer

[Bug c++/61649] fixincludes update for solaris___restrict in sys/feature_tests.h on Illumos

[richard at netbsd dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61649

--- Comment #3 from Richard PALO <richard at netbsd dot org> ---
No. Prior to fixincludes, sys/feature_tests.h in SunOS looks like the
following:

#if (defined(__STDC__) && defined(_STDC_C99))
#define _RESTRICT_KYWD  restrict
#else
#define _RESTRICT_KYWD
#endif


Illumos has since https://www.illumos.org/issues/2941 the following:

#if (defined(__STDC__) && defined(_STDC_C99)) && !defined(__cplusplus)
#define _RESTRICT_KYWD  restrict
#else
#define _RESTRICT_KYWD
#endif


The net effect of my patch is to support both variants in producing the
following:

#if (defined(__STDC__) && defined(_STDC_C99))
#ifdef __cplusplus
#define _RESTRICT_KYWD __restrict
#else
#define _RESTRICT_KYWD  restrict
#endif
#else
#define _RESTRICT_KYWD
#endif

[Bug c++/61649] fixincludes update for solaris___restrict in sys/feature_tests.h on Illumos

[richard at netbsd dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61649

--- Comment #4 from Richard PALO <richard at netbsd dot org> ---


> 
> The test/base/sys/feature_tests.h patch is as follows:
> --- fixincludes/tests/base/sys/feature_tests.h.orig	2010-06-21
> 15:27:29.000000000 +0000
> +++ fixincludes/tests/base/sys/feature_tests.h
> @@ -10,6 +10,7 @@
>  
>  
>  #if defined( SOLARIS___RESTRICT_CHECK )
> +#if (defined(__STDC__) && defined(_STDC_C99))
>  #ifdef __cplusplus
>  #define	_RESTRICT_KYWD	__restrict
>  #else


Perhaps I should remind as well that the file is a diff with only a certain
number of lines as context... so in that respect, it isn't necessary either.
>From gcc-bugs-return-468501-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Nov 25 12:41:48 2014
Return-Path: <gcc-bugs-return-468501-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 30963 invoked by alias); 25 Nov 2014 12:41:47 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 30907 invoked by uid 48); 25 Nov 2014 12:41:43 -0000
From: "enkovich.gnu at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/63995] Bootstrap error with -mmpx -fcheck-pointer-bounds
Date: Tue, 25 Nov 2014 12:41:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: enkovich.gnu at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63995-4-LU0efiY8ll@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63995-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63995-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-11/txt/msg02973.txt.bz2
Content-length: 420

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc995

--- Comment #3 from Ilya Enkovich <enkovich.gnu at gmail dot com> ---
Patch removing duplicating bounds symbols is in review.  With this patch
applied bootstrap goes till the end but there are lots of stage2 and stage3
comparison error.  I looked into one of them and the difference is caused by
'-gtoggle' option used for stage2 build and not used for stage3 build.

[Bug c++/61649] fixincludes update for solaris___restrict in sys/feature_tests.h on Illumos

[richard at netbsd dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61649

--- Comment #5 from Richard PALO <richard at netbsd dot org> ---
kind reminder to push these two patches:
1) https://gcc.gnu.org/bugzilla/attachment.cgi?id=33031
2) and https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61649#c1 (*)
* NB https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52168

I believe I already answered Jonathan's question in that since
only a [preceeding] line of context is being added, there is no
additional '#endif' to add.

BTW, this line of context is necessary anyway, because if either
Oracle Solaris or Illumos change this code section, for example by 
fixing it as gcc currently does here, it will prevent fixincl.x from
action which would actually *break* the file.