* [Bug libstdc++/61667] setting max_load_factor of unordered_map cause buckets shrink
2014-07-02 9:10 [Bug libstdc++/61667] New: setting max_load_factor of unordered_map cause buckets shrink tinrow at gmail dot com
@ 2014-07-02 9:43 ` redi at gcc dot gnu.org
2014-07-23 20:07 ` fdumont at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-07-02 9:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61667
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2014-07-02
CC| |fdumont at gcc dot gnu.org
Version|unknown |4.8.2
Ever confirmed|0 |1
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
François, why does __rehash_policy check for inequality?
if (__n_bkt != _M_bucket_count)
_M_rehash(__n_bkt, _M_rehash_policy._M_state());
Is there any reason not to change that to:
if (__n_bkt > _M_bucket_count)
_M_rehash(__n_bkt, _M_rehash_policy._M_state());
>From gcc-bugs-return-455483-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jul 02 09:45:08 2014
Return-Path: <gcc-bugs-return-455483-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 7857 invoked by alias); 2 Jul 2014 09:45:07 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 7699 invoked by uid 48); 2 Jul 2014 09:44:58 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/61668] Division returns an error in some cases
Date: Wed, 02 Jul 2014 09:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: critical
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-61668-4-V2FvQYcAiG@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61668-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61668-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-07/txt/msg00074.txt.bz2
Content-length: 512
https://gcc.gnu.org/bugzilla/show_bug.cgi?ida668
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |INVALID
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Floating point numbers are not exact. 0.59 cannot be exactly represented in a
64-bit double.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/61667] setting max_load_factor of unordered_map cause buckets shrink
2014-07-02 9:10 [Bug libstdc++/61667] New: setting max_load_factor of unordered_map cause buckets shrink tinrow at gmail dot com
2014-07-02 9:43 ` [Bug libstdc++/61667] " redi at gcc dot gnu.org
@ 2014-07-23 20:07 ` fdumont at gcc dot gnu.org
2014-08-09 8:01 ` fdumont at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: fdumont at gcc dot gnu.org @ 2014-07-23 20:07 UTC (permalink / raw)
To: gcc-bugs
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 3731 bytes --]
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61667
François Dumont <fdumont at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |fdumont at gcc dot gnu.org
--- Comment #2 from François Dumont <fdumont at gcc dot gnu.org> ---
I just wanted to give a way to shrink unordered containers representation
through a rehash call as long as it was Standard compliant, and it is I think.
Even the classic copy and swap won't work on this type of container. Having it
shrink on call to max_load_factor was also plan but I must confess that in the
provided code it is quite inconvenient.
An easy workaround is to call m.reserve(200000) after the call to
max_load_factor.
I can change the code to limit the shink behavior to rehash calls or I can
change it to do as you propose Jonathan allowing no shrinking except by
rebuilding a new instance from an iterator range and then swap.
>From gcc-bugs-return-456990-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jul 23 20:17:18 2014
Return-Path: <gcc-bugs-return-456990-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 10306 invoked by alias); 23 Jul 2014 20:17:17 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 10246 invoked by uid 48); 23 Jul 2014 20:17:10 -0000
From: "zsojka at seznam dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/61890] New: [4.10 Regression] g++.dg/ipa/devirt-23.C FAILs with -O2 -fno-devirtualize-speculatively -fno-guess-branch-probability
Date: Wed, 23 Jul 2014 20:17:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: zsojka at seznam dot cz
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter attachments.created
Message-ID: <bug-61890-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-07/txt/msg01581.txt.bz2
Content-length: 820
https://gcc.gnu.org/bugzilla/show_bug.cgi?ida890
Bug ID: 61890
Summary: [4.10 Regression] g++.dg/ipa/devirt-23.C FAILs with
-O2 -fno-devirtualize-speculatively
-fno-guess-branch-probability
Product: gcc
Version: 4.10.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: ipa
Assignee: unassigned at gcc dot gnu.org
Reporter: zsojka at seznam dot cz
Created attachment 33178
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id3178&actioníit
preprocessed source (g++.dg/ipa/devirt-23.C)
Output:
$ g++ -O2 -fno-devirtualize-speculatively -fno-guess-branch-probability
devirt-23.ii
$ ./a.out
Aborted
Tested revisions:
trunk r212932 - FAIL
4_9 r212703 - OK
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/61667] setting max_load_factor of unordered_map cause buckets shrink
2014-07-02 9:10 [Bug libstdc++/61667] New: setting max_load_factor of unordered_map cause buckets shrink tinrow at gmail dot com
2014-07-02 9:43 ` [Bug libstdc++/61667] " redi at gcc dot gnu.org
2014-07-23 20:07 ` fdumont at gcc dot gnu.org
@ 2014-08-09 8:01 ` fdumont at gcc dot gnu.org
2014-08-09 10:19 ` fdumont at gcc dot gnu.org
2014-08-10 0:45 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: fdumont at gcc dot gnu.org @ 2014-08-09 8:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61667
--- Comment #3 from François Dumont <fdumont at gcc dot gnu.org> ---
Author: fdumont
Date: Sat Aug 9 08:00:59 2014
New Revision: 213775
URL: https://gcc.gnu.org/viewcvs?rev=213775&root=gcc&view=rev
Log:
2014-08-09 François Dumont <fdumont@gcc.gnu.org>
PR libstdc++/61667
* include/bits/hashtable.h (_Hashtable<>::__rehash_policy): Use
_M_need_rehash to initialize the rehash policy and check if a rehash is
needed.
* testsuite/23_containers/unordered_map/modifiers/61667.cc: New.
Added:
trunk/libstdc++-v3/testsuite/23_containers/unordered_map/modifiers/61667.cc
Modified:
trunk/libstdc++-v3/ChangeLog
trunk/libstdc++-v3/include/bits/hashtable.h
>From gcc-bugs-return-458077-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Aug 09 10:13:18 2014
Return-Path: <gcc-bugs-return-458077-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 363 invoked by alias); 9 Aug 2014 10:13:17 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 324 invoked by uid 48); 9 Aug 2014 10:13:06 -0000
From: "trippels at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/62071] [4.10 Regression] ICE: in before_dom_children, at tree-ssa-pre.c:4411
Date: Sat, 09 Aug 2014 10:13:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: trippels at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-62071-4-BsFAaSqjzU@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-62071-4@http.gcc.gnu.org/bugzilla/>
References: <bug-62071-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-08/txt/msg00574.txt.bz2
Content-length: 1429
https://gcc.gnu.org/bugzilla/show_bug.cgi?idb071
--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Apparently unreducible:
delta comes up with:
markus@x4 tmp % cat list
/var/tmp/moz-build-dir/toolkit/library/../../dom/events/EventStateManager.o
/var/tmp/moz-build-dir/toolkit/library/../../dom/events/Unified_cpp_dom_events0.o
/var/tmp/moz-build-dir/toolkit/library/../../dom/events/Unified_cpp_dom_events1.o
/var/tmp/moz-build-dir/toolkit/library/../../dom/events/Unified_cpp_dom_events2.o
/var/tmp/moz-build-dir/toolkit/library/../../dom/xbl/Unified_cpp_dom_xbl0.o
/var/tmp/moz-build-dir/toolkit/library/../../dom/xml/Unified_cpp_dom_xml0.o
/var/tmp/moz-build-dir/toolkit/library/../../widget/xpwidgets/Unified_cpp_widget_xpwidgets0.o
/var/tmp/moz-build-dir/toolkit/library/../../widget/xpwidgets/Unified_cpp_widget_xpwidgets1.o
/var/tmp/moz-build-dir/toolkit/library/../../widget/gtk/nsWidgetFactory.o
/var/tmp/moz-build-dir/toolkit/library/../../widget/gtk/nsDragService.o
/var/tmp/moz-build-dir/toolkit/library/../../content/base/src/nsDocument.o
/var/tmp/moz-build-dir/toolkit/library/../../content/base/src/nsContentUtils.o
/var/tmp/moz-build-dir/toolkit/library/../../layout/base/nsDocumentViewer.o
/var/tmp/moz-build-dir/toolkit/library/../../layout/base/nsPresShell.o
/var/tmp/moz-build-dir/toolkit/library/../../layout/base/Unified_cpp_layout_base1.o
Will try a non-unified build later.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/61667] setting max_load_factor of unordered_map cause buckets shrink
2014-07-02 9:10 [Bug libstdc++/61667] New: setting max_load_factor of unordered_map cause buckets shrink tinrow at gmail dot com
` (2 preceding siblings ...)
2014-08-09 8:01 ` fdumont at gcc dot gnu.org
@ 2014-08-09 10:19 ` fdumont at gcc dot gnu.org
2014-08-10 0:45 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: fdumont at gcc dot gnu.org @ 2014-08-09 10:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61667
--- Comment #4 from François Dumont <fdumont at gcc dot gnu.org> ---
Author: fdumont
Date: Sat Aug 9 10:18:46 2014
New Revision: 213778
URL: https://gcc.gnu.org/viewcvs?rev=213778&root=gcc&view=rev
Log:
2014-08-09 François Dumont <fdumont@gcc.gnu.org>
PR libstdc++/61667
* include/bits/hashtable.h (_Hashtable<>::__rehash_policy): Use
_M_need_rehash to initialize the rehash policy and check if a rehash is
needed.
* testsuite/23_containers/unordered_map/modifiers/61667.cc: New.
Added:
branches/gcc-4_9-branch/libstdc++-v3/testsuite/23_containers/unordered_map/modifiers/61667.cc
Modified:
branches/gcc-4_9-branch/libstdc++-v3/ChangeLog
branches/gcc-4_9-branch/libstdc++-v3/include/bits/hashtable.h
>From gcc-bugs-return-458079-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Aug 09 10:21:37 2014
Return-Path: <gcc-bugs-return-458079-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 9245 invoked by alias); 9 Aug 2014 10:21:37 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9210 invoked by uid 48); 9 Aug 2014 10:21:34 -0000
From: "fdumont at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/61667] setting max_load_factor of unordered_map cause buckets shrink
Date: Sat, 09 Aug 2014 10:21:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: fdumont at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: fdumont at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution target_milestone
Message-ID: <bug-61667-4-mX6lZ15Gu4@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61667-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61667-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-08/txt/msg00576.txt.bz2
Content-length: 572
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61667
François Dumont <fdumont at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |4.10.0
--- Comment #5 from François Dumont <fdumont at gcc dot gnu.org> ---
As said on the mailing list bug is confirmed and fixed in trunk and 4.9 branch.
>From gcc-bugs-return-458080-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Aug 09 12:31:33 2014
Return-Path: <gcc-bugs-return-458080-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 25253 invoked by alias); 9 Aug 2014 12:31:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 25221 invoked by uid 48); 9 Aug 2014 12:31:26 -0000
From: "maciej at opencsw dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/61303] gccgo: segfault, regression since 4.8.2
Date: Sat, 09 Aug 2014 12:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: go
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: maciej at opencsw dot org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ian at airs dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61303-4-UxDWqpSCXa@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61303-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61303-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-08/txt/msg00577.txt.bz2
Content-length: 389
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61303
--- Comment #4 from Maciej Bliziński <maciej at opencsw dot org> ---
Just checked on Linux 3.13.0 x86_64, gccgo 4.9.0, works fine. gccgo version:
$ gccgo --version
gccgo (Ubuntu 4.9-20140406-0ubuntu1) 4.9.0 20140405 (experimental) [trunk
revision 209157]
In the meantime, I keep working with gccgo 4.8.2, which also works fine.
>From gcc-bugs-return-458081-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Aug 09 13:24:25 2014
Return-Path: <gcc-bugs-return-458081-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 14367 invoked by alias); 9 Aug 2014 13:24:24 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 14336 invoked by uid 48); 9 Aug 2014 13:24:15 -0000
From: "tkoenig at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/61999] [4.8/4.9/4.10 Regression] `gfc_simplify_dot_product` causes ICE for constant arguments
Date: Sat, 09 Aug 2014 13:24:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tkoenig at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-61999-4-8oGzZ4beAx@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61999-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61999-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-08/txt/msg00578.txt.bz2
Content-length: 1228
https://gcc.gnu.org/bugzilla/show_bug.cgi?ida999
Thomas Koenig <tkoenig at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tkoenig at gcc dot gnu.org
--- Comment #3 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
This seems to work OK:
Index: simplify.c
==================================================================--- simplify.c (Revision 212761)
+++ simplify.c (Arbeitskopie)
@@ -1882,6 +1882,9 @@
gfc_expr*
gfc_simplify_dot_product (gfc_expr *vector_a, gfc_expr *vector_b)
{
+
+ gfc_expr temp;
+
if (!is_constant_array_expr (vector_a)
|| !is_constant_array_expr (vector_b))
return NULL;
@@ -1888,8 +1891,14 @@
gcc_assert (vector_a->rank == 1);
gcc_assert (vector_b->rank == 1);
- gcc_assert (gfc_compare_types (&vector_a->ts, &vector_b->ts));
+ temp.expr_type = EXPR_OP;
+ gfc_clear_ts (&temp.ts);
+ temp.value.op.op = INTRINSIC_NONE;
+ temp.value.op.op1 = vector_a;
+ temp.value.op.op2 = vector_b;
+ gfc_type_convert_binary (&temp, 1);
+
return compute_dot_product (vector_a, 1, 0, vector_b, 1, 0, true);
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/61667] setting max_load_factor of unordered_map cause buckets shrink
2014-07-02 9:10 [Bug libstdc++/61667] New: setting max_load_factor of unordered_map cause buckets shrink tinrow at gmail dot com
` (3 preceding siblings ...)
2014-08-09 10:19 ` fdumont at gcc dot gnu.org
@ 2014-08-10 0:45 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2014-08-10 0:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61667
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.10.0 |4.9.2
^ permalink raw reply [flat|nested] 6+ messages in thread