public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug rtl-optimization/61672] New: Less redundant instructions deleted by pre_delete after r208113.
@ 2014-07-02 14:17 ysrumyan at gmail dot com
2014-08-04 11:08 ` [Bug rtl-optimization/61672] " ysrumyan at gmail dot com
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: ysrumyan at gmail dot com @ 2014-07-02 14:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61672
Bug ID: 61672
Summary: Less redundant instructions deleted by pre_delete
after r208113.
Product: gcc
Version: 4.10.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: rtl-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: ysrumyan at gmail dot com
In real application which is compiled with restrictions on frame size after
r208113 number of deleted redundant instruction decreased significantly:
3744 vs 247 and we assume that this is the reason of frame size increasing.
I reproduced this regression using gcc/testsuite/g++.dg/torture/pr58464 for
which we have 8(before fix) vs 4.
r208113 | rguenth | 2014-02-25 12:59:10 +0400 (Tue, 25 Feb 2014) | 10 lines
Changed paths:
M /trunk/gcc/ChangeLog
M /trunk/gcc/emit-rtl.c
2014-02-25 Richard Biener <rguenther@suse.de>
PR middle-end/60291 •emit-rtl.c (mem_attrs_htab): Remove.
(mem_attrs_htab_hash): Likewise.
(mem_attrs_htab_eq): Likewise.
(set_mem_attrs): Always allocate new mem-attrs when something
changed.
(init_emit_once): Do not allocate mem_attrs_htab.
>From gcc-bugs-return-455510-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Jul 02 14:24:50 2014
Return-Path: <gcc-bugs-return-455510-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6670 invoked by alias); 2 Jul 2014 14:24:49 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6460 invoked by uid 55); 2 Jul 2014 14:24:38 -0000
From: "ian at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/61620] FAIL: go.test/test/fixedbugs/bug242.go execution, -O2 -g
Date: Wed, 02 Jul 2014 14:24:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: go
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ian at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ian at airs dot com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61620-4-S78FXj012L@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61620-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61620-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-07/txt/msg00101.txt.bz2
Content-length: 497
https://gcc.gnu.org/bugzilla/show_bug.cgi?ida620
--- Comment #1 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Wed Jul 2 14:23:45 2014
New Revision: 212233
URL: https://gcc.gnu.org/viewcvs?rev!2233&root=gcc&view=rev
Log:
PR go/61620
runtime: Don't free tiny blocks in map deletion.
The memory allocator now has a special case for tiny blocks
(smaller than 16 bytes) and they can not be explicitly freed.
Modified:
trunk/libgo/runtime/go-map-delete.c
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/61672] Less redundant instructions deleted by pre_delete after r208113.
2014-07-02 14:17 [Bug rtl-optimization/61672] New: Less redundant instructions deleted by pre_delete after r208113 ysrumyan at gmail dot com
@ 2014-08-04 11:08 ` ysrumyan at gmail dot com
2014-08-04 11:16 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ysrumyan at gmail dot com @ 2014-08-04 11:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61672
--- Comment #1 from Yuri Rumyantsev <ysrumyan at gmail dot com> ---
Any comments will be appreciated.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/61672] Less redundant instructions deleted by pre_delete after r208113.
2014-07-02 14:17 [Bug rtl-optimization/61672] New: Less redundant instructions deleted by pre_delete after r208113 ysrumyan at gmail dot com
2014-08-04 11:08 ` [Bug rtl-optimization/61672] " ysrumyan at gmail dot com
@ 2014-08-04 11:16 ` rguenth at gcc dot gnu.org
2014-08-04 12:03 ` ysrumyan at gmail dot com
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-08-04 11:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61672
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rguenth at gcc dot gnu.org
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
This only changes the way we represent mem_attrs. It seems to me that
eventually mem_attr comparison doesn't work as expected? Note sure where PRE
looks at
the stmts - LCM looks like bitmap stuff only, I only see canon_true_dependence
calls that may make a difference.
Also please specify the target you used to reproduce this.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/61672] Less redundant instructions deleted by pre_delete after r208113.
2014-07-02 14:17 [Bug rtl-optimization/61672] New: Less redundant instructions deleted by pre_delete after r208113 ysrumyan at gmail dot com
2014-08-04 11:08 ` [Bug rtl-optimization/61672] " ysrumyan at gmail dot com
2014-08-04 11:16 ` rguenth at gcc dot gnu.org
@ 2014-08-04 12:03 ` ysrumyan at gmail dot com
2014-08-04 12:16 ` ysrumyan at gmail dot com
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ysrumyan at gmail dot com @ 2014-08-04 12:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61672
--- Comment #3 from Yuri Rumyantsev <ysrumyan at gmail dot com> ---
Created attachment 33235
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33235&action=edit
file to reproduce
Need to be compiled with
-m32 -O3 -Wframe-larger-than=1728 -std=gnu++11 -fpic
options.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/61672] Less redundant instructions deleted by pre_delete after r208113.
2014-07-02 14:17 [Bug rtl-optimization/61672] New: Less redundant instructions deleted by pre_delete after r208113 ysrumyan at gmail dot com
` (2 preceding siblings ...)
2014-08-04 12:03 ` ysrumyan at gmail dot com
@ 2014-08-04 12:16 ` ysrumyan at gmail dot com
2014-08-04 12:59 ` [Bug rtl-optimization/61672] [4.9/4.10 Regression] " rguenth at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ysrumyan at gmail dot com @ 2014-08-04 12:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61672
--- Comment #5 from Yuri Rumyantsev <ysrumyan at gmail dot com> ---
Richard,
I put the original file into 61672 attachment and add comments for
reproducing.
2014-08-04 15:16 GMT+04:00 rguenth at gcc dot gnu.org
<gcc-bugzilla@gcc.gnu.org>:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61672
>
> Richard Biener <rguenth at gcc dot gnu.org> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> CC| |rguenth at gcc dot gnu.org
>
> --- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
> This only changes the way we represent mem_attrs. It seems to me that
> eventually mem_attr comparison doesn't work as expected? Note sure where PRE
> looks at
> the stmts - LCM looks like bitmap stuff only, I only see canon_true_dependence
> calls that may make a difference.
>
> Also please specify the target you used to reproduce this.
>
> --
> You are receiving this mail because:
> You reported the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/61672] [4.9/4.10 Regression] Less redundant instructions deleted by pre_delete after r208113.
2014-07-02 14:17 [Bug rtl-optimization/61672] New: Less redundant instructions deleted by pre_delete after r208113 ysrumyan at gmail dot com
` (3 preceding siblings ...)
2014-08-04 12:16 ` ysrumyan at gmail dot com
@ 2014-08-04 12:59 ` rguenth at gcc dot gnu.org
2014-08-05 13:05 ` [Bug rtl-optimization/61672] [4.9 " rguenth at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-08-04 12:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61672
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |missed-optimization
Target Milestone|--- |4.9.2
Summary|Less redundant instructions |[4.9/4.10 Regression] Less
|deleted by pre_delete after |redundant instructions
|r208113. |deleted by pre_delete after
| |r208113.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/61672] [4.9 Regression] Less redundant instructions deleted by pre_delete after r208113.
2014-07-02 14:17 [Bug rtl-optimization/61672] New: Less redundant instructions deleted by pre_delete after r208113 ysrumyan at gmail dot com
` (4 preceding siblings ...)
2014-08-04 12:59 ` [Bug rtl-optimization/61672] [4.9/4.10 Regression] " rguenth at gcc dot gnu.org
@ 2014-08-05 13:05 ` rguenth at gcc dot gnu.org
2014-09-09 11:43 ` rguenth at gcc dot gnu.org
2014-09-09 11:44 ` rguenth at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-08-05 13:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61672
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.9/4.10 Regression] Less |[4.9 Regression] Less
|redundant instructions |redundant instructions
|deleted by pre_delete after |deleted by pre_delete after
|r208113. |r208113.
Known to fail| |4.9.1
--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/61672] [4.9 Regression] Less redundant instructions deleted by pre_delete after r208113.
2014-07-02 14:17 [Bug rtl-optimization/61672] New: Less redundant instructions deleted by pre_delete after r208113 ysrumyan at gmail dot com
` (5 preceding siblings ...)
2014-08-05 13:05 ` [Bug rtl-optimization/61672] [4.9 " rguenth at gcc dot gnu.org
@ 2014-09-09 11:43 ` rguenth at gcc dot gnu.org
2014-09-09 11:44 ` rguenth at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-09-09 11:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61672
--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Tue Sep 9 11:42:34 2014
New Revision: 215059
URL: https://gcc.gnu.org/viewcvs?rev=215059&root=gcc&view=rev
Log:
2014-09-09 Richard Biener <rguenther@suse.de>
Backport from mainline
2014-08-05 Richard Biener <rguenther@suse.de>
PR rtl-optimization/61672
* emit-rtl.h (mem_attrs_eq_p): Declare.
* emit-rtl.c (mem_attrs_eq_p): Export. Handle NULL mem-attrs.
* cse.c (exp_equiv_p): Use mem_attrs_eq_p.
* cfgcleanup.c (merge_memattrs): Likewise.
Include emit-rtl.h.
2014-08-11 Richard Biener <rguenther@suse.de>
PR tree-optimization/62075
* tree-vect-slp.c (vect_detect_hybrid_slp_stmts): Properly
handle uses in patterns.
* gcc.dg/vect/pr62075.c: New testcase.
2014-08-14 Richard Biener <rguenther@suse.de>
PR rtl-optimization/62079
* recog.c (peephole2_optimize): If peep2_do_cleanup_cfg
run cleanup_cfg.
* g++.dg/pr62079.C: New testcase.
2014-08-26 Richard Biener <rguenther@suse.de>
PR tree-optimization/62175
* tree-ssa-loop-niter.c (expand_simple_operations): Do not
expand possibly trapping operations.
* g++.dg/torture/pr62175.C: New testcase.
Added:
branches/gcc-4_9-branch/gcc/testsuite/g++.dg/pr62079.C
branches/gcc-4_9-branch/gcc/testsuite/g++.dg/torture/pr62175.C
branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/vect/pr62075.c
Modified:
branches/gcc-4_9-branch/gcc/ChangeLog
branches/gcc-4_9-branch/gcc/cfgcleanup.c
branches/gcc-4_9-branch/gcc/cse.c
branches/gcc-4_9-branch/gcc/emit-rtl.c
branches/gcc-4_9-branch/gcc/recog.c
branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
branches/gcc-4_9-branch/gcc/tree-ssa-loop-niter.c
branches/gcc-4_9-branch/gcc/tree-vect-slp.c
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug rtl-optimization/61672] [4.9 Regression] Less redundant instructions deleted by pre_delete after r208113.
2014-07-02 14:17 [Bug rtl-optimization/61672] New: Less redundant instructions deleted by pre_delete after r208113 ysrumyan at gmail dot com
` (6 preceding siblings ...)
2014-09-09 11:43 ` rguenth at gcc dot gnu.org
@ 2014-09-09 11:44 ` rguenth at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-09-09 11:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61672
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-09-09 11:44 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-02 14:17 [Bug rtl-optimization/61672] New: Less redundant instructions deleted by pre_delete after r208113 ysrumyan at gmail dot com
2014-08-04 11:08 ` [Bug rtl-optimization/61672] " ysrumyan at gmail dot com
2014-08-04 11:16 ` rguenth at gcc dot gnu.org
2014-08-04 12:03 ` ysrumyan at gmail dot com
2014-08-04 12:16 ` ysrumyan at gmail dot com
2014-08-04 12:59 ` [Bug rtl-optimization/61672] [4.9/4.10 Regression] " rguenth at gcc dot gnu.org
2014-08-05 13:05 ` [Bug rtl-optimization/61672] [4.9 " rguenth at gcc dot gnu.org
2014-09-09 11:43 ` rguenth at gcc dot gnu.org
2014-09-09 11:44 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).