[Bug bootstrap/61679] build fails with G++ 4.5.1 - prototype for hash_table does not match any in class

[Bug bootstrap/61679] build fails with G++ 4.5.1 - prototype for hash_table does not match any in class

[gary at intrepid dot com]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 8895 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61679

--- Comment #2 from Gary Funck <gary at intrepid dot com> ---
(In reply to Trevor Saunders from comment #1)
> The following patch compiles with 4.9 for me, but I don't have easy
> access to a machine with 4.5 on it, would you mind testing if it works
> for you?

Applied the patch to r212302 (2014-07-04), however, still seeing compilation
failure:


/a/gcc-4.5.1/bld/rls/bin/g++ -c  -DIN_GCC_FRONTEND -DIN_GCC_FRONTEND
-DIN_GCC_FRONTEND -O0 -g3 -DIN_GCC    -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual
-Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I.
-I. -I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc
-I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/.
-I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/../include
-I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/../libcpp/include 
-I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/../libdecnumber
-I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/../libdecnumber/bid
-I../libdecnumber -I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/../libbacktrace   
-o attribs.o -MT attribs.o -MMD -MP -MF ./.deps/attribs.TPo
/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/attribs.c
In file included from /eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/attribs.c:35:0:
/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/hash-table.h:845:1: error: prototype
for ‘typename Descriptor::value_type** hash_table<Descriptor, Allocator,
false>::find_slot_with_hash(hash_table<Descriptor, Allocator,
false>::compare_type*, hashval_t, insert_option)’ does not match any in class
‘hash_table<Descriptor, Allocator, false>’
/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/hash-table.h:542:16: error: candidate
is: hash_table<Descriptor, Allocator, false>::value_type**
hash_table<Descriptor, Allocator,
false>::find_slot_with_hash(hash_table<Descriptor, Allocator,
false>::compare_type*, hashval_t, insert_option)
/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/hash-table.h:927:1: error: prototype
for ‘void hash_table<Descriptor, Allocator,
false>::traverse_noresize(Argument)’ does not match any in class
‘hash_table<Descriptor, Allocator, false>’
[...]
>From gcc-bugs-return-455709-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Jul 05 20:47:17 2014
Return-Path: <gcc-bugs-return-455709-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 31833 invoked by alias); 5 Jul 2014 20:47:15 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 31690 invoked by uid 55); 5 Jul 2014 20:47:04 -0000
From: "tsaunders at mozilla dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/61679] build fails with G++ 4.5.1 - prototype for hash_table does not match any in class
Date: Sat, 05 Jul 2014 20:47:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tsaunders at mozilla dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61679-4-75Vnn3QjMR@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61679-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61679-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-07/txt/msg00300.txt.bz2
Content-length: 2769

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61679

--- Comment #3 from Trevor Saunders <tsaunders at mozilla dot com> ---
> (In reply to Trevor Saunders from comment #1)
> > The following patch compiles with 4.9 for me, but I don't have easy
> > access to a machine with 4.5 on it, would you mind testing if it works
> > for you?
> 
> Applied the patch to r212302 (2014-07-04), however, still seeing compilation
> failure:

Well, you didn't mention those errors in the original description, so I
didn't try and fix them.  Is the below list complete? I'd expect to see
errors for the partial specialization for true as well.

> /a/gcc-4.5.1/bld/rls/bin/g++ -c  -DIN_GCC_FRONTEND -DIN_GCC_FRONTEND
> -DIN_GCC_FRONTEND -O0 -g3 -DIN_GCC    -fno-exceptions -fno-rtti
> -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual
> -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long
> -Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I.
> -I. -I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc
> -I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/.
> -I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/../include
> -I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/../libcpp/include 
> -I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/../libdecnumber
> -I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/../libdecnumber/bid
> -I../libdecnumber -I/eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/../libbacktrace   
> -o attribs.o -MT attribs.o -MMD -MP -MF ./.deps/attribs.TPo
> /eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/attribs.c
> In file included from /eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/attribs.c:35:0:
> /eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/hash-table.h:845:1: error: prototype
> for ‘typename Descriptor::value_type** hash_table<Descriptor, Allocator,
> false>::find_slot_with_hash(hash_table<Descriptor, Allocator,
> false>::compare_type*, hashval_t, insert_option)’ does not match any in class
> ‘hash_table<Descriptor, Allocator, false>’
> /eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/hash-table.h:542:16: error: candidate
> is: hash_table<Descriptor, Allocator, false>::value_type**
> hash_table<Descriptor, Allocator,
> false>::find_slot_with_hash(hash_table<Descriptor, Allocator,
> false>::compare_type*, hashval_t, insert_option)

You can probably fix this one in the same way as the previous ones.

> /eng/upc/dev/gary/gupc-gcc-trunk/src/gcc/hash-table.h:927:1: error: prototype
> for ‘void hash_table<Descriptor, Allocator,
> false>::traverse_noresize(Argument)’ does not match any in class
> ‘hash_table<Descriptor, Allocator, false>’
> [...]

maybe the same sort of thing will work for this one too, but its hard to
know when the messages are cut off.

Trev
>From gcc-bugs-return-455710-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Jul 05 20:56:28 2014
Return-Path: <gcc-bugs-return-455710-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6340 invoked by alias); 5 Jul 2014 20:56:28 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6218 invoked by uid 48); 5 Jul 2014 20:56:20 -0000
From: "gary at intrepid dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/61679] build fails with G++ 4.5.1 - prototype for hash_table does not match any in class
Date: Sat, 05 Jul 2014 20:56:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: gary at intrepid dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-61679-4-Pz8qaGH28G@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61679-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61679-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-07/txt/msg00301.txt.bz2
Content-length: 239

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida679

--- Comment #4 from Gary Funck <gary at intrepid dot com> ---
Created attachment 33076
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id3076&actioníit
make log after trying patch

[Bug bootstrap/61679] build fails with G++ 4.5.1 - prototype for hash_table does not match any in class

[gary at intrepid dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61679

--- Comment #5 from Gary Funck <gary at intrepid dot com> ---
(In reply to Trevor Saunders from comment #3)
> Is the below list complete? I'd expect to see
> errors for the partial specialization for true as well.

Attached the full make log.

[Bug bootstrap/61679] build fails with G++ 4.5.1 - prototype for hash_table does not match any in class

[tsaunders at mozilla dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61679

--- Comment #6 from Trevor Saunders <tsaunders at mozilla dot com> ---
> --- Comment #4 from Gary Funck <gary at intrepid dot com> ---
> Created attachment 33076
>   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33076&action=edit
> make log after trying patch

thanks! I think the attached patch should fix all of those issues, would
you mind testing it?

Trev

[Bug bootstrap/61679] build fails with G++ 4.5.1 - prototype for hash_table does not match any in class

[gary at intrepid dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61679

--- Comment #7 from Gary Funck <gary at intrepid dot com> ---
(In reply to Trevor Saunders from comment #6)
> thanks! I think the attached patch should fix all of those issues, would
> you mind testing it?

Confirmed.  With that patch, the stage1 compiler compiled successfully
using g++ 4.5.1.

[Bug bootstrap/61679] build fails with G++ 4.5.1 - prototype for hash_table does not match any in class

[tbsaunde at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61679

--- Comment #8 from tbsaunde at gcc dot gnu.org ---
Author: tbsaunde
Date: Wed Jul  9 03:07:09 2014
New Revision: 212384

URL: https://gcc.gnu.org/viewcvs?rev=212384&root=gcc&view=rev
Log:
playcate old gcc

gcc/

    PR bootstrap/61679
     * hash-table.h: use hash_table::value_type instead of
           Descriptor::value_type in the return types of several methods.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/hash-table.h

[Bug bootstrap/61679] build fails with G++ 4.5.1 - prototype for hash_table does not match any in class

[tbsaunde at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61679

tbsaunde at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |tbsaunde at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #9 from tbsaunde at gcc dot gnu.org ---
fixed