[Bug tree-optimization/61684] New: ICE at -Os and above on x86_64-linux-gnu in tree check: expected ssa_name, have addr_expr in recognize_single_bit_test, at tree-ssa-ifcombine.c:238

[Bug tree-optimization/61684] New: ICE at -Os and above on x86_64-linux-gnu in tree check: expected ssa_name, have addr_expr in recognize_single_bit_test, at tree-ssa-ifcombine.c:238

[su at cs dot ucdavis.edu]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 4924 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61684

            Bug ID: 61684
           Summary: ICE at -Os and above on x86_64-linux-gnu in tree
                    check: expected ssa_name, have addr_expr in
                    recognize_single_bit_test, at tree-ssa-ifcombine.c:238
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: su at cs dot ucdavis.edu

The following code causes an ICE when compiled with the current gcc trunk at
-Os and above on x86_64-linux-gnu in 32-bit mode (but not in 64-bit mode). 

It is a regression from 4.9.x. 

$ gcc-trunk -v
Using built-in specs.
COLLECT_GCC=gcc-trunk
COLLECT_LTO_WRAPPER=/usr/local/gcc-trunk/libexec/gcc/x86_64-unknown-linux-gnu/4.10.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc-trunk/configure --prefix=/usr/local/gcc-trunk
--enable-languages=c,c++ --disable-werror --enable-multilib
Thread model: posix
gcc version 4.10.0 20140702 (experimental) [trunk revision 212229] (GCC) 
$ 
$ gcc-trunk -m32 -O1 -c small.c
$ gcc-trunk -m64 -Os -c small.c
$ gcc-4.9 -m32 -Os -c small.c
$ 
$ gcc-trunk -m32 -Os small.c
small.c: In function ‘foo’:
small.c:7:1: internal compiler error: tree check: expected ssa_name, have
addr_expr in recognize_single_bit_test, at tree-ssa-ifcombine.c:238
 foo ()
 ^
0xbc3ef4 tree_check_failed(tree_node const*, char const*, int, char const*,
...)
    ../../gcc-trunk/gcc/tree.c:9220
0xa93780 tree_check(tree_node*, char const*, int, char const*, tree_code)
    ../../gcc-trunk/gcc/tree.h:2731
0xa93780 recognize_single_bit_test
    ../../gcc-trunk/gcc/tree-ssa-ifcombine.c:238
0xa938cb ifcombine_ifandif
    ../../gcc-trunk/gcc/tree-ssa-ifcombine.c:361
0xa95c6d tree_ssa_ifcombine_bb_1
    ../../gcc-trunk/gcc/tree-ssa-ifcombine.c:607
0xa95e30 tree_ssa_ifcombine_bb
    ../../gcc-trunk/gcc/tree-ssa-ifcombine.c:695
0xa95e30 execute
    ../../gcc-trunk/gcc/tree-ssa-ifcombine.c:783
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
$ 


-----------------------------


int a, c;
static int *b = 0;
short d;
static short **e = 0;

void
foo ()
{
  for (; c < 1; c++)
    ;
  *e = &d;
  a = d && (c && 1) & *b;
}
>From gcc-bugs-return-455551-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jul 03 07:51:19 2014
Return-Path: <gcc-bugs-return-455551-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 25569 invoked by alias); 3 Jul 2014 07:51:17 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 25440 invoked by uid 48); 3 Jul 2014 07:51:06 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/61682] [4.10 Regression] wrong code at -O3 on x86_64-linux-gnu
Date: Thu, 03 Jul 2014 07:51:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.10.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-61682-4-ufJ1F8HNvi@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61682-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61682-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-07/txt/msg00142.txt.bz2
Content-length: 582

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida682

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 33057
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id3057&actioníit
gcc410-pr61682.patch

Ugh, there seem to be multiple bugs in wi::mul_internal.
The one that affects this testcase is that MULT_HIGHPART_EXPR of 1 times some
value yields the other value rather than 0 or -1 (depending on sign of the
other operand).

But I don't see how the umul_ppmm optimized cases can handle MULT_HIGHPART_EXPR
or the first umul_ppmm needs_overflow.

[Bug tree-optimization/61684] [4.8/4.9/4.10 Regression] ICE at -Os and above on x86_64-linux-gnu in tree check: expected ssa_name, have addr_expr in recognize_single_bit_test, at tree-ssa-ifcombine.c:238

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61684

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-07-03
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |4.8.4
            Summary|ICE at -Os and above on     |[4.8/4.9/4.10 Regression]
                   |x86_64-linux-gnu in tree    |ICE at -Os and above on
                   |check: expected ssa_name,   |x86_64-linux-gnu in tree
                   |have addr_expr in           |check: expected ssa_name,
                   |recognize_single_bit_test,  |have addr_expr in
                   |at tree-ssa-ifcombine.c:238 |recognize_single_bit_test,
                   |                            |at tree-ssa-ifcombine.c:238
     Ever confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r161655.

[Bug tree-optimization/61684] [4.8/4.9/4.10 Regression] ICE at -Os and above on x86_64-linux-gnu in tree check: expected ssa_name, have addr_expr in recognize_single_bit_test, at tree-ssa-ifcombine.c:238

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61684

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 33059
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33059&action=edit
gcc410-pr61684.patch

Untested fix.

[Bug tree-optimization/61684] [4.8/4.9/4.10 Regression] ICE at -Os and above on x86_64-linux-gnu in tree check: expected ssa_name, have addr_expr in recognize_single_bit_test, at tree-ssa-ifcombine.c:238

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61684

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Fri Jul  4 08:32:56 2014
New Revision: 212290

URL: https://gcc.gnu.org/viewcvs?rev=212290&root=gcc&view=rev
Log:
    PR tree-optimization/61684
    * tree-ssa-ifcombine.c (recognize_single_bit_test): Make sure
    rhs1 of conversion is a SSA_NAME before using SSA_NAME_DEF_STMT on it.

    * gcc.c-torture/compile/pr61684.c: New test.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr61684.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-ifcombine.c

[Bug tree-optimization/61684] [4.8/4.9/4.10 Regression] ICE at -Os and above on x86_64-linux-gnu in tree check: expected ssa_name, have addr_expr in recognize_single_bit_test, at tree-ssa-ifcombine.c:238

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61684

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Fri Jul  4 08:35:20 2014
New Revision: 212291

URL: https://gcc.gnu.org/viewcvs?rev=212291&root=gcc&view=rev
Log:
    PR tree-optimization/61684
    * tree-ssa-ifcombine.c (recognize_single_bit_test): Make sure
    rhs1 of conversion is a SSA_NAME before using SSA_NAME_DEF_STMT on it.

    * gcc.c-torture/compile/pr61684.c: New test.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.c-torture/compile/pr61684.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_9-branch/gcc/tree-ssa-ifcombine.c

[Bug tree-optimization/61684] [4.8/4.9/4.10 Regression] ICE at -Os and above on x86_64-linux-gnu in tree check: expected ssa_name, have addr_expr in recognize_single_bit_test, at tree-ssa-ifcombine.c:238

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61684

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Fri Jul  4 08:37:39 2014
New Revision: 212292

URL: https://gcc.gnu.org/viewcvs?rev=212292&root=gcc&view=rev
Log:
    PR tree-optimization/61684
    * tree-ssa-ifcombine.c (recognize_single_bit_test): Make sure
    rhs1 of conversion is a SSA_NAME before using SSA_NAME_DEF_STMT on it.

    * gcc.c-torture/compile/pr61684.c: New test.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.c-torture/compile/pr61684.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_8-branch/gcc/tree-ssa-ifcombine.c

[Bug tree-optimization/61684] [4.8/4.9/4.10 Regression] ICE at -Os and above on x86_64-linux-gnu in tree check: expected ssa_name, have addr_expr in recognize_single_bit_test, at tree-ssa-ifcombine.c:238

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61684

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.