public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/61686] New: Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c
@ 2014-07-03 12:48 maksqwe1 at ukr dot net
2014-12-10 8:19 ` [Bug tree-optimization/61686] " mpolacek at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: maksqwe1 at ukr dot net @ 2014-07-03 12:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61686
Bug ID: 61686
Summary: Incorrect check in comparison function
range_entry_cmp() in tree_ssa_reassoc.c
Product: gcc
Version: 4.9.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: tree-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: maksqwe1 at ukr dot net
tree_ssa_reassoc.c 2021
range_entry_cmp()
...
if (p->high != NULL_TREE) // <===
{
if (q->high != NULL_TREE)
{
tree tem = fold_binary (LT_EXPR, boolean_type_node,
p->high, q->high);
if (tem && integer_onep (tem))
return -1;
tem = fold_binary (GT_EXPR, boolean_type_node,
p->high, q->high);
if (tem && integer_onep (tem))
return 1;
}
else
return -1;
}
else if (p->high != NULL_TREE) // <===
return 1;
...
I think should be:
if (p->high != NULL_TREE)
...
else if (q->high != NULL_TREE)
return 1;
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/61686] Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c
2014-07-03 12:48 [Bug tree-optimization/61686] New: Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c maksqwe1 at ukr dot net
@ 2014-12-10 8:19 ` mpolacek at gcc dot gnu.org
2014-12-10 8:21 ` mpolacek at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-12-10 8:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61686
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2014-12-10
CC| |mpolacek at gcc dot gnu.org
Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org
Target Milestone|--- |4.8.4
Ever confirmed|0 |1
--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I'm fixing this.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/61686] Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c
2014-07-03 12:48 [Bug tree-optimization/61686] New: Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c maksqwe1 at ukr dot net
2014-12-10 8:19 ` [Bug tree-optimization/61686] " mpolacek at gcc dot gnu.org
@ 2014-12-10 8:21 ` mpolacek at gcc dot gnu.org
2014-12-10 8:24 ` mpolacek at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-12-10 8:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61686
--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Wed Dec 10 08:20:43 2014
New Revision: 218560
URL: https://gcc.gnu.org/viewcvs?rev=218560&root=gcc&view=rev
Log:
PR tree-optimization/61686
* tree-ssa-reassoc.c (range_entry_cmp): Use q->high instead of
p->high.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/tree-ssa-reassoc.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/61686] Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c
2014-07-03 12:48 [Bug tree-optimization/61686] New: Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c maksqwe1 at ukr dot net
2014-12-10 8:19 ` [Bug tree-optimization/61686] " mpolacek at gcc dot gnu.org
2014-12-10 8:21 ` mpolacek at gcc dot gnu.org
@ 2014-12-10 8:24 ` mpolacek at gcc dot gnu.org
2014-12-10 8:30 ` mpolacek at gcc dot gnu.org
2014-12-10 8:31 ` mpolacek at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-12-10 8:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61686
--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Wed Dec 10 08:24:22 2014
New Revision: 218561
URL: https://gcc.gnu.org/viewcvs?rev=218561&root=gcc&view=rev
Log:
PR tree-optimization/61686
* tree-ssa-reassoc.c (range_entry_cmp): Use q->high instead of
p->high.
Modified:
branches/gcc-4_9-branch/gcc/ChangeLog
branches/gcc-4_9-branch/gcc/tree-ssa-reassoc.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/61686] Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c
2014-07-03 12:48 [Bug tree-optimization/61686] New: Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c maksqwe1 at ukr dot net
` (2 preceding siblings ...)
2014-12-10 8:24 ` mpolacek at gcc dot gnu.org
@ 2014-12-10 8:30 ` mpolacek at gcc dot gnu.org
2014-12-10 8:31 ` mpolacek at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-12-10 8:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61686
--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Wed Dec 10 08:29:44 2014
New Revision: 218562
URL: https://gcc.gnu.org/viewcvs?rev=218562&root=gcc&view=rev
Log:
PR tree-optimization/61686
* tree-ssa-reassoc.c (range_entry_cmp): Use q->high instead of
p->high.
Modified:
branches/gcc-4_8-branch/gcc/ChangeLog
branches/gcc-4_8-branch/gcc/tree-ssa-reassoc.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/61686] Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c
2014-07-03 12:48 [Bug tree-optimization/61686] New: Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c maksqwe1 at ukr dot net
` (3 preceding siblings ...)
2014-12-10 8:30 ` mpolacek at gcc dot gnu.org
@ 2014-12-10 8:31 ` mpolacek at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: mpolacek at gcc dot gnu.org @ 2014-12-10 8:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61686
Marek Polacek <mpolacek at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-10 8:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-03 12:48 [Bug tree-optimization/61686] New: Incorrect check in comparison function range_entry_cmp() in tree_ssa_reassoc.c maksqwe1 at ukr dot net
2014-12-10 8:19 ` [Bug tree-optimization/61686] " mpolacek at gcc dot gnu.org
2014-12-10 8:21 ` mpolacek at gcc dot gnu.org
2014-12-10 8:24 ` mpolacek at gcc dot gnu.org
2014-12-10 8:30 ` mpolacek at gcc dot gnu.org
2014-12-10 8:31 ` mpolacek at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).