From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10954 invoked by alias); 19 Nov 2014 04:48:14 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 10905 invoked by uid 55); 19 Nov 2014 04:48:08 -0000 From: "dave.anglin at bell dot net" To: gcc-bugs@gcc.gnu.org Subject: [Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll Date: Wed, 19 Nov 2014 04:48:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: gcov-profile X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dave.anglin at bell dot net X-Bugzilla-Status: NEW X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 5.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-11/txt/msg01792.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790 --- Comment #5 from dave.anglin at bell dot net --- On 18-Nov-14, at 10:15 AM, jakub at gcc dot gnu.org wrote: > As libiberty has now strtoll/strtoull functions, guess you could use > that. > You'll need to guard it with #ifdef HAVE_LONG_LONG, but if the host > doesn't > have long long, you'd better not use it in the code either. I'd say > int64_t > should be used instead of long long, and if HAVE_LONG_LONG is not > defined, > instead of strtoll you should use just strtol. I already had changed to using the functions from libiberty. Testing the attached change. -- John David Anglin dave.anglin@bell.net