* [Bug gcov-profile/61790] [4.10 Regression] gcov-tool.c uses atoll
2014-07-13 0:47 [Bug gcov-profile/61790] New: [4.10 Regression] gcov-tool.c uses atoll danglin at gcc dot gnu.org
@ 2014-07-13 20:59 ` dave.anglin at bell dot net
2014-07-14 10:32 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: dave.anglin at bell dot net @ 2014-07-13 20:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790
--- Comment #1 from dave.anglin at bell dot net ---
On 12-Jul-14, at 8:47 PM, danglin at gcc dot gnu.org wrote:
> ../../gcc/gcc/gcov-tool.c:313:42: error: 'atoll' was not declared in
> this scope
sscanf will work.
Dave
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug gcov-profile/61790] [4.10 Regression] gcov-tool.c uses atoll
2014-07-13 0:47 [Bug gcov-profile/61790] New: [4.10 Regression] gcov-tool.c uses atoll danglin at gcc dot gnu.org
2014-07-13 20:59 ` [Bug gcov-profile/61790] " dave.anglin at bell dot net
@ 2014-07-14 10:32 ` rguenth at gcc dot gnu.org
2014-09-07 17:41 ` [Bug gcov-profile/61790] [5 " danglin at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-07-14 10:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Status|UNCONFIRMED |NEW
Last reconfirmed| |2014-07-14
Target Milestone|--- |4.10.0
Ever confirmed|0 |1
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll
2014-07-13 0:47 [Bug gcov-profile/61790] New: [4.10 Regression] gcov-tool.c uses atoll danglin at gcc dot gnu.org
2014-07-13 20:59 ` [Bug gcov-profile/61790] " dave.anglin at bell dot net
2014-07-14 10:32 ` rguenth at gcc dot gnu.org
@ 2014-09-07 17:41 ` danglin at gcc dot gnu.org
2014-11-18 15:15 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: danglin at gcc dot gnu.org @ 2014-09-07 17:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790
--- Comment #3 from John David Anglin <danglin at gcc dot gnu.org> ---
Patch here:
https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00566.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll
2014-07-13 0:47 [Bug gcov-profile/61790] New: [4.10 Regression] gcov-tool.c uses atoll danglin at gcc dot gnu.org
` (2 preceding siblings ...)
2014-09-07 17:41 ` [Bug gcov-profile/61790] [5 " danglin at gcc dot gnu.org
@ 2014-11-18 15:15 ` jakub at gcc dot gnu.org
2014-11-19 4:48 ` dave.anglin at bell dot net
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-11-18 15:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
As libiberty has now strtoll/strtoull functions, guess you could use that.
You'll need to guard it with #ifdef HAVE_LONG_LONG, but if the host doesn't
have long long, you'd better not use it in the code either. I'd say int64_t
should be used instead of long long, and if HAVE_LONG_LONG is not defined,
instead of strtoll you should use just strtol.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll
2014-07-13 0:47 [Bug gcov-profile/61790] New: [4.10 Regression] gcov-tool.c uses atoll danglin at gcc dot gnu.org
` (3 preceding siblings ...)
2014-11-18 15:15 ` jakub at gcc dot gnu.org
@ 2014-11-19 4:48 ` dave.anglin at bell dot net
2015-01-09 0:51 ` danglin at gcc dot gnu.org
2015-01-09 0:52 ` danglin at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: dave.anglin at bell dot net @ 2014-11-19 4:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790
--- Comment #5 from dave.anglin at bell dot net ---
On 18-Nov-14, at 10:15 AM, jakub at gcc dot gnu.org wrote:
> As libiberty has now strtoll/strtoull functions, guess you could use
> that.
> You'll need to guard it with #ifdef HAVE_LONG_LONG, but if the host
> doesn't
> have long long, you'd better not use it in the code either. I'd say
> int64_t
> should be used instead of long long, and if HAVE_LONG_LONG is not
> defined,
> instead of strtoll you should use just strtol.
I already had changed to using the functions from libiberty. Testing
the attached change.
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll
2014-07-13 0:47 [Bug gcov-profile/61790] New: [4.10 Regression] gcov-tool.c uses atoll danglin at gcc dot gnu.org
` (4 preceding siblings ...)
2014-11-19 4:48 ` dave.anglin at bell dot net
@ 2015-01-09 0:51 ` danglin at gcc dot gnu.org
2015-01-09 0:52 ` danglin at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: danglin at gcc dot gnu.org @ 2015-01-09 0:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790
--- Comment #6 from John David Anglin <danglin at gcc dot gnu.org> ---
Author: danglin
Date: Fri Jan 9 00:50:49 2015
New Revision: 219372
URL: https://gcc.gnu.org/viewcvs?rev=219372&root=gcc&view=rev
Log:
PR gcov-profile/61790
* gcov-tool.c (do_rewrite): Use strtoll instead of atoll if host has
long long. Fallback to int64_t if host doesn't have long long and
use strtol if int64_t is long. Otherwise, use sscanf for conversion.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/gcov-tool.c
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll
2014-07-13 0:47 [Bug gcov-profile/61790] New: [4.10 Regression] gcov-tool.c uses atoll danglin at gcc dot gnu.org
` (5 preceding siblings ...)
2015-01-09 0:51 ` danglin at gcc dot gnu.org
@ 2015-01-09 0:52 ` danglin at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: danglin at gcc dot gnu.org @ 2015-01-09 0:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790
John David Anglin <danglin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from John David Anglin <danglin at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 8+ messages in thread