[Bug gcov-profile/61790] New: [4.10 Regression] gcov-tool.c uses atoll

[Bug gcov-profile/61790] New: [4.10 Regression] gcov-tool.c uses atoll

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790

            Bug ID: 61790
           Summary: [4.10 Regression] gcov-tool.c uses atoll
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: gcov-profile
          Assignee: unassigned at gcc dot gnu.org
          Reporter: danglin at gcc dot gnu.org
              Host: hppa64-hp-hpux11.11
            Target: hppa64-hp-hpux11.11
             Build: hppa64-hp-hpux11.11

g++ -c   -g -DIN_GCC    -fno-exceptions -fno-rtti -fasynchronous-unwind-tables
-W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format
-Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I.
-I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include
-I../../gcc/gcc/../libcpp/include -I/opt/gnu64/gcc/gmp/include 
-I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdec
number/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace    -o gcov-tool.o
-
MT gcov-tool.o -MMD -MP -MF ./.deps/gcov-tool.TPo ../../gcc/gcc/gcov-tool.c
../../gcc/gcc/gcov-tool.c: In function 'int do_rewrite(int, char**)':
../../gcc/gcc/gcov-tool.c:313:42: error: 'atoll' was not declared in this scope
make[3]: *** [gcov-tool.o] Error 1

[Bug gcov-profile/61790] [4.10 Regression] gcov-tool.c uses atoll

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790

--- Comment #1 from dave.anglin at bell dot net ---
On 12-Jul-14, at 8:47 PM, danglin at gcc dot gnu.org wrote:

> ../../gcc/gcc/gcov-tool.c:313:42: error: 'atoll' was not declared in  
> this scope


sscanf will work.

Dave
--
John David Anglin    dave.anglin@bell.net

[Bug gcov-profile/61790] [4.10 Regression] gcov-tool.c uses atoll

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-07-14
   Target Milestone|---                         |4.10.0
     Ever confirmed|0                           |1

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

[Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790

--- Comment #3 from John David Anglin <danglin at gcc dot gnu.org> ---
Patch here:
https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00566.html

[Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
As libiberty has now strtoll/strtoull functions, guess you could use that.
You'll need to guard it with #ifdef HAVE_LONG_LONG, but if the host doesn't
have long long, you'd better not use it in the code either.  I'd say int64_t
should be used instead of long long, and if HAVE_LONG_LONG is not defined,
instead of strtoll you should use just strtol.

[Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790

--- Comment #5 from dave.anglin at bell dot net ---
On 18-Nov-14, at 10:15 AM, jakub at gcc dot gnu.org wrote:

> As libiberty has now strtoll/strtoull functions, guess you could use  
> that.
> You'll need to guard it with #ifdef HAVE_LONG_LONG, but if the host  
> doesn't
> have long long, you'd better not use it in the code either.  I'd say  
> int64_t
> should be used instead of long long, and if HAVE_LONG_LONG is not  
> defined,
> instead of strtoll you should use just strtol.

I already had changed to using the functions from libiberty.  Testing  
the attached change.

--
John David Anglin    dave.anglin@bell.net

[Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790

--- Comment #6 from John David Anglin <danglin at gcc dot gnu.org> ---
Author: danglin
Date: Fri Jan  9 00:50:49 2015
New Revision: 219372

URL: https://gcc.gnu.org/viewcvs?rev=219372&root=gcc&view=rev
Log:
    PR gcov-profile/61790
    * gcov-tool.c (do_rewrite): Use strtoll instead of atoll if host has
    long long.  Fallback to int64_t if host doesn't have long long and
    use strtol if int64_t is long.  Otherwise, use sscanf for conversion.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gcov-tool.c

[Bug gcov-profile/61790] [5 Regression] gcov-tool.c uses atoll

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61790

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from John David Anglin <danglin at gcc dot gnu.org> ---
Fixed.