From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7895 invoked by alias); 3 Nov 2014 11:02:02 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 7825 invoked by uid 48); 3 Nov 2014 11:01:58 -0000 From: "burnus at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/61847] bug in gfortran runtime: digits cut off when reading floating point number Date: Mon, 03 Nov 2014 11:02:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: fortran X-Bugzilla-Version: 4.8.3 X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: burnus at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: jvdelisle at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-11/txt/msg00103.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D61847 Tobias Burnus changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |burnus at gcc dot gnu.org --- Comment #21 from Tobias Burnus --- (In reply to Jerry DeLisle from comment #20) > Created attachment 33858 [details] > Proposed patch /* If the current locale is expecting a comma rather than a decimal point, convert it now. */ if (dtp->u.p.current_unit->decimal_locale =3D=3D ',') *strchr (buffer, '.') =3D ','; In principle, there are more options than just "," and "."; for instance, in Britain, one often uses a centered dot (=C2=B7) but that's not in the local= e. Looking at the output of all my locales, I found: ps_AF.utf8: 0=D9=AB400000 as the only locale which doesn't use either a '.' or a ','. Still, using a = code like the following looks more robust. /* During _gfortran_st_read/write. */ const char *curr_locale =3D setlocale(LC_ALL, NULL); setlocale(LC_ALL, "C"); ... /* During _gfortran_st_read_done/write_done. */ setlocale(LC_ALL, curr_locale); * * * Side remarks: * Per PR36857 comment 8, it has to be "C" and not "POSIX" for MinGW. * The fix for PR 36857 also assumes that there is only "," and "."; thus, w= hen going the setlocale route, it should be fixed as well. * See also PR 47007; see also the variant using __strtold_l/strtold_l and newlocale for READ (cf. PR 47007 comment 20 to 22). >>From gcc-bugs-return-465632-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Nov 03 11:06:17 2014 Return-Path: Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 10513 invoked by alias); 3 Nov 2014 11:06:16 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 10494 invoked by uid 48); 3 Nov 2014 11:06:13 -0000 From: "jiwang at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/63721] New: [5 Regression] IPA ICF cause atomic-comp-swap-release-acquire.c ICE on arm Date: Mon, 03 Nov 2014 11:06:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jiwang at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-11/txt/msg00104.txt.bz2 Content-length: 3289 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D63721 Bug ID: 63721 Summary: [5 Regression] IPA ICF cause atomic-comp-swap-release-acquire.c ICE on arm Product: gcc Version: 5.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: tree-optimization Assignee: unassigned at gcc dot gnu.org Reporter: jiwang at gcc dot gnu.org Created attachment 33875 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=3D33875&action=3Dedit bug.i start from revision 216305, and still exist on latest code 217035. commit 52200d03c231f0bddbd4bbc5cd3608c6a1dd4598 Author: marxin Date: Thu Oct 16 10:47:55 2014 +0000 IPA ICF pass, part 3/5 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@216305 138bc75d-0d04-0410-961f-82ee72b054a4 cross configuration =3D=3D=3D ../gcc/configure --target=3Darm-unknown-linux-gnueabihf --with-float=3D= hard --with-arch=3Darmv7-a --with-tune=3Dcortex-a15 --disable-multilib --enable-languages=3Dc,c++,fortran,java,lto,objc compile command =3D=3D=3D ./cc1 -O2 -fPIC bug.i -nostdinc (if specify -fno-ipa-icf then the ICE will go away) backtrace =3D=3D=3D atomic-comp-swap-release-acquire.c: In function =E2=80=98atomic_compare_exchange_WEAK_RELEASE_ACQUIRE=E2=80=99: atomic-comp-swap-release-acquire.c:7:0: error: invalid argument to gimple c= all ^ a # .MEM_3 =3D VDEF <.MEM_1(D)> retval.10_4 =3D atomic_compare_exchange_n_WEAK_RELEASE_ACQUIRE.localalias.0= (a, b_2(D)); [tail call] Breakpoint 2, internal_error (gmsgid=3D0x14ff2a8 "verify_gimple failed") at ../../gcc/gcc/diagnostic.c:1176 1176 va_start (ap, gmsgid); (gdb) bt #0 internal_error (gmsgid=3D0x14ff2a8 "verify_gimple failed") at ../../gcc/gcc/diagnostic.c:1176 #1 0x0000000000c8bc5d in verify_gimple_in_cfg (fn=3D0x7ffff6b097e0, verify_nothrow=3Dfalse) at ../../gcc/gcc/tree-cfg.c:5039 #2 0x0000000000b52b81 in execute_function_todo (fn=3D0x7ffff6b097e0, data= =3D0x40) at ../../gcc/gcc/passes.c:1758 #3 0x0000000000b51f12 in do_per_function (callback=3D0xb529db , data=3D0x40) at ../../gcc/gcc/passes.c:1492 #4 0x0000000000b52d69 in execute_todo (flags=3D64) at ../../gcc/gcc/passes.c:1815 #5 0x0000000000b538cb in execute_one_pass (pass=3D0x1d0b0e0) at ../../gcc/gcc/passes.c:2172 #6 0x0000000000b5464e in execute_ipa_pass_list (pass=3D0x1d0b0e0) at ../../gcc/gcc/passes.c:2553 #7 0x00000000007db73f in ipa_passes () at ../../gcc/gcc/cgraphunit.c:2065 #8 0x00000000007db9e0 in symbol_table::compile (this=3D0x7ffff6c74000) at ../../gcc/gcc/cgraphunit.c:2145 #9 0x00000000007dbe52 in symbol_table::finalize_compilation_unit (this=3D0x7ffff6c74000) at ../../gcc/gcc/cgraphunit.c:2298 #10 0x0000000000635abb in c_write_global_declarations () at ../../gcc/gcc/c/c-decl.c:10779 #11 0x0000000000c4ce74 in compile_file () at ../../gcc/gcc/toplev.c:582 #12 0x0000000000c4f19a in do_compile () at ../../gcc/gcc/toplev.c:1989 #13 0x0000000000c4f3a4 in toplev::main (this=3D0x7fffffffe49f, argc=3D5, argv=3D0x7fffffffe598) at ../../gcc/gcc/toplev.c:2086 #14 0x00000000013a489a in main (argc=3D5, argv=3D0x7fffffffe598) at ../../gcc/gcc/main.c:38 (gdb) >>From gcc-bugs-return-465633-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Nov 03 11:14:03 2014 Return-Path: Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 13554 invoked by alias); 3 Nov 2014 11:14:02 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 13461 invoked by uid 48); 3 Nov 2014 11:13:59 -0000 From: "vries at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/63718] [5 Regression] ARM Thumb1 bootstrap fail after fuse-caller-save info in cprop-hardreg Date: Mon, 03 Nov 2014 11:14:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: rtl-optimization X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 5.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2014-11/txt/msg00105.txt.bz2 Content-length: 770 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63718 --- Comment #7 from vries at gcc dot gnu.org --- (In reply to Joey Ye from comment #6) > (In reply to vries from comment #5) > > Could you try out the patch and see if it fixes things for you? > > > Tom, thanks for the quick action. Apparantly this patch should recover the > bootstrap. I will test it and come back to you (bootstraping thumb1 with > qemu takes hours!) > Great :) > However, I think the fix is too conservative. There are plenty of chances > that r0-r3 will not be clobbered by return. For example armv6-m will pretty > much never uses r0-r3 implicitly. Indeed, the patch is conservative, but that's not such a bad idea for a correctness fix. We can always folllow up with a more optimal patch.