public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ian at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/61880] Linking with external functions in C does not work in GO when using gccgo, while it works in gc
Date: Fri, 30 Jan 2015 00:36:00 -0000	[thread overview]
Message-ID: <bug-61880-4-4LKyHtPLry@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-61880-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61880

--- Comment #7 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Fri Jan 30 00:36:14 2015
New Revision: 220269

URL: https://gcc.gnu.org/viewcvs?rev=220269&root=gcc&view=rev
Log:
compiler: Fix -fgo-prefix handling.

There was bug in the fix for PR 61880: it only worked fully
correctly for code compiled with -fgo-pkgpath.  For code that
used -fgo-prefix, or that used neither option, the '.'
separating the prefix and the package name was converted to an
underscore, which did not happen before.  This broke SWIG and
any other code that expected specific symbol names.
Fortunately all code compiled in libgo and all code compiled
by the go tool uses -fgo-pkgpath, so this probably did not
affect very many people.

This is an incomplete fix that does not modify the package
file format, for use on both mainline and the GCC 4.9 branch.
A follow on patch will fully fix the problem.

Modified:
    branches/gcc-4_9-branch/gcc/go/gofrontend/export.cc
    branches/gcc-4_9-branch/gcc/go/gofrontend/export.h
    branches/gcc-4_9-branch/gcc/go/gofrontend/gogo.cc
    branches/gcc-4_9-branch/gcc/go/gofrontend/gogo.h
    branches/gcc-4_9-branch/gcc/go/gofrontend/import.cc
    branches/gcc-4_9-branch/gcc/go/gofrontend/unsafe.cc


  parent reply	other threads:[~2015-01-30  0:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 15:32 [Bug go/61880] New: " lists at kambanaria dot org
2014-09-25 16:35 ` [Bug go/61880] " rth at gcc dot gnu.org
2014-10-02 17:57 ` ian at gcc dot gnu.org
2014-10-02 18:00 ` ian at gcc dot gnu.org
2014-10-02 18:02 ` ian at airs dot com
2014-10-28 13:55 ` jan.kratochvil at redhat dot com
2015-01-30  0:36 ` ian at gcc dot gnu.org [this message]
2015-01-30  0:36 ` ian at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-61880-4-4LKyHtPLry@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).