[Bug libobjc/61920] New: [4.8/4.9/4.10 Regression] libobjc has undefined symbols on powerp*-linux-gnu

[Bug libobjc/61920] New: [4.8/4.9/4.10 Regression] libobjc has undefined symbols on powerp*-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61920

            Bug ID: 61920
           Summary: [4.8/4.9/4.10 Regression] libobjc has undefined
                    symbols on powerp*-linux-gnu
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libobjc
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org

this is caused by:

2014-07-24  Ulrich Weigand  <Ulrich.Weigand@de.ibm.com>

        * config/rs6000/rs6000-protos.h (rs6000_special_adjust_field_align_p):
        Add prototype.
        * config/rs6000/rs6000.c (rs6000_special_adjust_field_align_p): New
        function.  Issue -Wpsabi warning if future GCC releases will use
        different field alignment rules for this type.
        * config/rs6000/sysv4.h (ADJUST_FIELD_ALIGN): Call it.
        * config/rs6000/linux64.h (ADJUST_FIELD_ALIGN): Likewise.
        * config/rs6000/freebsd64.h (ADJUST_FIELD_ALIGN): Likewise.

linking libobjc shows:

/«PKGBUILDDIR»/src/libobjc/encoding.c: In function
'objc_layout_structure_next_member':
/«PKGBUILDDIR»/src/libobjc/encoding.c:1163:3: warning: implicit declaration of
function 'rs6000_special_adjust_field_align_p'
[-Wimplicit-function-declaration]
   desired_align = ADJUST_FIELD_ALIGN (type, desired_align);
   ^

and later the packaging tools warn about:

dpkg-shlibdeps: warning: symbol rs6000_special_adjust_field_align_p used by
debian/libobjc4/usr/lib/powerpc-linux-gnu/libobjc.so.4.0.0 found in none of the
libraries

resulting in build failures for any binary linking with -lobjc.

libobjc/encoding.c has a comment saying that it has no business including tm.h,
but up to now it did work.
>From gcc-bugs-return-457135-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sat Jul 26 11:51:27 2014
Return-Path: <gcc-bugs-return-457135-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 2865 invoked by alias); 26 Jul 2014 11:51:27 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 2815 invoked by uid 48); 26 Jul 2014 11:51:23 -0000
From: "doko at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libobjc/24775] libobjc should not include GCC's target headers
Date: Sat, 26 Jul 2014 11:51:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libobjc
X-Bugzilla-Version: 4.1.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: doko at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-24775-4-w64YvEZEOY@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-24775-4@http.gcc.gnu.org/bugzilla/>
References: <bug-24775-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-07/txt/msg01726.txt.bz2
Content-length: 433

https://gcc.gnu.org/bugzilla/show_bug.cgi?id$775

Matthias Klose <doko at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |doko at gcc dot gnu.org

--- Comment #3 from Matthias Klose <doko at gcc dot gnu.org> ---
any update on this? see PR61920 for a current regression.

[Bug libobjc/61920] [4.8/4.9/4.10 Regression] libobjc has undefined symbols on powerpc*-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61920

--- Comment #1 from Matthias Klose <doko at gcc dot gnu.org> ---
PR24775 is about libobjc not including GCC's target headers

[Bug libobjc/61920] [4.8/4.9/4.10 Regression] libobjc has undefined symbols on powerpc*-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61920

--- Comment #2 from Matthias Klose <doko at gcc dot gnu.org> ---
Author: doko
Date: Sun Jul 27 13:15:17 2014
New Revision: 213097

URL: https://gcc.gnu.org/viewcvs?rev=213097&root=gcc&view=rev
Log:
2014-07-27  Alan Modra  <amodra@gmail.com>
            Matthias Klose  <doko@ubuntu.com>

        PR libobjc/61920

        * encoding.c: Define rs6000_special_adjust_field_align_p.

Modified:
    trunk/libobjc/ChangeLog
    trunk/libobjc/encoding.c

[Bug libobjc/61920] [4.8/4.9/4.10 Regression] libobjc has undefined symbols on powerpc*-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61920

--- Comment #3 from Matthias Klose <doko at gcc dot gnu.org> ---
Author: doko
Date: Sun Jul 27 13:18:15 2014
New Revision: 213099

URL: https://gcc.gnu.org/viewcvs?rev=213099&root=gcc&view=rev
Log:
2014-07-27  Alan Modra  <amodra@gmail.com>
            Matthias Klose  <doko@ubuntu.com>

        PR libobjc/61920

        * encoding.c: Define rs6000_special_adjust_field_align_p.

Modified:
    branches/gcc-4_9-branch/libobjc/ChangeLog
    branches/gcc-4_9-branch/libobjc/encoding.c

[Bug libobjc/61920] [4.8/4.9/4.10 Regression] libobjc has undefined symbols on powerpc*-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61920

--- Comment #4 from Matthias Klose <doko at gcc dot gnu.org> ---
Author: doko
Date: Sun Jul 27 13:19:21 2014
New Revision: 213100

URL: https://gcc.gnu.org/viewcvs?rev=213100&root=gcc&view=rev
Log:
2014-07-27  Alan Modra  <amodra@gmail.com>
            Matthias Klose  <doko@ubuntu.com>

        PR libobjc/61920

        * encoding.c: Define rs6000_special_adjust_field_align_p.

Modified:
    branches/gcc-4_8-branch/libobjc/ChangeLog
    branches/gcc-4_8-branch/libobjc/encoding.c

[Bug libobjc/61920] [4.8/4.9/4.10 Regression] libobjc has undefined symbols on powerpc*-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61920

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.8.4

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug libobjc/61920] [4.8/4.9/4.10 Regression] libobjc has undefined symbols on powerpc*-linux-gnu

[uweigand at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61920

--- Comment #6 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
Since we didn't backport the actual ABI change to the branches, only the
warning, I think it would be consistent to use something like this on the
branches:

#define rs6000_special_adjust_field_align_p(FIELD, COMPUTED) \
  (TARGET_ALTIVEC && TREE_CODE (TREE_TYPE (FIELD)) == VECTOR_TYPE)

rather than the #define ... 0 that is appropriate for mainline.

[Bug libobjc/61920] [4.8/4.9/4.10 Regression] libobjc has undefined symbols on powerpc*-linux-gnu

[uweigand at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61920

--- Comment #7 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
Author: uweigand
Date: Mon Jul 28 14:32:13 2014
New Revision: 213127

URL: https://gcc.gnu.org/viewcvs?rev=213127&root=gcc&view=rev
Log:
    PR libobjc/61920
    * encoding.c (rs6000_special_adjust_field_align_p): Use definition
    that matches the 4.9 branch ABI.

Modified:
    branches/gcc-4_9-branch/libobjc/ChangeLog
    branches/gcc-4_9-branch/libobjc/encoding.c

[Bug libobjc/61920] [4.8/4.9/4.10 Regression] libobjc has undefined symbols on powerpc*-linux-gnu

[uweigand at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61920

--- Comment #8 from Ulrich Weigand <uweigand at gcc dot gnu.org> ---
Author: uweigand
Date: Mon Jul 28 14:33:20 2014
New Revision: 213128

URL: https://gcc.gnu.org/viewcvs?rev=213128&root=gcc&view=rev
Log:
    PR libobjc/61920
    * encoding.c (rs6000_special_adjust_field_align_p): Use definition
    that matches the 4.8 branch ABI.

Modified:
    branches/gcc-4_8-branch/libobjc/ChangeLog
    branches/gcc-4_8-branch/libobjc/encoding.c