[Bug c++/61945] New: tree check fail with -Woverloaded-virtual

[Bug c++/61945] New: tree check fail with -Woverloaded-virtual

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61945

            Bug ID: 61945
           Summary: tree check fail with -Woverloaded-virtual
           Product: gcc
           Version: 4.9.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com

Created attachment 33201
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33201&action=edit
gzipped C++ source code

For the attached code, compiled with trunk dated 20140727,
built with --enable-checking=yes, the compiler says

/home/dcb/rpmbuild/BUILD/permlib-0.2.8/include/permlib/abstract_bsgs.h:53:7:
int
ernal compiler error: tree check: expected function_decl, have template_decl in 
warn_hidden, at cp/class.c:2825
 class AbstractBSGS : public AbstractPermutationGroup {
       ^
0xed411b tree_check_failed(tree_node const*, char const*, int, char const*,
...)
    ../../src/trunk/gcc/tree.c:9169
0x63f4a3 tree_check(tree_node*, char const*, int, char const*, tree_code)
    ../../src/trunk/gcc/tree.h:2728
0x63f4a3 warn_hidden
    ../../src/trunk/gcc/cp/class.c:2825

Compiler flag -Woverloaded-virtual required.

[Bug c++/61945] tree check fail with -Woverloaded-virtual

[tbsaunde at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61945

--- Comment #1 from tbsaunde at gcc dot gnu.org ---
minimized test case
 class A
{
           virtual void NotifyDialMMISuccess();
};
class : A
{
      template <0> void NotifyDialMMISuccess();
};

ICEs with g++ -Woverloaded-virtual -std=gnu++11

[Bug c++/61945] [5 Regression] tree check fail with -Woverloaded-virtual

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61945

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-09-23
                 CC|                            |trippels at gcc dot gnu.org
      Known to work|                            |4.8.3, 4.9.1
            Version|4.9.2                       |5.0
   Target Milestone|---                         |5.0
            Summary|tree check fail with        |[5 Regression] tree check
                   |-Woverloaded-virtual        |fail with
                   |                            |-Woverloaded-virtual
     Ever confirmed|0                           |1
      Known to fail|                            |5.0

--- Comment #2 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Also happens during Firefox build.

[Bug c++/61945] [5 Regression] tree check fail with -Woverloaded-virtual

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61945

--- Comment #3 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Another testcase:

markus@x4 tmp % cat t.ii
class A {
  virtual int orbits();
};
class B : A {
  template <typename>
  void orbits();
};

(4.9 is fine)
markus@x4 tmp % g++ -Woverloaded-virtual -c t.ii
t.ii:2:15: warning: ‘virtual int A::orbits()’ was hidden [-Woverloaded-virtual]
   virtual int orbits();
               ^
t.ii:6:8: warning:   by ‘B::orbits()’ [-Woverloaded-virtual]
   void orbits();
        ^
markus@x4 tmp % /var/tmp/gcc_test/usr/local/bin/g++ -Woverloaded-virtual -c
t.ii
t.ii:4:7: internal compiler error: tree check: expected function_decl, have
template_decl in warn_hidden, at cp/class.c:2824
 class B : A {
       ^
0xdfbb14 tree_check_failed(tree_node const*, char const*, int, char const*,
...)
        ../../gcc/gcc/tree.c:9177
0x640855 tree_check
        ../../gcc/gcc/tree.h:2733
0x640855 warn_hidden
        ../../gcc/gcc/cp/class.c:2824
0x640855 finish_struct_1(tree_node*)
        ../../gcc/gcc/cp/class.c:6518
0x640ec4 finish_struct(tree_node*, tree_node*)
        ../../gcc/gcc/cp/class.c:6698
0x66ef52 cp_parser_class_specifier_1
        ../../gcc/gcc/cp/parser.c:19550
0x671870 cp_parser_class_specifier
        ../../gcc/gcc/cp/parser.c:19778
0x671870 cp_parser_type_specifier
        ../../gcc/gcc/cp/parser.c:14527
0x68c6f0 cp_parser_decl_specifier_seq
        ../../gcc/gcc/cp/parser.c:11768
0x692639 cp_parser_simple_declaration
        ../../gcc/gcc/cp/parser.c:11358
0x673ab3 cp_parser_block_declaration
        ../../gcc/gcc/cp/parser.c:11307
0x69e1a2 cp_parser_declaration
        ../../gcc/gcc/cp/parser.c:11204
0x69ce68 cp_parser_declaration_seq_opt
        ../../gcc/gcc/cp/parser.c:11090
0x69e753 cp_parser_translation_unit
        ../../gcc/gcc/cp/parser.c:4055
0x69e753 c_parse_file()
        ../../gcc/gcc/cp/parser.c:32012
0x7c5a62 c_common_parse_file()
        ../../gcc/gcc/c-family/c-opts.c:1043
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-462342-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Sep 23 14:35:11 2014
Return-Path: <gcc-bugs-return-462342-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23971 invoked by alias); 23 Sep 2014 14:35:11 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23239 invoked by uid 48); 23 Sep 2014 14:35:02 -0000
From: "mliska at suse dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/63344] New: [5 Regression] Linux (makeallyes config) compilation error: error: apic_numachip causes a section type conflict with numachip_system
Date: Tue, 23 Sep 2014 14:35:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mliska at suse dot cz
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc
Message-ID: <bug-63344-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-09/txt/msg02176.txt.bz2
Content-length: 2329

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63344

            Bug ID: 63344
           Summary: [5 Regression] Linux (makeallyes config) compilation
                    error: error: apic_numachip causes a section type
                    conflict with numachip_system
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mliska at suse dot cz
                CC: hubicka at ucw dot cz

During testing of latest compiler, I've encountered an error in Linux kernel:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/x86/kernel/apic/apic_numachip.c?id=refs/tags/next-20140923

arch/x86/kernel/apic/apic_numachip.c:33:12: error: numachip_system causes a
section type conflict with apic_numachip
 static int numachip_system __read_mostly;
            ^
arch/x86/kernel/apic/apic_numachip.c:205:26: note: 'apic_numachip' was declared
here
 static const struct apic apic_numachip __refconst = {

There's a testcase reduced by creduce:
$ cat testcase.ii

struct apic {
  int *name
} numachip_system __attribute__((__section__(".data..read_mostly")));
static const struct apic apic_numachip
    __attribute__((__section__(".data..read_mostly")));
static const struct apic apic_numachip
    __attribute__((__section__(""))) = {.name = ""};

$ gcc testcase.i -S
/home/marxin/Programming/testcases/kernel_numa/testcase.i:6:26: error:
apic_numachip causes a section type conflict with numachip_system

The problem started with: r211363

Older gcc produces:
/home/marxin/Programming/testcases/kernel_numa/testcase.i:3:1: warning: no
semicolon at end of struct or union [enabled by default]
 } numachip_system __attribute__((__section__(".data..read_mostly")));
 ^
/home/marxin/Programming/testcases/kernel_numa/testcase.i:7:5: warning:
initialization from incompatible pointer type [enabled by default]
     __attribute__((__section__(""))) = {.name = ""};
     ^
/home/marxin/Programming/testcases/kernel_numa/testcase.i:7:5: warning: (near
initialization for ‘apic_numachip.name’) [enabled by default]

I am not familiar with section attribute magic, but it looks like a regression.

Thank you,
Martin
>From gcc-bugs-return-462343-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Sep 23 14:48:23 2014
Return-Path: <gcc-bugs-return-462343-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 5777 invoked by alias); 23 Sep 2014 14:48:22 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 5525 invoked by uid 55); 23 Sep 2014 14:48:17 -0000
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/63280] [5 Regression] Double free in GCC compiled with LTO and -O3.
Date: Tue, 23 Sep 2014 14:48:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: bootstrap
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rsandifo at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63280-4-T6EgqzIrEr@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63280-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63280-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-09/txt/msg02177.txt.bz2
Content-length: 465

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc280

--- Comment #1 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
Author: rsandifo
Date: Tue Sep 23 14:47:45 2014
New Revision: 215515

URL: https://gcc.gnu.org/viewcvs?rev!5515&root=gcc&view=rev
Log:
gcc/
    PR bootstrap/63280
    * target-globals.c (target_globals::~target_globals): Fix location
    of ira_int destruction.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/target-globals.c

[Bug c++/61945] [5 Regression] tree check fail with -Woverloaded-virtual

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61945

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org

--- Comment #4 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Started with r211960.

[Bug c++/61945] [5 Regression] tree check fail with -Woverloaded-virtual

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61945

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cas43 at cs dot stanford.edu

--- Comment #5 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
*** Bug 63367 has been marked as a duplicate of this bug. ***

[Bug c++/61945] [5 Regression] tree check fail with -Woverloaded-virtual

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61945

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mpolacek at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |mpolacek at gcc dot gnu.org

--- Comment #6 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
I have a patch.

[Bug c++/61945] [5 Regression] tree check fail with -Woverloaded-virtual

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61945

--- Comment #7 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Thu Sep 25 12:56:57 2014
New Revision: 215597

URL: https://gcc.gnu.org/viewcvs?rev=215597&root=gcc&view=rev
Log:
    PR c++/61945
    * class.c (warn_hidden): Check for FUNCTION_DECL.

    * g++.dg/warn/pr61945.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/warn/pr61945.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/class.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/61945] [5 Regression] tree check fail with -Woverloaded-virtual

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61945

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Fixed.