[Bug ipa/61998] New: [4.10 Regression] ICE: Segmentation fault with -Wsuggest-final-types

[Bug ipa/61998] New: [4.10 Regression] ICE: Segmentation fault with -Wsuggest-final-types

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61998

            Bug ID: 61998
           Summary: [4.10 Regression] ICE: Segmentation fault with
                    -Wsuggest-final-types
           Product: gcc
           Version: 4.10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: trippels at gcc dot gnu.org
                CC: hubicka at gcc dot gnu.org

markus@x4 ~ % touch foo.ii
markus@x4 ~ % g++ -Wsuggest-final-types -O2 foo.ii
foo.ii:1:0: internal compiler error: Segmentation fault
0xb9445f crash_signal
        ../../gcc/gcc/toplev.c:337
0x9fcab9 ipa_devirt
        ../../gcc/gcc/ipa-devirt.c:3102
0x9fcab9 execute
        ../../gcc/gcc/ipa-devirt.c:3372
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

Also both -Wsuggest-final-types -Wsuggest-final-methods should probably 
only be enabled for C++11 or higher, because C++98 doesn't support 
the final keyword.

[Bug ipa/61998] [4.10 Regression] ICE: Segmentation fault with -Wsuggest-final-types

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61998

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.10.0

[Bug ipa/61998] [5 Regression] ICE: Segmentation fault with -Wsuggest-final-types

[reichelt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61998

Volker Reichelt <reichelt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-08-22
                 CC|                            |reichelt at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Volker Reichelt <reichelt at gcc dot gnu.org> ---
Confirmed. I tripped over the same bug today.

[Bug ipa/61998] [5 Regression] ICE: Segmentation fault with -Wsuggest-final-types

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61998

--- Comment #2 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Markus, can you add attachment?

LTO doesn't really know what C++ language flags was used.  I guess because the
flags are not on by default, prople will use it only if they actually want to
use finals...

Docs already mentions it is C++11...

[Bug ipa/61998] [5 Regression] ICE: Segmentation fault with -Wsuggest-final-types

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61998

--- Comment #3 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
(In reply to Jan Hubicka from comment #2)
> Markus, can you add attachment?

Well, an empty testcase is enough. Or:

 % echo "int main () {}" | g++ -Wsuggest-final-types -O2 -x c++ -

[Bug ipa/61998] [5 Regression] ICE: Segmentation fault with -Wsuggest-final-types

[hubicka at ucw dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61998

--- Comment #4 from Jan Hubicka <hubicka at ucw dot cz> ---
I suppose VECtors do not like to grow to 0 size.  THe following patch fixes the
ICE, does it also fixe you real testcases?
Index: ipa-devirt.c
===================================================================
--- ipa-devirt.c        (revision 214303)
+++ ipa-devirt.c        (working copy)
@@ -3822,6 +3845,9 @@ ipa_devirt (void)
   int nmultiple = 0, noverwritable = 0, ndevirtualized = 0, nnotdefined = 0;
   int nwrong = 0, nok = 0, nexternal = 0, nartificial = 0;

+  if (!odr_types.length ())
+    return 0;
+
   /* We can output -Wsuggest-final-methods and -Wsuggest-final-types warnings.
      This is implemented by setting up final_warning_records that are updated
      by get_polymorphic_call_targets.

[Bug ipa/61998] [5 Regression] ICE: Segmentation fault with -Wsuggest-final-types

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61998

--- Comment #6 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Author: trippels
Date: Fri Sep 19 14:44:09 2014
New Revision: 215392

URL: https://gcc.gnu.org/viewcvs?rev=215392&root=gcc&view=rev
Log:
PR ipa/61998 Fix crash -Wsuggest-final-types crash

-Wsuggest-final-types crashes when used on mininal testcases.
Fix by bailing out early when odr_types_ptr is NULL in ipa_devirt()

2014-09-19  Markus Trippelsdorf  <markus@trippelsdorf.de>

        PR ipa/61998
        * ipa-devirt.c (ipa_devirt): Bail out if odr_types_ptr is NULL.

2014-09-19  Markus Trippelsdorf  <markus@trippelsdorf.de>

        PR ipa/61998
        * g++.dg/warn/Wsuggest-final-2.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/warn/Wsuggest-final-2.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-devirt.c
    trunk/gcc/testsuite/ChangeLog

[Bug ipa/61998] [5 Regression] ICE: Segmentation fault with -Wsuggest-final-types

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61998

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassigned at gcc dot gnu.org      |trippels at gcc dot gnu.org

--- Comment #7 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
fixed.