[Bug fortran/61999] [4.8/4.9/4.10 Regression] `gfc_simplify_dot_product` causes ICE for constant arguments

[Bug fortran/61999] [4.8/4.9/4.10 Regression] `gfc_simplify_dot_product` causes ICE for constant arguments

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61999

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-08-02
      Known to work|                            |4.4.7
            Summary|`gfc_simplify_dot_product`  |[4.8/4.9/4.10 Regression]
                   |causes ICE for constant     |`gfc_simplify_dot_product`
                   |arguments                   |causes ICE for constant
                   |                            |arguments
     Ever confirmed|0                           |1
      Known to fail|                            |4.10.0, 4.5.4, 4.6.4,
                   |                            |4.7.4, 4.8.3, 4.9.1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
The test compiles and gives 8.0 at run time with gfortran 4.4.7.

[Bug fortran/61999] [4.8/4.9/4.10 Regression] `gfc_simplify_dot_product` causes ICE for constant arguments

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61999

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
The ICE is due to the line

  gcc_assert (gfc_compare_types (&vector_a->ts, &vector_b->ts));

i.e., gfc_simplify_dot_product works only if the two vectors have the same
type. Replacing the assert with

--- ../_clean/gcc/fortran/simplify.c    2014-07-26 13:13:21.000000000 +0200
+++ gcc/fortran/simplify.c    2014-08-03 15:43:35.000000000 +0200
@@ -1883,7 +1883,8 @@ gfc_expr*
 gfc_simplify_dot_product (gfc_expr *vector_a, gfc_expr *vector_b)
 {
   if (!is_constant_array_expr (vector_a)
-      || !is_constant_array_expr (vector_b))
+      || !is_constant_array_expr (vector_b)
+      || !gfc_compare_types (&vector_a->ts, &vector_b->ts))
     return NULL;

   gcc_assert (vector_a->rank == 1);

fixes the problem. Indeed this prevents the dot product to be computed at
compile time. A better solution will be to do the type conversion, but I don't
know how to do it.

[Bug fortran/61999] [4.8/4.9/4.10 Regression] `gfc_simplify_dot_product` causes ICE for constant arguments

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61999

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Looks good! thanks.

[Bug fortran/61999] [4.8/4.9/4.10 Regression] `gfc_simplify_dot_product` causes ICE for constant arguments

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61999

--- Comment #5 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Author: tkoenig
Date: Sat Aug  9 22:38:46 2014
New Revision: 213782

URL: https://gcc.gnu.org/viewcvs?rev=213782&root=gcc&view=rev
Log:
2014-08-10  Thomas Koenig  <tkoenig@gcc.gnu.org>

    PR fortran/61999
    * simplify.c (gfc_simplify_dot_product): Convert types of
    vectors before calculating the result.

2014-08-10  Thomas Koenig  <tkoenig@gcc.gnu.org>

    PR fortran/61999
    * gfortran.dg/dot_product_3.f90:  New test case.


Added:
    trunk/gcc/testsuite/gfortran.dg/dot_product_3.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/simplify.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/61999] [4.8/4.9/4.10 Regression] `gfc_simplify_dot_product` causes ICE for constant arguments

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61999

--- Comment #6 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Author: tkoenig
Date: Sun Aug 10 11:25:24 2014
New Revision: 213788

URL: https://gcc.gnu.org/viewcvs?rev=213788&root=gcc&view=rev
Log:
2014-08-10  Thomas Koenig  <tkoenig@gcc.gnu.org>

    Backport from trunk
    PR fortran/61999
    * simplify.c (gfc_simplify_dot_product): Convert types of
    vectors before calculating the result.

2014-08-10  Thomas Koenig  <tkoenig@gcc.gnu.org>

    Backport from trunk
    PR fortran/61999
    * gfortran.dg/dot_product_3.f90:  New test case.


Added:
    branches/gcc-4_9-branch/gcc/testsuite/gfortran.dg/dot_product_3.f90
Modified:
    branches/gcc-4_9-branch/gcc/fortran/ChangeLog
    branches/gcc-4_9-branch/gcc/fortran/simplify.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug fortran/61999] [4.8/4.9/4.10 Regression] `gfc_simplify_dot_product` causes ICE for constant arguments

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61999

--- Comment #7 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Author: tkoenig
Date: Sun Aug 10 14:19:18 2014
New Revision: 213789

URL: https://gcc.gnu.org/viewcvs?rev=213789&root=gcc&view=rev
Log:
2014-08-10  Thomas Koenig  <tkoenig@gcc.gnu.org>

    Backport from trunk
    PR fortran/61999
    * simplify.c (gfc_simplify_dot_product): Convert types of
    vectors before calculating the result.

2014-08-10  Thomas Koenig  <tkoenig@gcc.gnu.org>

    Backport from trunk
    PR fortran/61999
    * gfortran.dg/dot_product_3.f90:  New test case.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gfortran.dg/dot_product_3.f90
Modified:
    branches/gcc-4_8-branch/gcc/fortran/ChangeLog
    branches/gcc-4_8-branch/gcc/fortran/simplify.c
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog

[Bug fortran/61999] [4.8/4.9/4.10 Regression] `gfc_simplify_dot_product` causes ICE for constant arguments

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61999

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Thomas Koenig <tkoenig at gcc dot gnu.org> ---
Fixed on all open branches, closing.

Thanks for the bug report!