public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/62030] wrong code due to ifcvt merging two stores which have different aliasing sets
Date: Wed, 06 Aug 2014 06:58:00 -0000 [thread overview]
Message-ID: <bug-62030-4-yCwf04Ct6V@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-62030-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62030
vries at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vries at gcc dot gnu.org
--- Comment #2 from vries at gcc dot gnu.org ---
I think the test-case is reading an undefined value from n->next, but that's
easy enough to fix with an intializer for node.
Taking the tentative patch from PR62004, (
https://gcc.gnu.org/bugzilla/attachment.cgi?id=33242&action=diff ), with this
patch added prevents the if-conversion in this case:
...
@@ -2504,7 +2534,9 @@ noce_process_if_block (struct noce_if_info *if_info)
if (! insn_b
|| insn_b != last_active_insn (else_bb, FALSE)
|| (set_b = single_set (insn_b)) == NULL_RTX
- || ! rtx_equal_p (x, SET_DEST (set_b)))
+ || ! (rtx_equal_p (x, SET_DEST (set_b))
+ && (GET_CODE (x) != MEM
+ || mem_interchangeable_p (x, SET_DEST (set_b))))
return FALSE;
}
else
...
next prev parent reply other threads:[~2014-08-06 6:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 5:08 [Bug rtl-optimization/62030] New: wrong code due to aliasing issue pinskia at gcc dot gnu.org
2014-08-06 5:29 ` [Bug rtl-optimization/62030] wrong code due to ifcvt merging two stores which have different aliasing sets pinskia at gcc dot gnu.org
2014-08-06 6:58 ` vries at gcc dot gnu.org [this message]
2014-08-06 7:03 ` pinskia at gcc dot gnu.org
2014-08-06 7:43 ` vries at gcc dot gnu.org
2014-08-06 9:36 ` vries at gcc dot gnu.org
2014-08-08 11:34 ` vries at gcc dot gnu.org
2014-08-08 11:39 ` vries at gcc dot gnu.org
2014-08-14 16:14 ` vries at gcc dot gnu.org
2014-08-14 17:49 ` vries at gcc dot gnu.org
2014-08-15 21:24 ` vries at gcc dot gnu.org
2014-08-16 17:38 ` vries at gcc dot gnu.org
2014-08-18 8:38 ` vries at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-62030-4-yCwf04Ct6V@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).