public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/62091] [5 Regression] ice in before_dom_children
Date: Wed, 20 Aug 2014 16:02:00 -0000	[thread overview]
Message-ID: <bug-62091-4-GIwsROfkhT@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-62091-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62091

--- Comment #13 from Jan Hubicka <hubicka at ucw dot cz> ---
Thanks, Jason!
This is patch I am testing that cures the testcase from Comment #7. I would
apprechiate if someone could reduce it - my simple attempts has failed and I am
bit in hurry this week.

The problem here is that get_dynamic_class gets into placement new paranoia
because
it manages to mismatch polymorphic_type[2] with polymorphic_type.

Honza

Index: ipa-devirt.c
===================================================================
--- ipa-devirt.c    (revision 214225)
+++ ipa-devirt.c    (working copy)
@@ -2846,6 +2891,18 @@ ipa_polymorphic_call_context::get_dynami
   bool function_entry_reached = false;
   tree instance_ref = NULL;
   gimple stmt = call;
+  /* Remember OFFSET before it is modified by restrict_to_inner_class.
+     This is because we do not update INSTANCE when walking inwards.  */
+  HOST_WIDE_INT instance_offset = offset;
+
+  /* Walk into inner type. This may clear maybe_derived_type and save us
+     from useless work.  It also makes later comparsions with static type
+     easier.  */
+  if (outer_type)
+    {
+      if (!restrict_to_inner_class (otr_type))
+        return false;
+    }

   if (!maybe_in_construction && !maybe_derived_type)
     return false;


  parent reply	other threads:[~2014-08-20 16:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 15:47 [Bug c++/62091] New: " dcb314 at hotmail dot com
2014-08-13  8:32 ` [Bug tree-optimization/62091] [4.10 Regression] " rguenth at gcc dot gnu.org
2014-08-13 18:45 ` [Bug tree-optimization/62091] [5 " hubicka at ucw dot cz
2014-08-14 23:36 ` hubicka at gcc dot gnu.org
2014-08-19 14:48 ` dcb314 at hotmail dot com
2014-08-19 16:27 ` dcb314 at hotmail dot com
2014-08-19 18:26 ` jason at gcc dot gnu.org
2014-08-19 18:30 ` jason at gcc dot gnu.org
2014-08-20  1:55 ` jason at gcc dot gnu.org
2014-08-20  2:04 ` jason at gcc dot gnu.org
2014-08-20 16:02 ` hubicka at ucw dot cz [this message]
2014-08-20 16:19 ` trippels at gcc dot gnu.org
2014-08-21 13:49 ` hubicka at gcc dot gnu.org
2014-09-25 20:13 ` hubicka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-62091-4-GIwsROfkhT@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).