public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ktietz at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/62109] __gthr_i486_lock_cmp_xchg missing clobber
Date: Fri, 20 Mar 2015 12:06:00 -0000	[thread overview]
Message-ID: <bug-62109-4-0ePp47qyWm@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-62109-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62109

--- Comment #9 from Kai Tietz <ktietz at gcc dot gnu.org> ---
(In reply to David from comment #8)
> (In reply to Kai Tietz from comment #7)
> The first code block in comment #6 is what is in the code now.  As you can
> see, it already has the #define you are describing.  I don't understand what
> you mean by "change it to" this, since it is already there.
> 
> Are you suggesting we delete the entire #ifdef
> __GTHREAD_I486_INLINE_LOCK_PRIMITIVES block and replace it with the single
> #define? 
Right, this I suggest.

> I would be ok with that.  Using the #error (the second code block
> in comment #6) seemed like a more backward-compatible way to do this, since
> it would tell people what has happened and what to do to fix it rather than
> (silently) assuming we know what they want to do.

If a target doesn't provide the Interlocked-API, build with fail caused by it. 
I don't think we need to error out on such cases.  (We don't try to cover win
3.14 incompatibilities, so why we should start for Windows 9X?)

> But I am ok with either of these two solutions.


  parent reply	other threads:[~2015-03-20 11:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12 18:07 [Bug target/62109] New: " gccbugzilla at limegreensocks dot com
2015-02-17  6:52 ` [Bug target/62109] " pinskia at gcc dot gnu.org
2015-02-23  7:25 ` gccbugzilla at limegreensocks dot com
2015-02-23 11:23 ` mikpelinux at gmail dot com
2015-03-16  3:53 ` gccbugzilla at limegreensocks dot com
2015-03-17 13:44 ` ktietz at gcc dot gnu.org
2015-03-17 23:10 ` gccbugzilla at limegreensocks dot com
2015-03-19 10:47 ` ktietz at gcc dot gnu.org
2015-03-19 23:40 ` gccbugzilla at limegreensocks dot com
2015-03-20 12:06 ` ktietz at gcc dot gnu.org [this message]
2015-10-23  1:29 ` gccbugzilla at limegreensocks dot com
2015-10-23 10:00 ` ktietz at gcc dot gnu.org
2015-10-25  1:42 ` gccbugzilla at limegreensocks dot com
2022-01-15 13:33 ` [Bug libgcc/62109] " jyong at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-62109-4-0ePp47qyWm@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).