[Bug tree-optimization/62167] New: [tail-merge] dead type-unsafe load replaces type-safe load

[Bug tree-optimization/62167] New: [tail-merge] dead type-unsafe load replaces type-safe load

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62167

            Bug ID: 62167
           Summary: [tail-merge] dead type-unsafe load replaces type-safe
                    load
           Product: gcc
           Version: 4.8.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: vries at gcc dot gnu.org

The example from PR62004 fails with -ftree-tail-merge. The PR62004 report is
reserved for the rtl if-conversion part, this report is reserved for the
tail-merge part.

[Bug tree-optimization/62167] [tail-merge] dead type-unsafe load replaces type-safe load

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62167

--- Comment #1 from vries at gcc dot gnu.org ---
Created attachment 33360
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33360&action=edit
tentative patch, testing atm

[Bug tree-optimization/62167] [tail-merge] dead type-unsafe load replaces type-safe load

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62167

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2014-08-19
     Ever confirmed|0                           |1

[Bug tree-optimization/62167] [4.8 Regression][tail-merge] dead type-unsafe load replaces type-safe load

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62167

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, wrong-code

--- Comment #2 from vries at gcc dot gnu.org ---
https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02324.html

[Bug tree-optimization/62167] [4.8 Regression][tail-merge] dead type-unsafe load replaces type-safe load

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62167

--- Comment #3 from vries at gcc dot gnu.org ---
Author: vries
Date: Wed Nov 19 10:44:58 2014
New Revision: 217761

URL: https://gcc.gnu.org/viewcvs?rev=217761&root=gcc&view=rev
Log:
Fix tail-merge pass for dead type-unsafe code

2014-11-19  Tom de Vries  <tom@codesourcery.com>

    PR tree-optimization/62167
    * tree-ssa-tail-merge.c (stmt_local_def): Handle statements with vuse
    conservatively.
    (gimple_equal_p): Don't use vn_valueize to compare for lhs equality of
    assigns.

    * gcc.dg/pr51879-12.c: Add xfails.
    * gcc.dg/pr62167-run.c: New test.
    * gcc.dg/pr62167.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr62167-run.c
    trunk/gcc/testsuite/gcc.dg/pr62167.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/pr51879-12.c
    trunk/gcc/tree-ssa-tail-merge.c

[Bug tree-optimization/62167] [4.8 Regression][tail-merge] dead type-unsafe load replaces type-safe load

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62167

--- Comment #4 from vries at gcc dot gnu.org ---
Author: vries
Date: Wed Nov 19 10:50:42 2014
New Revision: 217763

URL: https://gcc.gnu.org/viewcvs?rev=217763&root=gcc&view=rev
Log:
Fix tail-merge pass for dead type-unsafe code

2014-11-19  Tom de Vries  <tom@codesourcery.com>

    Backport from mainline
    PR tree-optimization/62167
    * tree-ssa-tail-merge.c (stmt_local_def): Handle statements with vuse
    conservatively.
    (gimple_equal_p): Don't use vn_valueize to compare for lhs equality of
    assigns.

    * gcc.dg/pr51879-12.c: Add xfails.
    * gcc.dg/pr62167-run.c: New test.
    * gcc.dg/pr62167.c: New test.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr62167-run.c
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr62167.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/pr51879-12.c
    branches/gcc-4_9-branch/gcc/tree-ssa-tail-merge.c

[Bug tree-optimization/62167] [4.8 Regression][tail-merge] dead type-unsafe load replaces type-safe load

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62167

--- Comment #5 from vries at gcc dot gnu.org ---
Author: vries
Date: Wed Nov 19 11:08:02 2014
New Revision: 217764

URL: https://gcc.gnu.org/viewcvs?rev=217764&root=gcc&view=rev
Log:
Fix tail-merge pass for dead type-unsafe code

2014-11-19  Tom de Vries  <tom@codesourcery.com>

    Backport from mainline
    PR tree-optimization/62167
    * tree-ssa-tail-merge.c (stmt_local_def): Handle statements with vuse
    conservatively.
    (gimple_equal_p): Don't use vn_valueize to compare for lhs equality of
    assigns.

    * gcc.dg/pr51879-12.c: Add xfails.
    * gcc.dg/pr62167-run.c: New test.
    * gcc.dg/pr62167.c: New test.

Added:
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/pr62167-run.c
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/pr62167.c
Modified:
    branches/gcc-4_8-branch/gcc/ChangeLog
    branches/gcc-4_8-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_8-branch/gcc/testsuite/gcc.dg/pr51879-12.c
    branches/gcc-4_8-branch/gcc/tree-ssa-tail-merge.c

[Bug tree-optimization/62167] [4.8 Regression][tail-merge] dead type-unsafe load replaces type-safe load

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62167

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from vries at gcc dot gnu.org ---
patch and testcases committed to trunk, propagated to 4.8 and 4.9

Filed followup PR (PR63955 - Remove pr51879-12.c xfail) for xfail.

Marking resolved fixed.