public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/62173] [5.0 regression] 64bit Arch can't ivopt while 32bit Arch can Date: Tue, 27 Jan 2015 09:11:00 -0000 [thread overview] Message-ID: <bug-62173-4-kvH5iRKAC6@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-62173-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62173 --- Comment #28 from rguenther at suse dot de <rguenther at suse dot de> --- On Tue, 27 Jan 2015, amker at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62173 > > --- Comment #26 from amker at gcc dot gnu.org --- > (In reply to Richard Biener from comment #17) > > I really wonder why IVOPTs calls convert_affine_scev with > > !use_overflow_semantics. > I don't understand below code in convert_affine_scev: > > enforce_overflow_semantics = (use_overflow_semantics > && nowrap_type_p (type)); > According to comments, > > "USE_OVERFLOW_SEMANTICS is true if this function should assume that > the rules for overflow of the given language apply (e.g., that signed > arithmetics in C does not overflow) -- i.e., to use them to avoid > unnecessary > tests, but also to enforce that the result follows them." > > Seems to me we need to enforce overflow check for result if we take > advantage of USE_OVERFLOW_SEMANTICS to prove there is no overflow for > src. So shouldn't we set enforce_overflow_semantics according to > "nowrap_type_p (TREE_TYPE (*base))", rather than the result type. Yes, I also wondered about this... > Also it is noted at the end of function, that we can't use the fact > "signed variables do not overflow" when we are checking for result. > > But the function is used widespread in scev, there shouldn't be anything so > wrong. Heh - I wouldn't count on that. > > Note that for the original testcase 'i' may be negative or zero and thus 'd' > > may be zero. We do a bad analysis here because IVOPTs follows complete > > peeling immediately... but at least we have range information that looks > > useful: > > The case also holds for O2, at this level gcc won't completely unroll > the first loop. > > An irrelevant question. Isn't cunroll too aggressive in GCC? For cases > like this one, the code size is bloated and may hurt Icache performance, > while only saving several increment instruction. Yeah - it was Honza enabling this aggressive peeling. It makes sense for a limited amount of code growth (like peeling two iterations) but indeed using the same limit as for unrolling (where we know intermediate exits are not taken) doesn't make too much sense... I wonder if the size estimates are correctly handling that fact...
next prev parent reply other threads:[~2015-01-27 9:11 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-18 16:12 [Bug target/62173] New: [AArch64] Performance regression due to r213488 spop at gcc dot gnu.org 2014-08-18 16:39 ` [Bug target/62173] " pinskia at gcc dot gnu.org 2014-08-18 19:13 ` spop at gcc dot gnu.org 2014-08-19 1:37 ` amker at gcc dot gnu.org 2014-10-28 11:28 ` [Bug target/62173] [5.0 regression] " jiwang at gcc dot gnu.org 2014-11-14 9:37 ` jiwang at gcc dot gnu.org 2014-11-17 2:14 ` amker.cheng at gmail dot com 2014-11-24 12:15 ` jiwang at gcc dot gnu.org 2014-11-24 12:38 ` jiwang at gcc dot gnu.org 2014-11-24 13:06 ` rguenth at gcc dot gnu.org 2014-11-24 23:01 ` jiwang at gcc dot gnu.org 2014-11-26 10:54 ` [Bug target/62173] [5.0 regression] [AArch64] Can't ivopt array base address while ARM can jiwang at gcc dot gnu.org 2014-11-27 9:35 ` jiwang at gcc dot gnu.org 2014-11-27 12:00 ` [Bug tree-optimization/62173] [5.0 regression] 64bit Arch can't ivopt while 32bit Arch can rguenther at suse dot de 2014-11-27 12:16 ` rguenther at suse dot de 2014-11-27 13:34 ` jiwang at gcc dot gnu.org 2015-01-23 17:33 ` jiwang at gcc dot gnu.org 2015-01-26 10:30 ` rguenth at gcc dot gnu.org 2015-01-26 11:10 ` rguenth at gcc dot gnu.org 2015-01-26 13:48 ` ramana at gcc dot gnu.org 2015-01-26 14:19 ` amker at gcc dot gnu.org 2015-01-26 14:51 ` rguenther at suse dot de 2015-01-26 14:53 ` rguenther at suse dot de 2015-01-26 15:03 ` amker at gcc dot gnu.org 2015-01-26 15:38 ` jiwang at gcc dot gnu.org 2015-01-27 3:21 ` amker at gcc dot gnu.org 2015-01-27 7:56 ` amker at gcc dot gnu.org 2015-01-27 9:11 ` rguenther at suse dot de [this message] 2015-01-28 18:26 ` LpSolit at netscape dot net 2015-01-29 6:48 ` amker at gcc dot gnu.org 2015-01-30 6:42 ` amker at gcc dot gnu.org 2015-01-30 12:32 ` rguenth at gcc dot gnu.org 2015-02-05 7:27 ` amker at gcc dot gnu.org 2015-03-11 17:30 ` [Bug tree-optimization/62173] [5 Regression] " jiwang at gcc dot gnu.org 2015-03-11 17:46 ` jiwang at gcc dot gnu.org 2015-03-11 17:52 ` [Bug tree-optimization/62173] [5/6 " jakub at gcc dot gnu.org 2015-03-13 8:34 ` amker at gcc dot gnu.org 2015-06-02 3:34 ` amker at gcc dot gnu.org 2015-06-03 3:56 ` amker at gcc dot gnu.org 2015-07-22 11:44 ` jiwang at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-62173-4-kvH5iRKAC6@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).