[Bug c++/62175] New: Internal compiler error in gimplify_modify_expr gimplify.c:4616

[Bug c++/62175] New: Internal compiler error in gimplify_modify_expr gimplify.c:4616

[mbetten at sandia dot gov]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62175

            Bug ID: 62175
           Summary: Internal compiler error in gimplify_modify_expr
                    gimplify.c:4616
           Product: gcc
           Version: 4.9.1
            Status: UNCONFIRMED
          Severity: critical
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mbetten at sandia dot gov

Compile the attached file with openmp and optimized you get a compiler internal
error.  File is preprocessed and all ready to go, no includes needed.

[mbetten@s939194 opt_build_panzer]$ g++ -O3 /tmp/file.cpp  -c       -fopenmp
-O3 -g  -ansi  -ftrapv  -v -save-temps
Using built-in specs.
COLLECT_GCC=g++
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc-4.9.1/configure --prefix=/home/mbetten/gcc
--with-gmp=/home/mbetten/gcc --with-mpfr=/home/mbetten/gcc
--with-mpc=/home/mbetten/gcc
Thread model: posix
gcc version 4.9.1 (GCC) 
COLLECT_GCC_OPTIONS='-O3' '-c' '-fopenmp' '-O3' '-g' '-ansi' '-ftrapv' '-v'
'-save-temps' '-shared-libgcc' '-mtune=generic' '-march=x86-64' '-pthread'
 /home/mbetten/gcc/libexec/gcc/x86_64-unknown-linux-gnu/4.9.1/cc1plus -E -quiet
-v -D_GNU_SOURCE -D_REENTRANT /tmp/file.cpp -mtune=generic -march=x86-64 -ansi
-fopenmp -ftrapv -g -fworking-directory -O3 -O3 -fpch-preprocess -o file.ii
ignoring nonexistent directory
"/home/mbetten/gcc/lib/gcc/x86_64-unknown-linux-gnu/4.9.1/../../../../x86_64-unknown-linux-gnu/include"
ignoring duplicate directory
"/opt/intel/composer_xe_2013_sp1.1.106/mkl/include"
ignoring duplicate directory
"/opt/intel/composer_xe_2013_sp1.1.106/tbb/include"
#include "..." search starts here:
#include <...> search starts here:
 /opt/intel/composer_xe_2013_sp1.1.106/mkl/include
 /opt/intel/composer_xe_2013_sp1.1.106/tbb/include

/home/mbetten/gcc/lib/gcc/x86_64-unknown-linux-gnu/4.9.1/../../../../include/c++/4.9.1

/home/mbetten/gcc/lib/gcc/x86_64-unknown-linux-gnu/4.9.1/../../../../include/c++/4.9.1/x86_64-unknown-linux-gnu

/home/mbetten/gcc/lib/gcc/x86_64-unknown-linux-gnu/4.9.1/../../../../include/c++/4.9.1/backward
 /home/mbetten/gcc/lib/gcc/x86_64-unknown-linux-gnu/4.9.1/include
 /usr/local/include
 /home/mbetten/gcc/include
 /home/mbetten/gcc/lib/gcc/x86_64-unknown-linux-gnu/4.9.1/include-fixed
 /usr/include
End of search list.
COLLECT_GCC_OPTIONS='-O3' '-c' '-fopenmp' '-O3' '-g' '-ansi' '-ftrapv' '-v'
'-save-temps' '-shared-libgcc' '-mtune=generic' '-march=x86-64' '-pthread'
 /home/mbetten/gcc/libexec/gcc/x86_64-unknown-linux-gnu/4.9.1/cc1plus
-fpreprocessed file.ii -quiet -dumpbase file.cpp -mtune=generic -march=x86-64
-auxbase file -g -O3 -O3 -ansi -version -fopenmp -ftrapv -o file.s
GNU C++ (GCC) version 4.9.1 (x86_64-unknown-linux-gnu)
    compiled by GNU C version 4.9.1, GMP version 6.0.0, MPFR version 3.1.2, MPC
version 1.0.1
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
GNU C++ (GCC) version 4.9.1 (x86_64-unknown-linux-gnu)
    compiled by GNU C version 4.9.1, GMP version 6.0.0, MPFR version 3.1.2, MPC
version 1.0.1
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
Compiler executable checksum: 5bd09c8d46de55a1c64a013324c44d10
In file included from
/home/mbetten/Trilinos/Trilinos/packages/teuchos/core/src/Teuchos_Array.hpp:52:0,
                 from
/home/mbetten/Trilinos/Trilinos/packages/rtop/src/interfaces/RTOpPack_Types.hpp:49,
                 from
/home/mbetten/Trilinos/Trilinos/packages/thyra/core/src/interfaces/operator_vector/fundamental/Thyra_OperatorVectorTypes.hpp:46,
                 from
/home/mbetten/Trilinos/Trilinos/packages/thyra/core/src/interfaces/operator_solve/fundamental/Thyra_SolveSupportTypes.hpp:45,
                 from
/home/mbetten/Trilinos/Trilinos/packages/thyra/core/src/interfaces/operator_solve/fundamental/Thyra_OperatorSolveTypes.hpp:46,
                 from
/home/mbetten/Trilinos/Trilinos/packages/thyra/core/src/interfaces/operator_solve/fundamental/Thyra_LinearOpWithSolveBase_decl.hpp:45,
                 from
/home/mbetten/Trilinos/opt_build_panzer/packages/thyra/core/src/Thyra_LinearOpWithSolveBase.hpp:1,
                 from
/home/mbetten/Trilinos/Trilinos/packages/thyra/core/src/interfaces/operator_solve/fundamental/Thyra_LinearOpWithSolveFactoryBase_decl.hpp:45,
                 from
/home/mbetten/Trilinos/opt_build_panzer/packages/thyra/core/src/Thyra_LinearOpWithSolveFactoryBase.hpp:1,
                 from
/home/mbetten/Trilinos/Trilinos/packages/thyra/core/src/interfaces/operator_solve/extended/Thyra_LinearSolverBuilderBase.hpp:46,
                 from
/home/mbetten/Trilinos/Trilinos/packages/stratimikos/src/Stratimikos_DefaultLinearSolverBuilder.hpp:46,
                 from
/home/mbetten/Trilinos/Trilinos/packages/muelu/adapters/stratimikos-tpetra/Stratimikos_MueluTpetraHelpers.hpp:49,
                 from
/home/mbetten/Trilinos/Trilinos/packages/muelu/adapters/stratimikos-tpetra/Stratimikos_MueluTpetraHelpers.cpp:47:
/home/mbetten/Trilinos/Trilinos/packages/teuchos/core/src/Teuchos_ArrayRCP.hpp:
In member function ‘void Zoltan2::IdentifierMap<User>::setupMap() [with User =
Zoltan2::BasicUserTypes<double, int, int, int>]’:
/home/mbetten/Trilinos/Trilinos/packages/teuchos/core/src/Teuchos_ArrayRCP.hpp:875:7:
internal compiler error: in gimplify_modify_expr, at gimplify.c:4616
       (*this)[i] = val;
       ^
0x7ddc89 gimplify_modify_expr
    ../../gcc-4.9.1/gcc/gimplify.c:4616
0x7de70a gimplify_expr(tree_node**, gimple_statement_base**,
gimple_statement_base**, bool (*)(tree_node*), int)
    ../../gcc-4.9.1/gcc/gimplify.c:7627
0x7e1606 gimplify_stmt(tree_node**, gimple_statement_base**)
    ../../gcc-4.9.1/gcc/gimplify.c:5373
0x7e3bc7 gimplify_cond_expr
    ../../gcc-4.9.1/gcc/gimplify.c:3086
0x7de857 gimplify_expr(tree_node**, gimple_statement_base**,
gimple_statement_base**, bool (*)(tree_node*), int)
    ../../gcc-4.9.1/gcc/gimplify.c:7583
0x7e1606 gimplify_stmt(tree_node**, gimple_statement_base**)
    ../../gcc-4.9.1/gcc/gimplify.c:5373
0x7e3967 gimplify_cond_expr
    ../../gcc-4.9.1/gcc/gimplify.c:2981
0x7de857 gimplify_expr(tree_node**, gimple_statement_base**,
gimple_statement_base**, bool (*)(tree_node*), int)
    ../../gcc-4.9.1/gcc/gimplify.c:7583
0x7e7c41 force_gimple_operand_1(tree_node*, gimple_statement_base**, bool
(*)(tree_node*), tree_node*)
    ../../gcc-4.9.1/gcc/gimplify-me.c:84
0x7e7d3f force_gimple_operand_gsi_1(gimple_stmt_iterator*, tree_node*, bool
(*)(tree_node*), tree_node*, bool, gsi_iterator_update)
    ../../gcc-4.9.1/gcc/gimplify-me.c:121
0x9a7b2d generate_memset_builtin
    ../../gcc-4.9.1/gcc/tree-loop-distribution.c:796
0x9a7b2d generate_code_for_partition
    ../../gcc-4.9.1/gcc/tree-loop-distribution.c:942
0x9ab4e7 distribute_loop
    ../../gcc-4.9.1/gcc/tree-loop-distribution.c:1658
0x9ab4e7 tree_loop_distribution
    ../../gcc-4.9.1/gcc/tree-loop-distribution.c:1762
0x9ab4e7 execute
    ../../gcc-4.9.1/gcc/tree-loop-distribution.c:1826
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
[
>From gcc-bugs-return-458728-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Aug 18 18:01:36 2014
Return-Path: <gcc-bugs-return-458728-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3882 invoked by alias); 18 Aug 2014 18:01:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3835 invoked by uid 55); 18 Aug 2014 18:01:28 -0000
From: "uros at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/62011] False Data Dependency in popcnt instruction
Date: Mon, 18 Aug 2014 18:01:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: uros at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-62011-4-TgY0nY0qos@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-62011-4@http.gcc.gnu.org/bugzilla/>
References: <bug-62011-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-08/txt/msg01225.txt.bz2
Content-length: 1428

https://gcc.gnu.org/bugzilla/show_bug.cgi?idb011

--- Comment #11 from uros at gcc dot gnu.org ---
Author: uros
Date: Mon Aug 18 18:00:52 2014
New Revision: 214112

URL: https://gcc.gnu.org/viewcvs?rev!4112&root=gcc&view=rev
Log:
    PR target/62011
    * config/i386/x86-tune.def (X86_TUNE_AVOID_FALSE_DEP_FOR_BMI):
    New tune flag.
    * config/i386/i386.h (TARGET_AVOID_FALSE_DEP_FOR_BMI): New define.
    * config/i386/i386.md (unspec) <UNSPEC_INSN_FALSE_DEP>: New unspec.
    (ffs<mode>2): Do not expand with tzcnt for
    TARGET_AVOID_FALSE_DEP_FOR_BMI.
    (ffssi2_no_cmove): Ditto.
    (*tzcnt<mode>_1): Disable for TARGET_AVOID_FALSE_DEP_FOR_BMI.
    (ctz<mode>2): New expander.
    (*ctz<mode>2_falsedep_1): New insn_and_split pattern.
    (*ctz<mode>2_falsedep): New insn.
    (*ctz<mode>2): Rename from ctz<mode>2.
    (clz<mode>2_lzcnt): New expander.
    (*clz<mode>2_lzcnt_falsedep_1): New insn_and_split pattern.
    (*clz<mode>2_lzcnt_falsedep): New insn.
    (*clz<mode>2): Rename from ctz<mode>2.
    (popcount<mode>2): New expander.
    (*popcount<mode>2_falsedep_1): New insn_and_split pattern.
    (*popcount<mode>2_falsedep): New insn.
    (*popcount<mode>2): Rename from ctz<mode>2.
    (*popcount<mode>2_cmp): Remove.
    (*popcountsi2_cmp_zext): Ditto.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.h
    trunk/gcc/config/i386/i386.md
    trunk/gcc/config/i386/x86-tune.def

[Bug c++/62175] Internal compiler error in gimplify_modify_expr gimplify.c:4616

[mbetten at sandia dot gov]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62175

--- Comment #1 from Matt <mbetten at sandia dot gov> ---
Created attachment 33354
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33354&action=edit
Preprocessed file that causes the internal error

[Bug c++/62175] Internal compiler error in gimplify_modify_expr gimplify.c:4616

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62175

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-08-19
     Ever confirmed|0                           |1

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.  Also takes 2gb of ram for building.  Reducing.

[Bug c++/62175] Internal compiler error in gimplify_modify_expr gimplify.c:4616

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62175

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 33368
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33368&action=edit
somewhat autoreduced testcsae

very slow to reduce.  attaching what I have.

[Bug c++/62175] [4.9/5 Regression] Internal compiler error in gimplify_modify_expr gimplify.c:4616

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62175

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
      Known to work|                            |4.8.3
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
   Target Milestone|---                         |4.9.2
            Summary|Internal compiler error in  |[4.9/5 Regression] Internal
                   |gimplify_modify_expr        |compiler error in
                   |gimplify.c:4616             |gimplify_modify_expr
                   |                            |gimplify.c:4616
      Known to fail|                            |4.9.1
           Severity|critical                    |normal

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine (trunk backtrace points to loop distribution).

[Bug c++/62175] [4.9/5 Regression] Internal compiler error in gimplify_modify_expr gimplify.c:4616

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62175

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Ok, so we try to generate a memset from a loop with the number of iterations
being

  (long int) (_3 + 1) >= (long int) _7 + 1 ? ((unsigned long) (_3 + 1) -
(unsigned long) _7) - 1 : 0

as this has conditionals it doesn't survive gimplification (gimplification
turns it into control-flow).

Not sure how other passes avoid running into this.

We run into this gimplifying issue because of:

          if (gimplify_ctxp->allow_rhs_cond_expr
              /* If either branch has side effects or could trap, it can't be
                 evaluated unconditionally.  */
              && !TREE_SIDE_EFFECTS (then_)
              && !generic_expr_could_trap_p (then_)
              && !TREE_SIDE_EFFECTS (else_)
              && !generic_expr_could_trap_p (else_))
            return gimplify_pure_cond_expr (expr_p, pre_p);

that is, gimplification is afraid of evaluating both COND_EXPR results
unconditionally because of -ftrapv.

[of course those are compiler-generated expressions and shouldn't have
-ftrapv applied, but that's not possible to tell right now so it would
mean creating unsigned expressions only]

Here _3 + 1 can trap.

We could short-cicuit the above by gimplify_ctxp->into_ssa but that may
cause these ICEs to turn into wrong-code if we ever bogously generate
trapping expressions unconditonally.

It is tree-ssa-loop-niter.c:expand_simple_operations which builds up this
expression.  We could guard that properly to not expand possibly trapping
statements.  That's probably the safest and most reliable way of avoiding
this bug.

Index: gcc/tree-ssa-loop-niter.c
===================================================================
--- gcc/tree-ssa-loop-niter.c   (revision 214258)
+++ gcc/tree-ssa-loop-niter.c   (working copy)
@@ -1633,6 +1633,9 @@ expand_simple_operations (tree expr)

     case PLUS_EXPR:
     case MINUS_EXPR:
+      if (TYPE_OVERFLOW_TRAPS (TREE_TYPE (expr)))
+       return expr;
+      /* Fallthru.  */
     case POINTER_PLUS_EXPR:
       /* And increments and decrements by a constant are simple.  */
       e1 = gimple_assign_rhs2 (stmt);

[Bug c++/62175] [4.9/5 Regression] Internal compiler error in gimplify_modify_expr gimplify.c:4616

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62175

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Tue Aug 26 08:03:32 2014
New Revision: 214492

URL: https://gcc.gnu.org/viewcvs?rev=214492&root=gcc&view=rev
Log:
2014-08-26  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/62175
    * tree-ssa-loop-niter.c (expand_simple_operations): Do not
    expand possibly trapping operations.

    * g++.dg/torture/pr62175.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/torture/pr62175.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-loop-niter.c

[Bug c++/62175] [4.9 Regression] Internal compiler error in gimplify_modify_expr gimplify.c:4616

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62175

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.9/5 Regression] Internal |[4.9 Regression] Internal
                   |compiler error in           |compiler error in
                   |gimplify_modify_expr        |gimplify_modify_expr
                   |gimplify.c:4616             |gimplify.c:4616

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.

[Bug c++/62175] [4.9 Regression] Internal compiler error in gimplify_modify_expr gimplify.c:4616

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62175

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug c++/62175] [4.9 Regression] Internal compiler error in gimplify_modify_expr gimplify.c:4616

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62175

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Tue Sep  9 11:42:34 2014
New Revision: 215059

URL: https://gcc.gnu.org/viewcvs?rev=215059&root=gcc&view=rev
Log:
2014-09-09  Richard Biener  <rguenther@suse.de>

    Backport from mainline
    2014-08-05  Richard Biener  <rguenther@suse.de>

    PR rtl-optimization/61672
    * emit-rtl.h (mem_attrs_eq_p): Declare.
    * emit-rtl.c (mem_attrs_eq_p): Export.  Handle NULL mem-attrs.
    * cse.c (exp_equiv_p): Use mem_attrs_eq_p.
    * cfgcleanup.c (merge_memattrs): Likewise.
    Include emit-rtl.h.

    2014-08-11  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/62075
    * tree-vect-slp.c (vect_detect_hybrid_slp_stmts): Properly
    handle uses in patterns.

    * gcc.dg/vect/pr62075.c: New testcase.

    2014-08-14  Richard Biener  <rguenther@suse.de>

    PR rtl-optimization/62079
    * recog.c (peephole2_optimize): If peep2_do_cleanup_cfg
    run cleanup_cfg.

    * g++.dg/pr62079.C: New testcase.


    2014-08-26  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/62175
    * tree-ssa-loop-niter.c (expand_simple_operations): Do not
    expand possibly trapping operations.

    * g++.dg/torture/pr62175.C: New testcase.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/g++.dg/pr62079.C
    branches/gcc-4_9-branch/gcc/testsuite/g++.dg/torture/pr62175.C
    branches/gcc-4_9-branch/gcc/testsuite/gcc.dg/vect/pr62075.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/cfgcleanup.c
    branches/gcc-4_9-branch/gcc/cse.c
    branches/gcc-4_9-branch/gcc/emit-rtl.c
    branches/gcc-4_9-branch/gcc/recog.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_9-branch/gcc/tree-ssa-loop-niter.c
    branches/gcc-4_9-branch/gcc/tree-vect-slp.c