public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "arnaud.bienner at ensimag dot fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/62182] New warning wished: operator== and "equality comparison result unused [-Wunused-comparison]"/-Wunsed-value
Date: Wed, 15 Apr 2015 22:40:00 -0000	[thread overview]
Message-ID: <bug-62182-4-PXgsaLX2bf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-62182-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62182

--- Comment #3 from Arnaud Bienner <arnaud.bienner at ensimag dot fr> ---
Created attachment 35324
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35324&action=edit
unused-comparison warning

I also believe it can be useful to have "unused comparison" warning (i.e.
something more specific than current "unused value" warning, because they are
likely to be typo.
Having a dedicated warning will allow people who want to activate this warning
specifically and/or to turn it into an error.

So I started to have a look at this and I would like to have some feedback from
someone more experienced.
It's my first patch to gcc, so it is probably not perfect.

One thing that doesn't work is turning on this warning using
-Wunused-comparison parameter. But surprisingly, turning it off with
-Wno-unused-comparison (when -Wunused or -Wall is used) works. Not sure what
I'm missing here.

The patch would just be a first step: the next step would be to also raise this
warning in the case of a "==" operator overloading in C++ (which seems to be
the case that doesn't raise a warning currently). Not sure yet how to do this.


  parent reply	other threads:[~2015-04-15 22:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-62182-4@http.gcc.gnu.org/bugzilla/>
2015-02-28 16:43 ` manu at gcc dot gnu.org
2015-04-13 16:38 ` arnaud.bienner at ensimag dot fr
2015-04-15 22:40 ` arnaud.bienner at ensimag dot fr [this message]
2015-04-16  0:43 ` manu at gcc dot gnu.org
2015-04-16  6:05 ` mpolacek at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-62182-4-PXgsaLX2bf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).