From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-461058-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 21211 invoked by alias); 2 Sep 2014 21:22:10 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 21147 invoked by uid 48); 2 Sep 2014 21:22:02 -0000
From: "trippels at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/62224] [4.9 Regression] Possible regression in gcc-4.9-20140820
Date: Tue, 02 Sep 2014 21:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.9.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: trippels at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.2
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-62224-4-kAMTHyOw85@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-62224-4@http.gcc.gnu.org/bugzilla/>
References: <bug-62224-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-09/txt/msg00892.txt.bz2

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62224

--- Comment #10 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
(In reply to Chris Clayton from comment #9)
> That seems odd to me, although I'm happy to be told I'm wrong. I base this
> on the fact that reverting the code change from r214208 permits a successful
> build. MoreOver, in both the failed and sucessful builds, ensureUpdated is
> present in cppmodelmanager.o and that is linked into libCppTools.so.

Before r214208 the body of "virtual QByteArray
CppTools::Internal::CppModelManager::definedMacros()" (and the other two
virtual functions) that call ensureUpdated() were removed:

_ZN8CppTools8Internal15CppModelManager13definedMacrosEv/6495 (virtual
QByteArray CppTools::Internal::CppModelManager::definedMacros())
@0x7f601c207520
Type: function
Body removed by symtab_remove_unreachable_nodes
Visibility: external public weak comdat
comdat_group:_ZN8CppTools8Internal15CppModelManager13definedMacrosEv one_only
virtual

Now these virtual function bodies are kept:

_ZN8CppTools8Internal15CppModelManager13definedMacrosEv/6495 (virtual
QByteArray CppTools::Internal::CppModelManager::definedMacros())
@0x7f67c0347520                        
  Type: function definition analyzed
  Visibility: externally_visible public weak comdat
comdat_group:_ZN8CppTools8Internal15CppModelManager13definedMacrosEv one_only
virtual
  previous sharing asm name: 12475
  Address is taken.
  References:
  Referring: _ZN9CppEditor8Internal27CppCodeModelInspectorDialog7refreshEv/6819
(addr) (speculative)
  Availability: available
  First run: 0
  Function flags: body
  Called by:
  Calls: _ZN8CppTools8Internal15CppModelManager13ensureUpdatedEv/10759 (1.00
per call) (can throw external)

And there is nothing wrong with that AFAICS.