* [Bug libfortran/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
@ 2014-11-25 16:36 ` danglin at gcc dot gnu.org
2015-01-04 1:23 ` [Bug testsuite/62250] " danglin at gcc dot gnu.org
` (12 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: danglin at gcc dot gnu.org @ 2014-11-25 16:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> ---
The gfortran command does not explicitly link with libatomic.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
2014-11-25 16:36 ` [Bug libfortran/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single danglin at gcc dot gnu.org
@ 2015-01-04 1:23 ` danglin at gcc dot gnu.org
2015-01-04 1:26 ` danglin at gcc dot gnu.org
` (11 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: danglin at gcc dot gnu.org @ 2015-01-04 1:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> ---
Author: danglin
Date: Sun Jan 4 01:22:54 2015
New Revision: 219171
URL: https://gcc.gnu.org/viewcvs?rev=219171&root=gcc&view=rev
Log:
PR testsuite/62250
* lib/gfortran.exp: Add libatomic library search path.
* gfortran.dg/coarray/caf.exp: Add -latomic to test options.
* gfortran.dg/coarray_lib_comm_1.f90: Likewise.
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gfortran.dg/coarray/caf.exp
trunk/gcc/testsuite/gfortran.dg/coarray_lib_comm_1.f90
trunk/gcc/testsuite/lib/gfortran.exp
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
2014-11-25 16:36 ` [Bug libfortran/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single danglin at gcc dot gnu.org
2015-01-04 1:23 ` [Bug testsuite/62250] " danglin at gcc dot gnu.org
@ 2015-01-04 1:26 ` danglin at gcc dot gnu.org
2015-01-07 2:07 ` hp at gcc dot gnu.org
` (10 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: danglin at gcc dot gnu.org @ 2015-01-04 1:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
John David Anglin <danglin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from John David Anglin <danglin at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2015-01-04 1:26 ` danglin at gcc dot gnu.org
@ 2015-01-07 2:07 ` hp at gcc dot gnu.org
2015-01-07 3:10 ` hp at gcc dot gnu.org
` (9 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: hp at gcc dot gnu.org @ 2015-01-07 2:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hp at gcc dot gnu.org
--- Comment #4 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to John David Anglin from comment #3)
> Fixed.
But instead causing these tests to fail for all targets that don't have
-latomic.
I.e. -latomic should only be added when there is one, otherwise assume that
support is built-in as before the patch. Also, the patch should have used
atomic-dg.exp instead of manually adding the search paths.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2015-01-07 2:07 ` hp at gcc dot gnu.org
@ 2015-01-07 3:10 ` hp at gcc dot gnu.org
2015-01-07 3:15 ` dave.anglin at bell dot net
` (8 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: hp at gcc dot gnu.org @ 2015-01-07 3:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #5 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to Hans-Peter Nilsson from comment #4)
> Also, the patch should have used
> atomic-dg.exp instead of manually adding the search paths.
Easier said than done, unfortunately. Doing a simpler fix.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2015-01-07 3:10 ` hp at gcc dot gnu.org
@ 2015-01-07 3:15 ` dave.anglin at bell dot net
2015-01-07 3:27 ` dave.anglin at bell dot net
` (7 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: dave.anglin at bell dot net @ 2015-01-07 3:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #6 from dave.anglin at bell dot net ---
On 2015-01-06, at 9:06 PM, hp at gcc dot gnu.org wrote:
> But instead causing these tests to fail for all targets that don't have
> -latomic.
> I.e. -latomic should only be added when there is one, otherwise assume that
> support is built-in as before the patch. Also, the patch should have used
> atomic-dg.exp instead of manually adding the search paths.
That is clearly a better approach.
What about the gfortran.dg/coarray_lib_comm_1.f90 test? Do you see a better
alternative than adding "load_lib atomic-dg.exp" to gfortran.dg/dg.exp?
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2015-01-07 3:15 ` dave.anglin at bell dot net
@ 2015-01-07 3:27 ` dave.anglin at bell dot net
2015-01-07 15:03 ` hp at gcc dot gnu.org
` (6 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: dave.anglin at bell dot net @ 2015-01-07 3:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #7 from dave.anglin at bell dot net ---
On 2015-01-06, at 10:10 PM, hp at gcc dot gnu.org wrote:
> Easier said than done, unfortunately. Doing a simpler fix.
Thanks
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2015-01-07 3:27 ` dave.anglin at bell dot net
@ 2015-01-07 15:03 ` hp at gcc dot gnu.org
2015-01-07 15:38 ` dave.anglin at bell dot net
` (5 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: hp at gcc dot gnu.org @ 2015-01-07 15:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #8 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Created attachment 34394
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34394&action=edit
Patch to add -latomic only when available; -p0 -d path/to/gcc/testsuite
David, could you please check if the attached patch still works for
hppa*-*-hpux*?
I've verified that it fixes the regressions I see (cross to cris-elf; a system
without a -latomic port and where the operations are built-in) and that
-latomic is still added for a native x86_64-unknown-linux-gnu build, with tests
still passing. Though, as -latomic is redundant on that last system, I haven't
actually tested it on a system where -latomic is *required*; the point if this
PR (and BTW sorry for being lazy and hijacking it - a pointer to a new PR would
have been more appropriate).
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2015-01-07 15:03 ` hp at gcc dot gnu.org
@ 2015-01-07 15:38 ` dave.anglin at bell dot net
2015-01-08 21:58 ` hp at gcc dot gnu.org
` (4 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: dave.anglin at bell dot net @ 2015-01-07 15:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #9 from dave.anglin at bell dot net ---
On 2015-01-07 10:03 AM, hp at gcc dot gnu.org wrote:
> David, could you please check if the attached patch still works for
> hppa*-*-hpux*?
I've added your patch to my hpux tree for testing.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2015-01-07 15:38 ` dave.anglin at bell dot net
@ 2015-01-08 21:58 ` hp at gcc dot gnu.org
2015-01-08 22:00 ` hp at gcc dot gnu.org
` (3 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: hp at gcc dot gnu.org @ 2015-01-08 21:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #10 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Author: hp
Date: Thu Jan 8 21:57:49 2015
New Revision: 219364
URL: https://gcc.gnu.org/viewcvs?rev=219364&root=gcc&view=rev
Log:
PR testsuite/62250
* lib/target-supports.exp (check_effective_target_libatomic_available):
New.
* gfortran.dg/coarray/caf.exp: Only add -latomic for
targets that match effective-target libatomic_available.
* gfortran.dg/coarray_lib_comm_1.f90: Similar.
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gfortran.dg/coarray/caf.exp
trunk/gcc/testsuite/lib/target-supports.exp
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2015-01-08 21:58 ` hp at gcc dot gnu.org
@ 2015-01-08 22:00 ` hp at gcc dot gnu.org
2015-01-09 19:22 ` dje at gcc dot gnu.org
` (2 subsequent siblings)
13 siblings, 0 replies; 14+ messages in thread
From: hp at gcc dot gnu.org @ 2015-01-08 22:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #11 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Author: hp
Date: Thu Jan 8 21:59:26 2015
New Revision: 219365
URL: https://gcc.gnu.org/viewcvs?rev=219365&root=gcc&view=rev
Log:
PR testsuite/62250
* lib/target-supports.exp (check_effective_target_libatomic_available):
New.
* gfortran.dg/coarray/caf.exp: Only add -latomic for
targets that match effective-target libatomic_available.
* gfortran.dg/coarray_lib_comm_1.f90: Similar.
Modified:
trunk/gcc/testsuite/gfortran.dg/coarray_lib_comm_1.f90
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2015-01-08 22:00 ` hp at gcc dot gnu.org
@ 2015-01-09 19:22 ` dje at gcc dot gnu.org
2015-01-09 21:09 ` hp at bitrange dot com
2015-01-10 17:08 ` dje at gcc dot gnu.org
13 siblings, 0 replies; 14+ messages in thread
From: dje at gcc dot gnu.org @ 2015-01-09 19:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
David Edelsohn <dje at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target|hppa*-*-hpux* |hppa*-*-hpux*,
| |powerpc-ibm-aix*
CC| |dje at gcc dot gnu.org
Host|hppa*-*-hpux* |hppa*-*-hpux*,
| |powerpc-ibm-aix*
Build|hppa*-*-hpux* |hppa*-*-hpux*,
| |powerpc-ibm-aix*
--- Comment #12 from David Edelsohn <dje at gcc dot gnu.org> ---
This also was failing on AIX. The failures returned after the latest patches.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2015-01-09 19:22 ` dje at gcc dot gnu.org
@ 2015-01-09 21:09 ` hp at bitrange dot com
2015-01-10 17:08 ` dje at gcc dot gnu.org
13 siblings, 0 replies; 14+ messages in thread
From: hp at bitrange dot com @ 2015-01-09 21:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #13 from Hans-Peter Nilsson <hp at bitrange dot com> ---
On Fri, 9 Jan 2015, dje at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
>
> David Edelsohn <dje at gcc dot gnu.org> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Target|hppa*-*-hpux* |hppa*-*-hpux*,
> | |powerpc-ibm-aix*
> CC| |dje at gcc dot gnu.org
> Host|hppa*-*-hpux* |hppa*-*-hpux*,
> | |powerpc-ibm-aix*
> Build|hppa*-*-hpux* |hppa*-*-hpux*,
> | |powerpc-ibm-aix*
>
> --- Comment #12 from David Edelsohn <dje at gcc dot gnu.org> ---
> This also was failing on AIX. The failures returned after the latest patches.
Please quote the top of gfortran.log, the first lines with
-latomic where libatomic_avail is misidentified as missing.
(There's likely an error that's misidentified as libatomic being
missing.)
brgds, H-P
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single
[not found] <bug-62250-4@http.gcc.gnu.org/bugzilla/>
` (12 preceding siblings ...)
2015-01-09 21:09 ` hp at bitrange dot com
@ 2015-01-10 17:08 ` dje at gcc dot gnu.org
13 siblings, 0 replies; 14+ messages in thread
From: dje at gcc dot gnu.org @ 2015-01-10 17:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
--- Comment #14 from David Edelsohn <dje at gcc dot gnu.org> ---
It seems to be fixed on AIX again. The status is confusing with the flurry of
patches.
^ permalink raw reply [flat|nested] 14+ messages in thread