[Bug libfortran/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[Bug libfortran/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> ---
The gfortran command does not explicitly link with libatomic.

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> ---
Author: danglin
Date: Sun Jan  4 01:22:54 2015
New Revision: 219171

URL: https://gcc.gnu.org/viewcvs?rev=219171&root=gcc&view=rev
Log:
    PR testsuite/62250
    * lib/gfortran.exp: Add libatomic library search path.
    * gfortran.dg/coarray/caf.exp: Add -latomic to test options.
    * gfortran.dg/coarray_lib_comm_1.f90: Likewise.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/coarray/caf.exp
    trunk/gcc/testsuite/gfortran.dg/coarray_lib_comm_1.f90
    trunk/gcc/testsuite/lib/gfortran.exp

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from John David Anglin <danglin at gcc dot gnu.org> ---
Fixed.

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hp at gcc dot gnu.org

--- Comment #4 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to John David Anglin from comment #3)
> Fixed.

But instead causing these tests to fail for all targets that don't have
-latomic.
I.e. -latomic should only be added when there is one, otherwise assume that
support is built-in as before the patch.  Also, the patch should have used
atomic-dg.exp instead of manually adding the search paths.

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #5 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
(In reply to Hans-Peter Nilsson from comment #4)
> Also, the patch should have used
> atomic-dg.exp instead of manually adding the search paths.

Easier said than done, unfortunately.  Doing a simpler fix.

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #6 from dave.anglin at bell dot net ---
On 2015-01-06, at 9:06 PM, hp at gcc dot gnu.org wrote:

> But instead causing these tests to fail for all targets that don't have
> -latomic.
> I.e. -latomic should only be added when there is one, otherwise assume that
> support is built-in as before the patch.  Also, the patch should have used
> atomic-dg.exp instead of manually adding the search paths.

That is clearly a better approach.

What about the gfortran.dg/coarray_lib_comm_1.f90 test?  Do you see a better
alternative than adding "load_lib atomic-dg.exp" to gfortran.dg/dg.exp?

--
John David Anglin    dave.anglin@bell.net

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #7 from dave.anglin at bell dot net ---
On 2015-01-06, at 10:10 PM, hp at gcc dot gnu.org wrote:

> Easier said than done, unfortunately.  Doing a simpler fix.

Thanks

--
John David Anglin    dave.anglin@bell.net

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #8 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Created attachment 34394
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34394&action=edit
Patch to add -latomic only when available; -p0 -d path/to/gcc/testsuite

David, could you please check if the attached patch still works for
hppa*-*-hpux*?

I've verified that it fixes the regressions I see (cross to cris-elf; a system
without a -latomic port and where the operations are built-in) and that
-latomic is still added for a native x86_64-unknown-linux-gnu build, with tests
still passing.  Though, as -latomic is redundant on that last system, I haven't
actually tested it on a system where -latomic is *required*; the point if this
PR (and BTW sorry for being lazy and hijacking it - a pointer to a new PR would
have been more appropriate).

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #9 from dave.anglin at bell dot net ---
On 2015-01-07 10:03 AM, hp at gcc dot gnu.org wrote:
> David, could you please check if the attached patch still works for
> hppa*-*-hpux*?

I've added your patch to my hpux tree for testing.

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #10 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Author: hp
Date: Thu Jan  8 21:57:49 2015
New Revision: 219364

URL: https://gcc.gnu.org/viewcvs?rev=219364&root=gcc&view=rev
Log:
    PR testsuite/62250
    * lib/target-supports.exp (check_effective_target_libatomic_available):
    New.
    * gfortran.dg/coarray/caf.exp: Only add -latomic for
    targets that match effective-target libatomic_available.
    * gfortran.dg/coarray_lib_comm_1.f90: Similar.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/coarray/caf.exp
    trunk/gcc/testsuite/lib/target-supports.exp

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[hp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #11 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Author: hp
Date: Thu Jan  8 21:59:26 2015
New Revision: 219365

URL: https://gcc.gnu.org/viewcvs?rev=219365&root=gcc&view=rev
Log:
    PR testsuite/62250
    * lib/target-supports.exp (check_effective_target_libatomic_available):
    New.
    * gfortran.dg/coarray/caf.exp: Only add -latomic for
    targets that match effective-target libatomic_available.
    * gfortran.dg/coarray_lib_comm_1.f90: Similar.

Modified:
    trunk/gcc/testsuite/gfortran.dg/coarray_lib_comm_1.f90

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

David Edelsohn <dje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|hppa*-*-hpux*               |hppa*-*-hpux*,
                   |                            |powerpc-ibm-aix*
                 CC|                            |dje at gcc dot gnu.org
               Host|hppa*-*-hpux*               |hppa*-*-hpux*,
                   |                            |powerpc-ibm-aix*
              Build|hppa*-*-hpux*               |hppa*-*-hpux*,
                   |                            |powerpc-ibm-aix*

--- Comment #12 from David Edelsohn <dje at gcc dot gnu.org> ---
This also was failing on AIX.  The failures returned after the latest patches.

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[hp at bitrange dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #13 from Hans-Peter Nilsson <hp at bitrange dot com> ---
On Fri, 9 Jan 2015, dje at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250
>
> David Edelsohn <dje at gcc dot gnu.org> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Target|hppa*-*-hpux*               |hppa*-*-hpux*,
>                    |                            |powerpc-ibm-aix*
>                  CC|                            |dje at gcc dot gnu.org
>                Host|hppa*-*-hpux*               |hppa*-*-hpux*,
>                    |                            |powerpc-ibm-aix*
>               Build|hppa*-*-hpux*               |hppa*-*-hpux*,
>                    |                            |powerpc-ibm-aix*
>
> --- Comment #12 from David Edelsohn <dje at gcc dot gnu.org> ---
> This also was failing on AIX.  The failures returned after the latest patches.

Please quote the top of gfortran.log, the first lines with
-latomic where libatomic_avail is misidentified as missing.
(There's likely an error that's misidentified as libatomic being
missing.)

brgds, H-P

[Bug testsuite/62250] FAIL: gfortran.dg/coarray/alloc_comp_1.f90 -fcoarray=lib -O2 -lcaf_single

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62250

--- Comment #14 from David Edelsohn <dje at gcc dot gnu.org> ---
It seems to be fixed on AIX again.  The status is confusing with the flurry of
patches.