public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "wschmidt at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/62301] [5 Regression] PowerPC bootstrap broken since r214654
Date: Fri, 29 Aug 2014 13:42:00 -0000	[thread overview]
Message-ID: <bug-62301-4-swrZGnYnJC@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-62301-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62301

--- Comment #3 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
Looks like a subtle logic change in the patch:

+  FOR_EACH_SUBRTX (iter, array, body, ALL)
+    if (const_rtx y = *iter)
+      {
+       /* Check if a label_ref Y refers to label X.  */
+       if (GET_CODE (y) == LABEL_REF && LABEL_P (y) && XEXP (y, 0) == x)
+         return true;

-  if (*body == NULL_RTX)
-    return y == NULL_RTX;
+       if (rtx_equal_p (x, y))
+         return true;

-  /* Return true if a label_ref *BODY refers to label Y.  */
-  if (GET_CODE (*body) == LABEL_REF && LABEL_P (y))
-    return XEXP (*body, 0) == y;

If XEXP (y, 0) != x, it seems we should return false to match what was done
before.  Testing a patch to fix this.


  parent reply	other threads:[~2014-08-29 13:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29  3:12 [Bug bootstrap/62301] New: " wschmidt at gcc dot gnu.org
2014-08-29  4:19 ` [Bug bootstrap/62301] " wschmidt at gcc dot gnu.org
2014-08-29  8:56 ` [Bug bootstrap/62301] [5 Regression] " rguenth at gcc dot gnu.org
2014-08-29 13:20 ` wschmidt at gcc dot gnu.org
2014-08-29 13:42 ` wschmidt at gcc dot gnu.org [this message]
2014-08-29 14:11 ` wschmidt at gcc dot gnu.org
2014-08-29 15:00 ` rsandifo at gcc dot gnu.org
2014-08-29 15:45 ` wschmidt at gcc dot gnu.org
2014-08-29 15:51 ` rsandifo at gcc dot gnu.org
2014-08-29 15:55 ` rsandifo at gcc dot gnu.org
2014-08-29 16:09 ` wschmidt at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-62301-4-swrZGnYnJC@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).