public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ebotcazou at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/62631] gcc.dg/tree-ssa/ivopts-lt-2.c FAILs
Date: Fri, 06 Feb 2015 07:10:00 -0000	[thread overview]
Message-ID: <bug-62631-4-X5hgkdVq3j@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-62631-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62631

--- Comment #19 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> The assembly is as below on sparc64:
> f1:
> 	.register	%g2, #scratch
> 	sllx	%o1, 2, %g1
> 	mov	99, %g2
> 	add	%o0, %g1, %o0
> 	sub	%g2, %o1, %o1
> 	srl	%o1, 0, %g1
> 	add	%g1, 1, %g1
> 	sllx	%g1, 2, %g1
> 	add	%o0, %g1, %g1
> 	st	%g0, [%o0]
> .LL5:
> 	add	%o0, 4, %o0
> 	cmp	%o0, %g1
> 	blu,a,pt %xcc, .LL5
> 	 st	%g0, [%o0]
> 	jmp	%o7+8
> 	 nop

How did you configure the compiler?  We're talking about 64-bit SPARC/Solaris
and here's the code actually generated for the time being:

        .type   f1, #function
        .proc   020
f1:
        sllx    %o1, 2, %g1
        add     %o0, %g1, %o0
.LL2:
        st      %g0, [%o0]
        add     %o1, 1, %g1
        add     %o0, 4, %o0
        cmp     %g1, 99
        bleu,pt %icc, .LL2
         srl    %g1, 0, %o1
        jmp     %o7+8
         nop

so it is still suboptimal, hence my generic fix.
>From gcc-bugs-return-476212-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Feb 06 07:22:17 2015
Return-Path: <gcc-bugs-return-476212-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 6786 invoked by alias); 6 Feb 2015 07:22:16 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 6728 invoked by uid 48); 6 Feb 2015 07:22:13 -0000
From: "amker at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/62631] gcc.dg/tree-ssa/ivopts-lt-2.c FAILs
Date: Fri, 06 Feb 2015 07:22:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: amker at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-62631-4-eNx22NbpSz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-62631-4@http.gcc.gnu.org/bugzilla/>
References: <bug-62631-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg00545.txt.bz2
Content-length: 1251

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62631

--- Comment #20 from amker at gcc dot gnu.org ---
(In reply to Eric Botcazou from comment #19)
> > The assembly is as below on sparc64:
> > f1:
> > 	.register	%g2, #scratch
> > 	sllx	%o1, 2, %g1
> > 	mov	99, %g2
> > 	add	%o0, %g1, %o0
> > 	sub	%g2, %o1, %o1
> > 	srl	%o1, 0, %g1
> > 	add	%g1, 1, %g1
> > 	sllx	%g1, 2, %g1
> > 	add	%o0, %g1, %g1
> > 	st	%g0, [%o0]
> > .LL5:
> > 	add	%o0, 4, %o0
> > 	cmp	%o0, %g1
> > 	blu,a,pt %xcc, .LL5
> > 	 st	%g0, [%o0]
> > 	jmp	%o7+8
> > 	 nop
> 
> How did you configure the compiler?  We're talking about 64-bit
> SPARC/Solaris and here's the code actually generated for the time being:
> 
>         .type   f1, #function
>         .proc   020
> f1:
>         sllx    %o1, 2, %g1
>         add     %o0, %g1, %o0
> .LL2:
>         st      %g0, [%o0]
>         add     %o1, 1, %g1
>         add     %o0, 4, %o0
>         cmp     %g1, 99
>         bleu,pt %icc, .LL2
>          srl    %g1, 0, %o1
>         jmp     %o7+8
>          nop
> 
> so it is still suboptimal, hence my generic fix.
Ouch, my bad.  That code is generated because I forced gcc to do the iv
replacement by decreasing the cost.  The trunk generates assembly just like
yours.

Thanks.
>From gcc-bugs-return-476213-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Feb 06 08:12:06 2015
Return-Path: <gcc-bugs-return-476213-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3760 invoked by alias); 6 Feb 2015 08:12:06 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3693 invoked by uid 48); 6 Feb 2015 08:12:02 -0000
From: "law at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/17982] stop calling assemble_external before final assembly output time
Date: Fri, 06 Feb 2015 08:12:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 4.0.0
X-Bugzilla-Keywords: FIXME
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: law at redhat dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cc resolution
Message-ID: <bug-17982-4-Y9dzeBGGnv@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-17982-4@http.gcc.gnu.org/bugzilla/>
References: <bug-17982-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg00546.txt.bz2
Content-length: 507

https://gcc.gnu.org/bugzilla/show_bug.cgi?id\x17982

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |law at redhat dot com
         Resolution|---                         |FIXED

--- Comment #36 from Jeffrey A. Law <law at redhat dot com> ---
This was fixed in 2012.


  parent reply	other threads:[~2015-02-06  7:10 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01 13:52 [Bug tree-optimization/62631] New: " ro at gcc dot gnu.org
2014-09-01 13:53 ` [Bug tree-optimization/62631] " ro at gcc dot gnu.org
2014-09-01 14:06 ` ro at gcc dot gnu.org
2014-09-01 14:26 ` ro at gcc dot gnu.org
2014-09-01 14:27 ` ro at gcc dot gnu.org
2014-09-02  6:00 ` amker.cheng at gmail dot com
2014-09-07 19:37 ` danglin at gcc dot gnu.org
2014-09-11  5:48 ` amker at gcc dot gnu.org
2014-09-11  8:43 ` ro at CeBiTec dot Uni-Bielefeld.DE
2014-09-12 10:58 ` ro at CeBiTec dot Uni-Bielefeld.DE
2015-02-02 23:22 ` [Bug target/62631] " ebotcazou at gcc dot gnu.org
2015-02-03  9:57 ` ebotcazou at gcc dot gnu.org
2015-02-03 10:54 ` amker at gcc dot gnu.org
2015-02-04  4:06 ` amker at gcc dot gnu.org
2015-02-04 11:45 ` ebotcazou at gcc dot gnu.org
2015-02-04 14:43 ` ebotcazou at gcc dot gnu.org
2015-02-06  6:20 ` amker at gcc dot gnu.org
2015-02-06  7:10 ` ebotcazou at gcc dot gnu.org [this message]
2015-02-06 11:18 ` ebotcazou at gcc dot gnu.org
2015-02-06 11:26 ` ebotcazou at gcc dot gnu.org
2015-02-06 11:33 ` ebotcazou at gcc dot gnu.org
2015-02-06 15:52 ` dave.anglin at bell dot net
2015-02-07 19:08 ` dave.anglin at bell dot net
2015-02-07 22:24 ` ebotcazou at gcc dot gnu.org
2015-02-07 23:14 ` dave.anglin at bell dot net
2015-02-08 14:07 ` amker at gcc dot gnu.org
2015-02-08 14:09 ` amker at gcc dot gnu.org
2015-02-08 14:59 ` dave.anglin at bell dot net
2015-02-08 21:44 ` ebotcazou at gcc dot gnu.org
2015-02-09  3:24 ` amker at gcc dot gnu.org
2015-02-09  8:11 ` amker at gcc dot gnu.org
2015-04-22 12:01 ` jakub at gcc dot gnu.org
2015-07-16  9:13 ` rguenth at gcc dot gnu.org
2022-01-09  0:42 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-62631-4-X5hgkdVq3j@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).