public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/63175] [4.9/5 regression] FAIL: gcc.dg/vect/costmodel/ppc/costmodel-bb-slp-9a.c scan-tree-dump-times slp2" basic block vectorized using SLP" 1
Date: Mon, 02 Mar 2015 14:24:00 -0000	[thread overview]
Message-ID: <bug-63175-4-mzU8wOWRoJ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-63175-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63175

--- Comment #16 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #15)
> Btw, first of all unaligned stores are not supported according to the targets
> vectorization hook, thus you'd need to peel the loop to make the store
> aligned
> which for some reason doesn't happen.

Quite obvious - the loop iterates 8 times but the vectorization factor is 8
as well, so if we peel off a iteration to align the destination the vectorized
loop will never enter.

Why is the loop bound to i != 16 / sizeof *s?

>  But when peeled you certainly will see
> byte/short/word stores at least.

Like when I increase the iteration count I get for copy_short_0_1:

.L.copy_Type_0_1:
        addis 6,2,.LANCHOR0@toc@ha
        addis 7,2,.LANCHOR1@toc@ha
        addi 6,6,.LANCHOR0@toc@l
        addi 7,7,.LANCHOR1@toc@l
        li 8,7
        addi 9,6,2
        mr 10,7
        mtctr 8
        .p2align 4,,15
.L2:
        addi 10,10,2
        lhz 8,-2(10)
        addi 9,9,2
        sth 8,-2(9)
        bdnz .L2
        addi 8,7,14
        addi 7,7,29
        neg 5,8
        lvx 1,0,8
        lvx 0,0,7
        li 7,16
        lvsr 13,0,5
        addi 8,10,14
        addi 9,9,14
        addi 10,10,16
        vperm 0,1,0,13
        stvx 0,6,7
        .p2align 4,,15
.L3:
        lhzu 7,2(8)
        cmpld 7,10,8
        sthu 7,2(9)
        bne+ 7,.L3
        blr

the cost model should probably reject this, but it does not:

t.c:36:1: note: Cost model analysis:
  Vector inside of loop cost: 3
  Vector prologue cost: 17
  Vector epilogue cost: 2
  Scalar iteration cost: 2
  Scalar outside cost: 0
  Vector outside cost: 19
  prologue iterations: 7
  epilogue iterations: 1
  Calculated minimum iters for profitability: 10


  parent reply	other threads:[~2015-03-02 14:24 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-63175-4@http.gcc.gnu.org/bugzilla/>
2014-09-05  8:47 ` rguenth at gcc dot gnu.org
2014-10-30 10:42 ` jakub at gcc dot gnu.org
2014-11-24 13:16 ` rguenth at gcc dot gnu.org
2015-02-21 20:07 ` msebor at gcc dot gnu.org
2015-02-22 20:38 ` macro@linux-mips.org
2015-02-24  6:56 ` msebor at gcc dot gnu.org
2015-02-25 20:45 ` msebor at gcc dot gnu.org
2015-02-26 10:19 ` rguenth at gcc dot gnu.org
2015-02-26 10:56 ` rguenth at gcc dot gnu.org
2015-02-27  9:18 ` rguenth at gcc dot gnu.org
2015-02-27  9:49 ` rguenth at gcc dot gnu.org
2015-02-27 11:23 ` rguenth at gcc dot gnu.org
2015-02-27 11:24 ` rguenth at gcc dot gnu.org
2015-02-28  9:26 ` msebor at gcc dot gnu.org
2015-03-02 14:14 ` rguenth at gcc dot gnu.org
2015-03-02 14:24 ` rguenth at gcc dot gnu.org [this message]
2015-03-02 16:24 ` msebor at gcc dot gnu.org
2015-03-02 16:48 ` rguenther at suse dot de
2015-03-02 16:50 ` rguenther at suse dot de
2015-03-02 16:58 ` msebor at gcc dot gnu.org
2015-03-02 17:47 ` rguenther at suse dot de
2015-03-02 18:13 ` msebor at gcc dot gnu.org
2015-03-02 18:23 ` rguenther at suse dot de
2015-03-03  5:10 ` msebor at gcc dot gnu.org
2015-03-03  9:21 ` rguenther at suse dot de
2015-03-03  9:42 ` rguenth at gcc dot gnu.org
2015-03-03 15:05 ` dje at gcc dot gnu.org
2015-03-03 16:19 ` wschmidt at gcc dot gnu.org
2015-03-03 16:22 ` wschmidt at gcc dot gnu.org
2015-03-04  1:15 ` msebor at gcc dot gnu.org
2015-03-04  9:17 ` rguenth at gcc dot gnu.org
2015-03-04 13:42 ` dje at gcc dot gnu.org
2015-03-04 13:55 ` rguenther at suse dot de
2015-03-06 18:44 ` msebor at gcc dot gnu.org
2015-03-07 16:19 ` [Bug testsuite/63175] [4.9 " law at redhat dot com
2015-03-10 21:07 ` msebor at gcc dot gnu.org
2015-03-11 10:09 ` rguenth at gcc dot gnu.org
2015-03-23 18:58 ` msebor at gcc dot gnu.org
2015-05-29 16:49 ` wschmidt at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63175-4-mzU8wOWRoJ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).