[Bug ada/63225] New: ada bootstrap failure when -fno-inline in STAGE1_CFLAGS

[Bug ada/63225] New: ada bootstrap failure when -fno-inline in STAGE1_CFLAGS

[amodra at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63225

            Bug ID: 63225
           Summary: ada bootstrap failure when -fno-inline in
                    STAGE1_CFLAGS
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: amodra at gmail dot com

When building mainline with STAGE1_CFLAGS="-g -O -fno-inline", with a system
gnat 4.6, I see

ada/cuintp.o: In function `UI_From_gnu':
/src/gcc-current/gcc/ada/gcc-interface/cuintp.c:186: undefined reference to
`uintp__vector_to_uint'

So, ada/uintp.o has uintp__vector_to_uint as a *local* symbol, which seems
reasonable to me since Vector_To_Uint isn't declared in uintp.ads.  I worked
around the problem by the attached patch, then reverted the patch and verified
the newly built gnat exhibited the same behaviour.

./xgcc -B./ -c -g -O -fno-inline -gnatpg -gnatwns -gnata -Wall -nostdinc -I-
-I. -Iada -I/src/gcc-current/gcc/ada -I/src/gcc-current/gcc/ada/gcc-interface
/src/gcc-current/gcc/ada/uintp.adb -o ada/uintp.o

gets me the local uintp__vector_to_uint, removing -fno-inline gives me a global
symbol.  That seems really odd, but by no stretch of imagination am I an ada
programmer.

[Bug ada/63225] ada bootstrap failure when -fno-inline in STAGE1_CFLAGS

[amodra at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63225

--- Comment #1 from Alan Modra <amodra at gmail dot com> ---
Created attachment 33472
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33472&action=edit
Declare Vector_To_Uint

[Bug ada/63225] ada bootstrap failure when -fno-inline in STAGE1_CFLAGS

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63225

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-09-21
                 CC|                            |ebotcazou at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
It's because we have inter-unit inlining in the Ada compiler even w/o LTO.

[Bug ada/63225] ada bootstrap failure when -fno-inline in STAGE1_CFLAGS

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63225

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Author: ebotcazou
Date: Mon Oct 13 08:19:45 2014
New Revision: 216139

URL: https://gcc.gnu.org/viewcvs?rev=216139&root=gcc&view=rev
Log:
    PR ada/63225
    * uintp.adb (Vector_To_Uint): Move from here to...
    * uintp.ads (UI_Vector): Make public.
    (Vector_To_Uint): ...here.

Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/uintp.adb
    trunk/gcc/ada/uintp.ads

[Bug ada/63225] ada bootstrap failure when -fno-inline in STAGE1_CFLAGS

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63225

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Author: ebotcazou
Date: Mon Oct 13 08:20:30 2014
New Revision: 216140

URL: https://gcc.gnu.org/viewcvs?rev=216140&root=gcc&view=rev
Log:
    PR ada/63225
    * uintp.adb (Vector_To_Uint): Move from here to...
    * uintp.ads (UI_Vector): Make public.
    (Vector_To_Uint): ...here.

Modified:
    branches/gcc-4_9-branch/gcc/ada/ChangeLog
    branches/gcc-4_9-branch/gcc/ada/uintp.adb
    branches/gcc-4_9-branch/gcc/ada/uintp.ads

[Bug ada/63225] ada bootstrap failure when -fno-inline in STAGE1_CFLAGS

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63225

--- Comment #5 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Author: ebotcazou
Date: Mon Oct 13 08:21:19 2014
New Revision: 216141

URL: https://gcc.gnu.org/viewcvs?rev=216141&root=gcc&view=rev
Log:
    PR ada/63225
    * uintp.adb (Vector_To_Uint): Move from here to...
    * uintp.ads (UI_Vector): Make public.
    (Vector_To_Uint): ...here.

Modified:
    branches/gcc-4_8-branch/gcc/ada/ChangeLog
    branches/gcc-4_8-branch/gcc/ada/uintp.adb
    branches/gcc-4_8-branch/gcc/ada/uintp.ads

[Bug ada/63225] ada bootstrap failure when -fno-inline in STAGE1_CFLAGS

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63225

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.8.4

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Thanks for reporting the problem and providing a fix.