[Bug c/63235] New: building fails with --disable-bootstrap

[Bug c/63235] New: building fails with --disable-bootstrap

[andi-gcc at firstfloor dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

            Bug ID: 63235
           Summary: building fails with --disable-bootstrap
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: andi-gcc at firstfloor dot org

When I build with --disable-bootstrap i now always get

Host compiler

gcc version 4.8.1 20130909 [gcc-4_8-branch revision 202388] (SUSE Linux) 

Is the new C++ tree code getting miscompiled?

libtool: compile:  /home/ak/gcc/obj/./gcc/xgcc -B/home/ak/gcc/obj/./gcc/
-B/usr/local/x86_64-unknown-linux-gnu/bin/
-B/usr/local/x86_64-unknown-linux-gnu/lib/ -isystem
/usr/local/x86_64-unknown-linux-gnu/include -isystem
/usr/local/x86_64-unknown-linux-gnu/sys-include "-DPACKAGE_NAME=\"Cilk Runtime
Library\"" -DPACKAGE_TARNAME=\"cilk-runtime-library\" -DPACKAGE_VERSION=\"2.0\"
"-DPACKAGE_STRING=\"Cilk Runtime Library 2.0\""
-DPACKAGE_BUGREPORT=\"cilk@intel.com\" -DPACKAGE_URL=\"\"
-DPACKAGE=\"cilk-runtime-library\" -DVERSION=\"2.0\" -DSTDC_HEADERS=1
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_UNISTD_H=1 -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1
-DHAVE_ATTRIBUTE_VISIBILITY=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\"
-DHAVE_PTHREAD_AFFINITY_NP=1 -I. -I../../../gcc/libcilkrts
-I../../../gcc/libcilkrts/include -I../../../gcc/libcilkrts/runtime
-I../../../gcc/libcilkrts/runtime/config/x86 -DIN_CILK_RUNTIME=1 -pthread
-fcilkplus -I../../../gcc/libcilkrts/include -I../../../gcc/libcilkrts/runtime
-I../../../gcc/libcilkrts/runtime/config/x86 -DIN_CILK_RUNTIME=1 -fcilkplus
-std=c99 -g -O2 -MT os-unix-sysdep.lo -MD -MP -MF .deps/os-unix-sysdep.Tpo -c
../../../gcc/libcilkrts/runtime/config/x86/os-unix-sysdep.c  -fPIC -DPIC -o
.libs/os-unix-sysdep.o
../../../gcc/libcilkrts/runtime/config/x86/os-unix-sysdep.c: In function
'restore_x86_fp_state':
../../../gcc/libcilkrts/runtime/config/x86/os-unix-sysdep.c:114:5: internal
compiler error: tree check: expected tree_list, have var_decl in
get_attribute_name, at attribs.c:679
     if (__builtin_cpu_supports("sse"))
     ^
0xc814f4 tree_check_failed(tree_node const*, char const*, int, char const*,
...)
    ../../gcc/gcc/tree.c:9160
0x574a45 tree_check
    ../../gcc/gcc/tree.h:2967
0x574a45 get_attribute_name(tree_node const*)
    ../../gcc/gcc/attribs.c:679
0xc84605 private_lookup_attribute(char const*, unsigned long, tree_node*)
    ../../gcc/gcc/tree.c:5746
0xcdbf78 lookup_attribute
    ../../gcc/gcc/tree.h:3773
0xcdbf78 varpool_node::add(tree_node*)
    ../../gcc/gcc/varpool.c:452
0xcf9942 fold_builtin_cpu
    ../../gcc/gcc/config/i386/i386.c:32484
0x69017f fold_builtin_call_array(unsigned int, tree_node*, tree_node*, int,
tree_node**)
    ../../gcc/gcc/builtins.c:10565
0x5acca4 build_function_call_vec(unsigned int, vec<unsigned int, va_heap,
vl_ptr>, tree_node*, vec<tree_node*, va_gc, vl_embed>*, vec<tree_node*, va_gc,
vl_embed>*)

[Bug c/63235] building fails with --disable-bootstrap

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #1 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
*** Bug 63236 has been marked as a duplicate of this bug. ***

[Bug c/63235] building fails with --disable-bootstrap

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2014-09-12
                 CC|                            |trippels at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Please attach an preprocessed testcase.

[Bug c/63235] building fails with --disable-bootstrap

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #3 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Also please try to reproduce with 4.8.3.

[Bug c/63235] building fails with --disable-bootstrap

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Maybe this is why bootstrap is even more important :).

[Bug bootstrap/63235] building fails with --disable-bootstrap

[andi-gcc at firstfloor dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #5 from Andi Kleen <andi-gcc at firstfloor dot org> ---
Created attachment 33482
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33482&action=edit
use ifdef instead of builtin_cpu_supports

This patch fixes the problem for me.

Just use an ifdef instead of builtin_cpu_supports.

[Bug bootstrap/63235] building fails with --disable-bootstrap

[andi-gcc at firstfloor dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #6 from Andi Kleen <andi-gcc at firstfloor dot org> ---
Created attachment 33483
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33483&action=edit
Preprocessed file from the cilk runtime library

I'm not sure it'll help you because you would likely need a compiler
miscompiled in the same way as mine?

[Bug bootstrap/63235] building fails with --disable-bootstrap

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #7 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
(In reply to Andi Kleen from comment #6)
> Created attachment 33483 [details]
> Preprocessed file from the cilk runtime library
> 
> I'm not sure it'll help you because you would likely need a compiler
> miscompiled in the same way as mine?

There were surly a number of wrong-code bugs fixed between 
your version 4.8.1 20130909 and the 4.8.3 release.

I cannot reproduce the issue with 4.8.3.

[Bug bootstrap/63235] building fails with --disable-bootstrap

[andi-gcc at firstfloor dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #8 from Andi Kleen <andi-gcc at firstfloor dot org> ---
Yes it doesn't happen when compiling with 4.8 branch tip. So has been fixed.

Anyways i'm still going to submit the patch to make the opensuse 13.1 build
work again. I don't think it should hurt anything here to use ifdef.

[Bug bootstrap/63235] building fails with --disable-bootstrap

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #9 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Andi Kleen from comment #8)
> Yes it doesn't happen when compiling with 4.8 branch tip. So has been fixed.
> 
> Anyways i'm still going to submit the patch to make the opensuse 13.1 build
> work again. I don't think it should hurt anything here to use ifdef.

The difference is run-time check vs compile-time check.

[Bug bootstrap/63235] building fails with --disable-bootstrap

[andi-gcc at firstfloor dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #10 from Andi Kleen <andi-gcc at firstfloor dot org> ---
Ok fair enough.

Can do the runtime check in the else of the ifdef then.

Then at least x86_64 or 32bit with SSE would work.

[Bug bootstrap/63235] building fails with --disable-bootstrap

[andi-gcc at firstfloor dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #11 from Andi Kleen <andi-gcc at firstfloor dot org> ---
Actually I now get similar errors when doing a standard (LTO) boot strap and
running the test suite. Several tests in the test suite fail with the same ICE.

That's surprising, I thought the test suite is done with stage2, so the host
compiler should not impact it?

/home/andi/gcc/git/gcc/gcc/testsuite/g++.dg/ext/mv1.C: In function 'int
main()':
/home/andi/gcc/git/gcc/gcc/testsuite/g++.dg/ext/mv1.C:40:33: internal compiler
error: tree check: expected tree_list, have var_decl in get_attribute_name, at
attribs.c:679
0xe2f55b tree_check_failed(tree_node const*, char const*, int, char const*,
...)
        /home/andi/gcc/git/gcc/gcc/tree.c:9166
0xdb8431 tree_check(tree_node const*, char const*, int, char const*, tree_code)



These all fail with the same ICE:

FAIL: gcc.target/i386/builtin_target.c (internal compiler error)
FAIL: gcc.target/i386/builtin_target.c (test for excess errors)
WARNING: gcc.target/i386/builtin_target.c compilation failed to produce
executable

FAIL: g++.dg/ext/mv1.C  -std=gnu++98 (internal compiler error)
FAIL: g++.dg/ext/mv1.C  -std=gnu++98 (test for excess errors)
WARNING: g++.dg/ext/mv1.C  -std=gnu++98 compilation failed to produce
executable
FAIL: g++.dg/ext/mv1.C  -std=gnu++11 (internal compiler error)
FAIL: g++.dg/ext/mv1.C  -std=gnu++11 (test for excess errors)
WARNING: g++.dg/ext/mv1.C  -std=gnu++11 compilation failed to produce
executable
FAIL: g++.dg/ext/mv1.C  -std=gnu++1y (internal compiler error)
FAIL: g++.dg/ext/mv1.C  -std=gnu++1y (test for excess errors)
WARNING: g++.dg/ext/mv1.C  -std=gnu++1y compilation failed to produce
executable
FAIL: g++.dg/ext/mv12.C  -std=gnu++98 (internal compiler error)
FAIL: g++.dg/ext/mv12.C  -std=gnu++98 (test for excess errors)
WARNING: g++.dg/ext/mv12.C  -std=gnu++98 compilation failed to produce
executable
FAIL: g++.dg/ext/mv12.C  -std=gnu++11 (internal compiler error)
FAIL: g++.dg/ext/mv12.C  -std=gnu++11 (test for excess errors)
WARNING: g++.dg/ext/mv12.C  -std=gnu++11 compilation failed to produce
executable
FAIL: g++.dg/ext/mv12.C  -std=gnu++1y (internal compiler error)
FAIL: g++.dg/ext/mv12.C  -std=gnu++1y (test for excess errors)
WARNING: g++.dg/ext/mv12.C  -std=gnu++1y compilation failed to produce
executable
FAIL: g++.dg/ext/mv14.C  -std=gnu++98 (internal compiler error)
FAIL: g++.dg/ext/mv14.C  -std=gnu++98 (test for excess errors)
WARNING: g++.dg/ext/mv14.C  -std=gnu++98 compilation failed to produce
executable
FAIL: g++.dg/ext/mv14.C  -std=gnu++11 (internal compiler error)
FAIL: g++.dg/ext/mv14.C  -std=gnu++11 (test for excess errors)
WARNING: g++.dg/ext/mv14.C  -std=gnu++11 compilation failed to produce
executable
FAIL: g++.dg/ext/mv14.C  -std=gnu++1y (internal compiler error)
FAIL: g++.dg/ext/mv14.C  -std=gnu++1y (test for excess errors)
WARNING: g++.dg/ext/mv14.C  -std=gnu++1y compilation failed to produce
executable
FAIL: g++.dg/ext/mv15.C  -std=gnu++98 (internal compiler error)
FAIL: g++.dg/ext/mv15.C  -std=gnu++98 (test for excess errors)
WARNING: g++.dg/ext/mv15.C  -std=gnu++98 compilation failed to produce
executable
FAIL: g++.dg/ext/mv15.C  -std=gnu++11 (internal compiler error)
FAIL: g++.dg/ext/mv15.C  -std=gnu++11 (test for excess errors)
WARNING: g++.dg/ext/mv15.C  -std=gnu++11 compilation failed to produce
executable
FAIL: g++.dg/ext/mv15.C  -std=gnu++1y (internal compiler error)
FAIL: g++.dg/ext/mv15.C  -std=gnu++1y (test for excess errors)
WARNING: g++.dg/ext/mv15.C  -std=gnu++1y compilation failed to produce
executable
FAIL: g++.dg/ext/mv16.C  -std=gnu++98 (internal compiler error)
FAIL: g++.dg/ext/mv16.C  -std=gnu++98 (test for excess errors)
WARNING: g++.dg/ext/mv16.C  -std=gnu++98 compilation failed to produce
executable
FAIL: g++.dg/ext/mv16.C  -std=gnu++11 (internal compiler error)
FAIL: g++.dg/ext/mv16.C  -std=gnu++11 (test for excess errors)
WARNING: g++.dg/ext/mv16.C  -std=gnu++11 compilation failed to produce
executable
FAIL: g++.dg/ext/mv16.C  -std=gnu++1y (internal compiler error)
FAIL: g++.dg/ext/mv16.C  -std=gnu++1y (test for excess errors)
WARNING: g++.dg/ext/mv16.C  -std=gnu++1y compilation failed to produce
executable
FAIL: g++.dg/ext/mv2.C  -std=gnu++98 (internal compiler error)
FAIL: g++.dg/ext/mv2.C  -std=gnu++98 (test for excess errors)
WARNING: g++.dg/ext/mv2.C  -std=gnu++98 compilation failed to produce
executable
FAIL: g++.dg/ext/mv5.C  -std=gnu++11 (test for excess errors)
WARNING: g++.dg/ext/mv5.C  -std=gnu++11 compilation failed to produce
executable
FAIL: g++.dg/ext/mv5.C  -std=gnu++1y (internal compiler error)
FAIL: g++.dg/ext/mv5.C  -std=gnu++1y (test for excess errors)
WARNING: g++.dg/ext/mv5.C  -std=gnu++1y compilation failed to produce
executable
FAIL: g++.dg/ext/mv6.C  -std=gnu++98 (internal compiler error)
FAIL: g++.dg/ext/mv6.C  -std=gnu++98 (test for excess errors)
WARNING: g++.dg/ext/mv6.C  -std=gnu++98 compilation failed to produce
executable
FAIL: g++.dg/ext/mv6.C  -std=gnu++11 (internal compiler error)
FAIL: g++.dg/ext/mv6.C  -std=gnu++11 (test for excess errors)
WARNING: g++.dg/ext/mv6.C  -std=gnu++11 compilation failed to produce
executable
FAIL: g++.dg/ext/mv6.C  -std=gnu++1y (internal compiler error)
FAIL: g++.dg/ext/mv6.C  -std=gnu++1y (test for excess errors)


FAIL: g++.dg/ext/pr57548.C  -std=c++98 (internal compiler error)
FAIL: g++.dg/ext/pr57548.C  -std=c++98 (test for excess errors)
FAIL: g++.dg/ext/pr57548.C  -std=c++11 (internal compiler error)
FAIL: g++.dg/ext/pr57548.C  -std=c++11 (test for excess errors)
FAIL: g++.dg/ext/pr57548.C  -std=c++1y (internal compiler error)
FAIL: g++.dg/ext/pr57548.C  -std=c++1y (test for excess errors)

[Bug bootstrap/63235] building fails with --disable-bootstrap

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com

--- Comment #12 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Andi Kleen from comment #0)

> ../../../gcc/libcilkrts/runtime/config/x86/os-unix-sysdep.c: In function
> 'restore_x86_fp_state':
> ../../../gcc/libcilkrts/runtime/config/x86/os-unix-sysdep.c:114:5: internal
> compiler error: tree check: expected tree_list, have var_decl in
> get_attribute_name, at attribs.c:679
>      if (__builtin_cpu_supports("sse"))
>      ^

I also see this one when bootstrapping 20140924, revision 215539.

Interestingly, 20140921 was fine.

[Bug bootstrap/63235] building fails with --disable-bootstrap

[jiwang at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

Jiong Wang <jiwang at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jiwang at gcc dot gnu.org

--- Comment #13 from Jiong Wang <jiwang at gcc dot gnu.org> ---
I run into this issue also. my code is revision 215549

my configure options:

../gcc/configure --enable-languages=c,c++

svn+ssh://gcc.gnu.org/svn/gcc/trunk@215549

[Bug bootstrap/63235] building fails with --disable-bootstrap

[izamyatin at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

Igor Zamyatin <izamyatin at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |izamyatin at gmail dot com

--- Comment #14 from Igor Zamyatin <izamyatin at gmail dot com> ---
Seems, started after r215538

[Bug bootstrap/63235] building fails with --disable-bootstrap

[izamyatin at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #15 from Igor Zamyatin <izamyatin at gmail dot com> ---
Sorry, it's r215537

[Bug bootstrap/63235] building fails with --disable-bootstrap

[kyukhin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

Kirill Yukhin <kyukhin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyukhin at gcc dot gnu.org

--- Comment #16 from Kirill Yukhin <kyukhin at gcc dot gnu.org> ---
patch posted here: https://gcc.gnu.org/ml/gcc-patches/2014-09/msg02090.html

[Bug bootstrap/63235] building fails with --disable-bootstrap

[kyukhin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63235

--- Comment #17 from Kirill Yukhin <kyukhin at gcc dot gnu.org> ---
Author: kyukhin
Date: Wed Sep 24 12:27:30 2014
New Revision: 215552

URL: https://gcc.gnu.org/viewcvs?rev=215552&root=gcc&view=rev
Log:
PR bootstrap/63235

gcc/
    * varpool.c (varpool_node::add): Pass decl attributes
    to lookup_attribute.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/varpool.c