[Bug inline-asm/63282] New: [4.7 regression] ICE in redirect_jump_1

[Bug inline-asm/63282] New: [4.7 regression] ICE in redirect_jump_1

[adam at consulting dot net.nz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63282

            Bug ID: 63282
           Summary: [4.7 regression] ICE in redirect_jump_1
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: inline-asm
          Assignee: unassigned at gcc dot gnu.org
          Reporter: adam at consulting dot net.nz

Created attachment 33502
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33502&action=edit
ice.c:9:1: internal compiler error: in redirect_jump_1, at jump.c:1515

This may be related to Bug #49891 [marked as RESOLVED FIXED].

$ cat ice.c 
#include <stdlib.h>

void fn(void) {
  asm volatile goto ("nop" :: : : a, b);
 a:
  exit(0);
 b:
  return;
}

int main(void) {
  return 0;
}

$ gcc-snapshot.sh --version
gcc (Debian 20140903-1) 5.0.0 20140904 (experimental) [trunk revision 214924]
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ gcc-snapshot.sh -O3 ice.c
ice.c: In function 'fn':
ice.c:9:1: internal compiler error: in redirect_jump_1, at jump.c:1515
 }
 ^
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-snapshot/README.Bugs> for instructions.
Preprocessed source stored into /tmp/ccEJa42m.out file, please attach this to
your bugreport.


gcc-4.7 -O3, gcc-4.8 -O3 and gcc-4.9 -O3 all ICE.

gcc-4.5 -O3 and gcc-4.6 -O3 do NOT ICE.

[Bug inline-asm/63282] [4.8/4.9/5 Regression] ICE in redirect_jump_1

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63282

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-09-17
                 CC|                            |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |4.8.4
            Summary|[4.7 regression] ICE in     |[4.8/4.9/5 Regression] ICE
                   |redirect_jump_1             |in redirect_jump_1
     Ever confirmed|0                           |1

--- Comment #1 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Confirmed.

[Bug inline-asm/63282] [4.8/4.9/5 Regression] ICE in redirect_jump_1

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63282

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r176881.

[Bug inline-asm/63282] [4.8/4.9/5 Regression] ICE in redirect_jump_1

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63282

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 33586
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33586&action=edit
gcc5-pr63282.patch

Untested fix.  Calling redirect_jump_1/indirect_jump_1 on something that isn't
a normal conditional jump, is, weird.

[Bug inline-asm/63282] [4.8/4.9/5 Regression] ICE in redirect_jump_1

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63282

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 33587
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33587&action=edit
gcc5-pr63282-2.patch

Or we can just give up in redirect_jump_1 for asm gotos with > 1 label.
Or both.

I guess I'll try to bootstrap/regtest the first patch with some logging on when
is that new goto cancel hit to see how often does that trigger.

[Bug inline-asm/63282] [4.8/4.9/5 Regression] ICE in redirect_jump_1

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63282

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Tue Sep 30 10:30:45 2014
New Revision: 215712

URL: https://gcc.gnu.org/viewcvs?rev=215712&root=gcc&view=rev
Log:
    PR inline-asm/63282
    * ifcvt.c (dead_or_predicable): Don't call redirect_jump_1
    or invert_jump_1 if jump isn't any_condjump_p.

    * gcc.c-torture/compile/pr63282.c: New test.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr63282.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ifcvt.c
    trunk/gcc/testsuite/ChangeLog

[Bug inline-asm/63282] [4.8/4.9/5 Regression] ICE in redirect_jump_1

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63282

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Tue Sep 30 10:33:25 2014
New Revision: 215713

URL: https://gcc.gnu.org/viewcvs?rev=215713&root=gcc&view=rev
Log:
    PR inline-asm/63282
    * ifcvt.c (dead_or_predicable): Don't call redirect_jump_1
    or invert_jump_1 if jump isn't any_condjump_p.

    * gcc.c-torture/compile/pr63282.c: New test.

Added:
    branches/gcc-4_9-branch/gcc/testsuite/gcc.c-torture/compile/pr63282.c
Modified:
    branches/gcc-4_9-branch/gcc/ChangeLog
    branches/gcc-4_9-branch/gcc/ifcvt.c
    branches/gcc-4_9-branch/gcc/testsuite/ChangeLog

[Bug inline-asm/63282] [4.8/4.9/5 Regression] ICE in redirect_jump_1

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63282

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Should be fixed now.