public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mikulas at artax dot karlin.mff.cuni.cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/63303] Pointer subtraction is broken when using -fsanitize=undefined
Date: Mon, 22 Sep 2014 14:31:00 -0000	[thread overview]
Message-ID: <bug-63303-4-2i8vj41C1F@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-63303-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63303

--- Comment #11 from mikulas at artax dot karlin.mff.cuni.cz ---
Richard Biener: if the middle end tells us that one pointer is greater or equal
than the other pointer, we could do unsigned subtraction and shift.

But if we don't know which pointer is greater, it gets more complicated: To do
correct short* pointer subtraction, we need to subtract pointers using
sub %edx, %eax; rcr $1, %eax --- i.e. shift the carry bit back to the topmost
bit of the result. According to Agner's tables, rcr with 1-bit count takes 1
tick on AMD and 2 ticks on Intel, so the performance penalty isn't that big. On
other architectures that lack rcr, it would be more complicated.

Another possibility is to file a defect report on the C standard and request
that program in comment 4 be considered invalid. - for example, change the
wording to this: "If the result multiplied by the size of the array element is
not representable in an object of that type, the behavior is undefined." - that
would specify that that subtraction is invalid.


  parent reply	other threads:[~2014-09-22 14:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19  1:42 [Bug c/63303] New: " mikulas at artax dot karlin.mff.cuni.cz
2014-09-19  7:26 ` [Bug c/63303] " jakub at gcc dot gnu.org
2014-09-19 13:38 ` mikulas at artax dot karlin.mff.cuni.cz
2014-09-19 13:47 ` jakub at gcc dot gnu.org
2014-09-19 15:50 ` mikulas at artax dot karlin.mff.cuni.cz
2014-09-19 15:57 ` jakub at gcc dot gnu.org
2014-09-19 16:15 ` mikulas at artax dot karlin.mff.cuni.cz
2014-09-19 16:21 ` joseph at codesourcery dot com
2014-09-19 16:22 ` jakub at gcc dot gnu.org
2014-09-19 16:29 ` mikulas at artax dot karlin.mff.cuni.cz
2014-09-22  7:42 ` rguenth at gcc dot gnu.org
2014-09-22 14:31 ` mikulas at artax dot karlin.mff.cuni.cz [this message]
2015-10-19 11:03 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-63303-4-2i8vj41C1F@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).